From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Hashe Subject: Re: [PATCH] gnu: Add gnugo. Date: Thu, 19 Feb 2015 22:17:20 -0600 Message-ID: <1424405840.31280.16.camel@Octavian> References: <1424354241-31310-1-git-send-email-david.hashe@dhashe.com> <87twyhfp3b.fsf@netris.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-GUqAVBt/mMZhYAucnUoZ" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:53010) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOf1p-0003vP-NW for guix-devel@gnu.org; Thu, 19 Feb 2015 23:17:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YOf1m-0007pZ-Gr for guix-devel@gnu.org; Thu, 19 Feb 2015 23:17:25 -0500 Received: from mail-ig0-x22e.google.com ([2607:f8b0:4001:c05::22e]:38396) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOf1m-0007pV-9j for guix-devel@gnu.org; Thu, 19 Feb 2015 23:17:22 -0500 Received: by mail-ig0-f174.google.com with SMTP id b16so580315igk.1 for ; Thu, 19 Feb 2015 20:17:21 -0800 (PST) In-Reply-To: <87twyhfp3b.fsf@netris.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Mark H Weaver Cc: guix-devel@gnu.org --=-GUqAVBt/mMZhYAucnUoZ Content-Type: text/plain; charset="UTF-7" Content-Transfer-Encoding: 7bit Taking everyone's feedback into account, here is the updated patch. David On Thu, 2015-02-19 at 18:39 -0500, Mark H Weaver wrote: +AD4 Hi+ACE +AD4 +AD4 David Hashe +ADw-david.hashe+AEA-dhashe.com+AD4 writes: +AD4 +AD4 +AD4 --- +AD4 +AD4 gnu-system.am +AHw 1 +AD4 +AD4 gnu/packages/gnugo.scm +AHw 44 ++++++++++++++++++++++++++++++++++++++++++++2fileschanged, 45 insertions() +AD4 +AD4 create mode 100644 gnu/packages/gnugo.scm +AD4 +AD4 I agree with the feedback from Alex Kost and Andreas Enge, +AD4 and will only add two more comments: +AD4 +AD4 +ACo It needs a proper commit message. Assuming that it ends up in +AD4 games.scm, the commit message would be: +AD4 +AD4 --8+ADw----------------cut here---------------start-------------+AD4-8--- +AD4 gnu: Add gnugo. +AD4 +AD4 +ACo gnu/packages/games.scm (gnugo): New variable. +AD4 --8+ADw----------------cut here---------------end---------------+AD4-8--- +AD4 +AD4 +ACo Regarding the 'texinfo' input: I'm not sure if it's needed or not, but +AD4 if it turns out to be needed, it certainly belongs in 'native-inputs', +AD4 not 'inputs'. The difference is only important when cross-compiling. +AD4 +AD4 Thank you, and welcome to our community :) +AD4 +AD4 Mark --=-GUqAVBt/mMZhYAucnUoZ Content-Disposition: attachment; filename="gnugo.patch" Content-Type: text/x-patch; name="gnugo.patch"; charset="UTF-7" Content-Transfer-Encoding: 8bit >From f694d4edd90094a98875456cae689c37d8d1765e Mon Sep 17 00:00:00 2001 From: David Hashe Date: Thu, 19 Feb 2015 18:47:55 -0600 Subject: [PATCH] gnu: Add gnugo. * gnu/packages/games.scm (gnugo): New variable. --- gnu/packages/games.scm | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm index 9b8983e..687e037 100644 --- a/gnu/packages/games.scm +++ b/gnu/packages/games.scm @@ -8,6 +8,7 @@ ;;; Copyright © 2014, 2015 Sou Bunnbu ;;; Copyright © 2014 Mark H Weaver ;;; Copyright © 2015 Andreas Enge +;;; Copyright © 2015 David Hashe ;;; ;;; This file is part of GNU Guix. ;;; @@ -834,3 +835,27 @@ straight into any libretro-compatible frontend. RetroArch is the official reference frontend for the libretro API, currently used by most as a modular multi-system game/emulator system.") (license license:gpl3+))) + +(define-public gnugo + (package + (name "gnugo") + (version "3.8") + (source (origin + (method url-fetch) + (uri (string-append "mirror://gnu/gnugo/gnugo-" version + ".tar.gz")) + (sha256 + (base32 + "0wkahvqpzq6lzl5r49a4sd4p52frdmphnqsfdv7gdp24bykdfs6s")))) + (build-system gnu-build-system) + (inputs `(("readline" ,readline))) + (synopsis "Go game") + (description "GNU Go is a program that plays the game of Go, in which +players place stones on a grid to form territory or capture other stones. +While it can be played directly from the terminal, rendered in ASCII +characters, it is also possible to play GNU Go with 3rd party graphical +interfaces or even in Emacs. It supports the standard game storage format +(SGF, Smart Game Format) and inter-process communication format (GMP, Go +Modem Protocol).") + (home-page "http://www.gnu.org/software/gnugo/") + (license license:gpl3+))) -- 1.9.1 --=-GUqAVBt/mMZhYAucnUoZ--