all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [PATCH] gnu: Add some more gstreamer plugins
@ 2014-11-18 20:31 John Darrington
  2014-11-18 22:06 ` Ludovic Courtès
  0 siblings, 1 reply; 2+ messages in thread
From: John Darrington @ 2014-11-18 20:31 UTC (permalink / raw)
  To: guix-devel; +Cc: John Darrington

* gnu/packages/gstreamer.scm (gst-plugins-good): New variable.
* gnu/packages/gstreamer.scm (gst-plugins-base): New inputs.
---
 gnu/packages/gstreamer.scm |   57 +++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 56 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/gstreamer.scm b/gnu/packages/gstreamer.scm
index a7ad2c7..27dbafe 100644
--- a/gnu/packages/gstreamer.scm
+++ b/gnu/packages/gstreamer.scm
@@ -23,9 +23,14 @@
   #:use-module (guix build-system gnu)
   #:use-module (gnu packages)
   #:use-module (gnu packages bison)
+  #:use-module (gnu packages compression)
   #:use-module (gnu packages flex)
   #:use-module (gnu packages glib)
+  #:use-module (gnu packages gtk)
+  #:use-module (gnu packages linux)
   #:use-module (gnu packages perl)
+  #:use-module (gnu packages xorg)
+  #:use-module (gnu packages xiph)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages python)
   #:use-module (gnu packages xml))
@@ -95,6 +100,7 @@ This package provides the core library and elements.")
        ("glib" ,glib "bin")
        ("python" ,python-2)))))
 
+
 (define-public gst-plugins-base
   (package
     (name "gst-plugins-base")
@@ -108,9 +114,17 @@ This package provides the core library and elements.")
        (base32
         "1s4pphbb5kpdh4rrmb8rala4sp499k4by59925k15xiz58xyhm4p"))))
     (build-system gnu-build-system)
-    ;; FIXME: Add more dependencies for further plugins.
     (inputs
      `(("glib" ,glib)
+       ("pango" ,pango)
+       ("libogg" ,libogg)
+       ("libtheora" ,libtheora)
+       ("libvorbis" ,libvorbis)
+       ("libx11" ,libx11)
+       ("zlib" ,zlib)
+       ("libXext" ,libxext)
+       ("libxv" ,libxv)
+       ("alsa-lib" ,alsa-lib)
        ("gstreamer" ,gstreamer)))
     (native-inputs
       `(("pkg-config" ,pkg-config)
@@ -141,6 +155,47 @@ simple plugin with a clean, generic interface.
 This package provides an essential exemplary set of elements.")
     (license lgpl2.0+)))
 
+
+(define-public gst-plugins-good
+  (package
+    (name "gst-plugins-good")
+    (version "1.0.10")
+    (source
+     (origin
+      (method url-fetch)
+      (uri (string-append "http://gstreamer.freedesktop.org/src/gst-plugins-good/gst-plugins-good-"
+                          version ".tar.xz"))
+      (sha256
+       (base32
+        "1bi8ci0jssi8bsa7wbmqcwphl579vvxpshn2qnaggiha13b440y6"))))
+    (build-system gnu-build-system)
+    (inputs
+     `(("glib" ,glib)
+       ("gstreamer" ,gstreamer)))
+    (native-inputs
+      `(("pkg-config" ,pkg-config)
+        ("glib" ,glib "bin")
+        ("gst-plugins-base" ,gst-plugins-base)
+        ("python-wrapper" ,python-wrapper)))
+    (arguments
+     `(#:tests? #f))
+    (home-page "http://gstreamer.freedesktop.org/")
+    (synopsis
+     "Plugins for the gstreamer multimedia library")
+    (description
+     "GStreamer is a library for constructing graphs of media-handling
+components.  The applications it supports range from simple Ogg/Vorbis
+playback, audio/video streaming to complex audio (mixing) and video
+(non-linear editing) processing.
+
+Applications can take advantage of advances in codec and filter technology
+transparently.  Developers can add new codecs and filters by writing a
+simple plugin with a clean, generic interface.
+
+GStreamer Good Plug-ins is a set of plug-ins that the developers consider to
+have good quality code and correct functionality")
+    (license lgpl2.0+)))
+
 (define-public gst-plugins-base-0.10
   (package (inherit gst-plugins-base)
     (version "0.10.36")
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] gnu: Add some more gstreamer plugins
  2014-11-18 20:31 [PATCH] gnu: Add some more gstreamer plugins John Darrington
@ 2014-11-18 22:06 ` Ludovic Courtès
  0 siblings, 0 replies; 2+ messages in thread
From: Ludovic Courtès @ 2014-11-18 22:06 UTC (permalink / raw)
  To: John Darrington; +Cc: guix-devel

John Darrington <jmd@gnu.org> skribis:

> * gnu/packages/gstreamer.scm (gst-plugins-good): New variable.
> * gnu/packages/gstreamer.scm (gst-plugins-base): New inputs.

Please don’t repeat the file name, and list the newly-added dependencies.

> +    (synopsis
> +     "Plugins for the gstreamer multimedia library")

s/gstreamer/GStreamer/

> +    (description
> +     "GStreamer is a library for constructing graphs of media-handling
> +components.  The applications it supports range from simple Ogg/Vorbis
> +playback, audio/video streaming to complex audio (mixing) and video
> +(non-linear editing) processing.
> +
> +Applications can take advantage of advances in codec and filter technology
> +transparently.  Developers can add new codecs and filters by writing a
> +simple plugin with a clean, generic interface.
> +
> +GStreamer Good Plug-ins is a set of plug-ins that the developers consider to
> +have good quality code and correct functionality")
> +    (license lgpl2.0+)))

Please remove the first two paragraphs, and add a sentence saying that
this package provides plug-ins.

OK to push with these changes, thank you!

Ludo’.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-11-18 22:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-18 20:31 [PATCH] gnu: Add some more gstreamer plugins John Darrington
2014-11-18 22:06 ` Ludovic Courtès

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.