From: Maxime Devos <maximedevos@telenet.be>
To: Adam Faiz <adam.faiz@disroot.org>, 57625@debbugs.gnu.org
Subject: [bug#57625] [PATCH 1/3] gnu: Add libgc-private-headers-for-pnet.
Date: Tue, 6 Sep 2022 18:55:56 +0200 [thread overview]
Message-ID: <13dfa7fa-a27f-f68d-43ba-4be55e14ba16@telenet.be> (raw)
In-Reply-To: <620a920f-c95a-ada1-714c-dc39fc95c5a9@disroot.org>
[-- Attachment #1.1.1: Type: text/plain, Size: 2728 bytes --]
On 06-09-2022 17:34, Adam Faiz via Guix-patches via wrote:
> +(define-public libgc-private-headers-for-pnet
> + (hidden-package
> + (package
> + (name "libgc-private-headers")
> + (version (package-version libgc))
> + (source (origin
> + (method url-fetch)
> + (uri (string-append
> "https://github.com/ivmai/bdwgc/releases"
> + "/download/v" version "/gc-"
> version ".tar.gz"))
> + (sha256
> + (base32
> + "1798rp3mcfkgs38ynkbg2p47bq59pisrc6mn0l20pb5iczf0ssj3"))))
Try (source (package-source libgc)) instead. That way, the hash and URL
remains correct even if libgc is updated.
'(("include/config.h.in" "include/private/config.h")
I'd think you need to install include/config.h instead (*).
+ (license (x11-style (string-append home-page "license.txt"))))))
(license (package-license libgc)), in case the license of libgc ever
changes.
(*) Untested proposal:
(define-public libgc-all-headers ; TODO(core-updates) merge into libgc
(package
(inherit libgc)
(name "libgc-all-headers")
(outputs "out")
(arguments
(append (package-arguments libgc)
(list #:imported-modules
'((guix build gnu-build-system) (guix build
copy-build-system))
#:phases
#~(modify-phases
(add-after 'install 'delete-library
(lambda _
(delete-file-recursively (string-append
#$output "/lib"))))
(add-after 'install 'delete-private-header
(lambda _
(delete-file-recursively (string-append
#$output "/lib"))))
(add-after 'install 'install-private
(lambda arguments
((@ (guix build copy-build-system) install)
(append (list #:install-plan
'(("include/config.h" [...]) [...]))
arguments))))))))
(synopsis ...)
(description ...)))
Also, why a hidden package?
Greetings,
Maxime.
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 929 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
next prev parent reply other threads:[~2022-09-06 16:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-06 8:48 [bug#57625] [PATCH 0/3] WIP: Add pnet Adam Faiz via Guix-patches via
2022-09-06 15:34 ` [bug#57625] [PATCH 1/3] gnu: Add libgc-private-headers-for-pnet Adam Faiz via Guix-patches via
2022-09-06 16:55 ` Maxime Devos [this message]
2022-09-07 2:48 ` Adam Faiz via Guix-patches via
2022-09-06 15:39 ` [bug#57625] [PATCH 2/3] gnu: Add treecc Adam Faiz via Guix-patches via
2022-09-06 18:07 ` Maxime Devos
2022-09-06 15:53 ` [bug#57625] WIP: gnu: Add pnet Adam Faiz via Guix-patches via
2022-09-06 17:23 ` Maxime Devos
2022-11-18 9:15 ` [bug#57625] [PATCH v1 01/03] gnu: Add libgc-all-headers Adam Faiz via Guix-patches via
2022-11-18 9:20 ` [bug#57625] [PATCH v1 02/03] gnu: Add treecc Adam Faiz via Guix-patches via
2022-11-18 9:28 ` [bug#57625] [PATCH v1 03/03] WIP : gnu: Add pnet Adam Faiz via Guix-patches via
2022-11-19 10:33 ` [bug#57625] [PATCH v2 1/3] gnu: Add libgc-all-headers Adam Faiz via Guix-patches via
2022-11-19 10:35 ` [bug#57625] [PATCH v2 2/3] gnu: Add treecc Adam Faiz via Guix-patches via
2022-11-19 10:37 ` [bug#57625] [PATCH v2 3/3] gnu: Add pnet Adam Faiz via Guix-patches via
2023-06-26 13:17 ` [bug#57625] [PATCH v3 1/4] gnu: Add libgc-all-headers Adam Faiz via Guix-patches via
2023-06-26 13:20 ` [bug#57625] [PATCH v3 2/4] gnu: Add treecc Adam Faiz via Guix-patches via
2023-06-26 13:23 ` [bug#57625] [PATCH v3 3/4] gnu: Add pnet Adam Faiz via Guix-patches via
2023-06-26 13:25 ` [bug#57625] [PATCH v3 4/4] gnu: Add pnetlib Adam Faiz via Guix-patches via
2023-06-26 23:38 ` Adam Faiz via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13dfa7fa-a27f-f68d-43ba-4be55e14ba16@telenet.be \
--to=maximedevos@telenet.be \
--cc=57625@debbugs.gnu.org \
--cc=adam.faiz@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.