From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id eGpIL8Q90mTfTAAASxT56A (envelope-from ) for ; Tue, 08 Aug 2023 15:06:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id yGNGLsQ90mSBgQEAG6o9tA (envelope-from ) for ; Tue, 08 Aug 2023 15:06:12 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4907C46FC1 for ; Tue, 8 Aug 2023 15:06:12 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1691499972; a=rsa-sha256; cv=none; b=AEWghtDQT4PsBz19+4wdFX13Pw4Jyv5T/bGIHxqfYSJyqMsq1iV+7hGTdsGiPjKJckt12i qgtp6Bu1LS1tZ83lEw/FQwxE+htniJT2m4ZrluMu9ozPQLM9HJ8jqS8DO+OPd7DV/6W4vU lc8igQxAHmFhcWPK9U6Z7u6AgYBvrXrXD8lUi/Clbne7rx0nbRVN1xAFhkSl+8tJ6FPPwy NbRUum5pVgDCDM/otY3FHDzwjFGLd1enXEWEU4S89ZTUfdLP5YqyrQg3aJNCbNDeiHzFKX PF1OU/aKc0+WEJ8shVVmRFFf5QhVurTICgJVFhtQdUsCP9wOnYnzN9zcs82e+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1691499972; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=u6m0azQ/NQIEsKkM6CyiX+VftXYGWWreqSO2M+ZBkpg=; b=m5COXhOLInq5BaZKZSDI6yKCafN9CI7WS9TpeyUJ8KBajvsqxYEmm144dvROuOXjihPf8R Nbd/Q4y37rryWsrhiDH3Qc5sRsiQiwmdWNMj27zBYasRYxcDMJNPo4hssVWClu4Ac3k6DG udS/TZfxVFaffYm1E9EH9PPc376uTLPQXD6n2rFzDlFAVtywv5Li4vdt/T+y25hQHfYPJd KStToh1ykmDw8h7NyIdoBgjPEHWm76FcXr2ztOeIFUWlw7hr8I8WYRTcl+7Fg3VRTKrD41 GoEAjbcwx6i9mEH0cgDKNt+5U+U9KCDOt2E6mSWjTRzo39v7gt87fPshzTkSqw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qTMPJ-0005h7-UC; Tue, 08 Aug 2023 09:05:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qTLpl-0004j5-Vf for guix-patches@gnu.org; Tue, 08 Aug 2023 08:29:14 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qTLpf-00015y-6f for guix-patches@gnu.org; Tue, 08 Aug 2023 08:29:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qTLpf-0004Od-2g for guix-patches@gnu.org; Tue, 08 Aug 2023 08:29:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#64504] [PATCH] gnu: Add unsio. Resent-From: Iliya Tikhonenko Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 08 Aug 2023 12:29:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64504 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Andreas Enge Cc: 64504@debbugs.gnu.org, Sharlatan Hellseher , Efraim Flashner , Eric Bavier Received: via spool by 64504-submit@debbugs.gnu.org id=B64504.169149769116793 (code B ref 64504); Tue, 08 Aug 2023 12:29:03 +0000 Received: (at 64504) by debbugs.gnu.org; 8 Aug 2023 12:28:11 +0000 Received: from localhost ([127.0.0.1]:35435 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qTLon-0004Mi-QD for submit@debbugs.gnu.org; Tue, 08 Aug 2023 08:28:10 -0400 Received: from mpemail.mpe.mpg.de ([130.183.137.111]:46952 helo=mail.mpe.mpg.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qTL1E-0002mV-BN for 64504@debbugs.gnu.org; Tue, 08 Aug 2023 07:36:57 -0400 Received: from [89.246.96.67] (helo=[192.168.68.186]) by mail.mpe.mpg.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qTL15-0003Nh-7h; Tue, 08 Aug 2023 13:36:47 +0200 Message-ID: <138b0fbd-ca5b-17ac-9c18-4d657737d4c0@mpe.mpg.de> Date: Tue, 8 Aug 2023 13:37:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-US, ru References: <521af611d0794672c19a4899e42eb5e448ab1c1f.1688681498.git.sharlatanus@gmail.com> From: Iliya Tikhonenko In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated-Id: tikhonenko X-Mailman-Approved-At: Tue, 08 Aug 2023 08:28:08 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Mailman-Approved-At: Tue, 08 Aug 2023 09:05:50 -0400 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -6.30 X-Migadu-Scanner: mx2.migadu.com X-Migadu-Queue-Id: 4907C46FC1 X-Spam-Score: -6.30 X-TUID: b2mtbANLbjWH Hello! I am the author of the initial version of this patch (kudos to Sharlatan for cleaning it up and bringing to guix proper!) On 8/8/23 11:29, Andreas Enge wrote: > For the #:build-type, the default value (release with debug information) also works and results in a package of the same size. Is there a reason to change it? Modified patch attached. The debug build type is unnecessary verbose (see src/uns.cc line 71-73 for an example) to the point that it impacts performance sometimes, which is important considering the usecase of the library. > I can also compile the package without the configure flags, are they useful? Checked again, I still cannot compile it without -DCMAKE_CXX_STANDARD=14 > And there are lots of warnings about 34 bit shifts in a 32 bit type. > But I suppose you tested that the library works. I have not noticed any issues using it during the past two years, but this cannot be considered a proper test because I am actually using a small subset of the library. Perhaps, this warning should be reported upstream, thanks! All the best, Iliya