all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Iliya Tikhonenko <tikhonenko@mpe.mpg.de>
To: Andreas Enge <andreas@enge.fr>
Cc: 64504@debbugs.gnu.org,
	Sharlatan Hellseher <sharlatanus@gmail.com>,
	Efraim Flashner <efraim@flashner.co.il>,
	Eric Bavier <bavier@posteo.net>
Subject: [bug#64504] [PATCH] gnu: Add unsio.
Date: Tue, 8 Aug 2023 13:37:14 +0200	[thread overview]
Message-ID: <138b0fbd-ca5b-17ac-9c18-4d657737d4c0@mpe.mpg.de> (raw)
In-Reply-To: <ZNIK_kKc2ud4iJpQ@jurong>

Hello!

I am the author of the initial version of this patch (kudos to Sharlatan 
for cleaning it up and bringing to guix proper!)

On 8/8/23 11:29, Andreas Enge wrote:
> For the #:build-type, the default value (release with debug information) also works and results in a package of the same size. Is there a reason to change it? Modified patch attached.
The debug build type is unnecessary verbose (see src/uns.cc line 71-73 
for an example) to the point that it impacts performance sometimes, 
which is important considering the usecase of the library.

> I can also compile the package without the configure flags, are they useful?
Checked again, I still cannot compile it without -DCMAKE_CXX_STANDARD=14


> And there are lots of warnings about 34 bit shifts in a 32 bit type.
> But I suppose you tested that the library works.
I have not noticed any issues using it during the past two years, but 
this cannot be considered a proper test because I am actually using a 
small subset of the library. Perhaps, this warning should be reported 
upstream, thanks!


All the best,
Iliya




  reply	other threads:[~2023-08-08 13:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-06 22:13 [bug#64504] [PATCH] gnu: Add unsio Sharlatan Hellseher
2023-08-08  9:29 ` Andreas Enge
2023-08-08 11:37   ` Iliya Tikhonenko [this message]
2023-08-08 15:49     ` Andreas Enge
2023-08-14 12:41       ` Iliya Tikhonenko
2023-08-17 18:10         ` bug#64504: " Andreas Enge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=138b0fbd-ca5b-17ac-9c18-4d657737d4c0@mpe.mpg.de \
    --to=tikhonenko@mpe.mpg.de \
    --cc=64504@debbugs.gnu.org \
    --cc=andreas@enge.fr \
    --cc=bavier@posteo.net \
    --cc=efraim@flashner.co.il \
    --cc=sharlatanus@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.