From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id oMKFEjxqQmVcagEAauVa8A:P1 (envelope-from ) for ; Wed, 01 Nov 2023 16:09:48 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id oMKFEjxqQmVcagEAauVa8A (envelope-from ) for ; Wed, 01 Nov 2023 16:09:48 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D36E56718C for ; Wed, 1 Nov 2023 16:09:47 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=none ("invalid DKIM record") header.d=chillpc.fr header.s=mail header.b="ckjIU/J8"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=chillpc.fr (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1698851388; a=rsa-sha256; cv=none; b=c675Itdc7IbHYpYHEPPt9ydTWTU9Ilt/ktczop3/zjaaIyM5s08OwQo1/G1Nhb2PDaKSK9 YXJl0SlSiMuPZdhqOfWV46YbUDtr7FJD7DwJS501t5bN3BE3+lroOTO4Z9yyA/PaoCUeSu NnyxW0vtgCTUH3a1Z+fTXvg5wXR7YVuCqoyXrMFmtm0L2XPvF1RWEVAsmlYLuKLR83UjVF GNaHEwbe8mzBckGleJyYuCx/KbU6u1oR5IUlEufhj+ax0TTvQTFOpCmyM61FxxpYOCIhbF Cas9pcpnNwXN71dxzuoK36SVU2pFjBQyzXJ28TQtDR7RcGYLieyQnNPwcaaqXA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none ("invalid DKIM record") header.d=chillpc.fr header.s=mail header.b="ckjIU/J8"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=chillpc.fr (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1698851388; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=lFOO7jryK72Y4bgWjBEZGu+eA5GPRKJg9ZruPZjivJs=; b=iB9QQq3hIdhJkVPVKHjhK+QBBnFL3wtZFwn3gPtBWXT/dxtqfxenDHMXO1BkdhBL7TJ0Xy fXUP3ooc6bCL6dXz7jZtwEuu6jXH9itSI6pH00fO5CEHTHl2eaNiD4y3EgFS9RE6ew1fxC MvVu64JeGz5TCM/GvL1L0BquraUewqBYo7eJsXp/iCz2jGsoad1mfB36NprOjp6GTLg0iA 2ZnJOVBH6yyyV9nSqHln8chTVSl3amx3I5iK5qp8+JMAI7DfuKSKYaJEUSSOaRWqoT0CcA +iIKe2S6gwVq68sx/9O1FRxzKs1AV22ri/aG0yKALQ36Pt5h99PuUyQOLCU8AA== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qyCqY-0004um-GA; Wed, 01 Nov 2023 11:09:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qyCqW-0004uM-41 for guix-patches@gnu.org; Wed, 01 Nov 2023 11:09:28 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qyCqV-00006x-Sq for guix-patches@gnu.org; Wed, 01 Nov 2023 11:09:27 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qyCr4-0005zW-8T for guix-patches@gnu.org; Wed, 01 Nov 2023 11:10:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#65662] [PATCH] gnu: Add antifennel. Resent-From: =?UTF-8?Q?R=C3=A9mi?= Teissier Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 01 Nov 2023 15:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65662 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Mathieu Othacehe Cc: 65662@debbugs.gnu.org Received: via spool by 65662-submit@debbugs.gnu.org id=B65662.169885138922999 (code B ref 65662); Wed, 01 Nov 2023 15:10:02 +0000 Received: (at 65662) by debbugs.gnu.org; 1 Nov 2023 15:09:49 +0000 Received: from localhost ([127.0.0.1]:52194 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qyCqr-0005ys-3K for submit@debbugs.gnu.org; Wed, 01 Nov 2023 11:09:49 -0400 Received: from vps-1eeb809a.vps.ovh.net ([217.182.171.220]:40632 helo=mail.chillpc.fr) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qyCqn-0005yh-Jz for 65662@debbugs.gnu.org; Wed, 01 Nov 2023 11:09:47 -0400 Received: from [192.168.1.160] (91-164-64-51.subs.proxad.net [91.164.64.51]) by mail.chillpc.fr (Postfix) with ESMTPSA id C144F20018; Wed, 1 Nov 2023 15:09:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=chillpc.fr; s=mail; t=1698851349; bh=0snGWiPmj4KaR8lXJDDbxp+u43WTm/lYP1ZwL54tRiw=; h=Date:Subject:To:References:From:Cc:In-Reply-To:From; b=ckjIU/J8ydnBHUiWKdj0tvZqKhh9bCS5U0IAdLNeoSh1+CGnuLiL3s+qzzWLRlLq8 M4fwILvOvZNJZm7h/wQmSC6TLLYbdsj/pPs01W0IKAxwsKj+GEhNi/lt7OGEfoOJr3 q6GCsU1pFrOViDghtX7msVf9yHq9YDgNKYHPV+caZEs5krNCd/lREDGiIVokoMEQmU 7zQv/ctb9jywV/bv0WFAUawhTXTWF/rKshxjru1EDESHpgF7LHfoSoUxKFAQilquAg prHsIFpCyGnBYOvGCtW0Q0XajryMkRpIC/vlmLsbSGwnnYGiIMvnYwqC3oHsyDXK5d oGY4LiX87KkZw== Content-Type: multipart/alternative; boundary="------------VPbnQ404bRwFnruwDjnPK0f0" Message-ID: <12c35236-1f37-41ad-b17a-b5e5d6ceb9e0@chillpc.fr> Date: Wed, 1 Nov 2023 16:09:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: fr, en-US References: <87jzr9k01a.fsf@gnu.org> From: =?UTF-8?Q?R=C3=A9mi?= Teissier In-Reply-To: <87jzr9k01a.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: D36E56718C X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -4.50 X-Spam-Score: -4.50 X-TUID: VkVZhoc6rC1A This is a multi-part message in MIME format. --------------VPbnQ404bRwFnruwDjnPK0f0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hello ! Sorry for the delay (too). Writing guix packages and the git email flow is pretty new to me ^^' I did my best to fix my patch. >> +              (file-name (git-file-name name version)))) >> +    (build-system gnu-build-system) >> +    (inputs (list lua luajit)) >> +    (arguments >> +     '(#:phases (modify-phases %standard-phases >> +                  (delete 'configure) >> +                  (delete 'check) > Are tests disabled because there are no tests or because there are not > passing. If we are in the first case you can specify it with a simple > comment such as ;no tests. Tests are pretty messy in this project, they work on the `main` branch but not in the `2.0.0`. I don't really know what to add about it in comment. >> +                  (replace 'install >> +                    (lambda* (#:key outputs #:allow-other-keys) >> +                      (let ((bin (string-append (assoc-ref outputs "out") >> +                                                "/bin"))) > The preferred way now is to use gexp, meaning that you can directly > write: > > (install-file "antifennel" #$output) Let me know if I did it right, I tried to adapt grepped example in the project. I kinda rushed it at my first try. I hope it is good enough now :) Rémi Teissier Le 26/10/2023 à 15:04, Mathieu Othacehe a écrit : > Hello, > > Sorry for the delay! > >> From c546257438e4e824ddf54351b77a754d2f466567 Mon Sep 17 00:00:00 2001 >> From: =?UTF-8?q?R=C3=A9mi=20Teissier?= >> Date: Thu, 31 Aug 2023 15:17:28 +0200 >> Subject: [PATCH] gnu: Add antifennel. >> > You are missing a commit message here. It should look like: > > * gnu/packages/lua.scm (antifennel): New package. > >> +               (base32 >> + "1hd9h17q31b3gg88c657zq4han4air2ag55rrakbmcpy6n8acsqc")) > The indentation seems off here. > >> +              (file-name (git-file-name name version)))) >> +    (build-system gnu-build-system) >> +    (inputs (list lua luajit)) >> +    (arguments >> +     '(#:phases (modify-phases %standard-phases >> +                  (delete 'configure) >> +                  (delete 'check) > Are tests disabled because there are no tests or because there are not > passing. If we are in the first case you can specify it with a simple > comment such as ;no tests. > >> +                  (replace 'install >> +                    (lambda* (#:key outputs #:allow-other-keys) >> +                      (let ((bin (string-append (assoc-ref outputs "out") >> +                                                "/bin"))) > The preferred way now is to use gexp, meaning that you can directly > write: > > (install-file "antifennel" #$output) > >> +    (home-page"https://git.sr.ht/~technomancy/antifennel") >> +    (synopsis "Turn Lua code into Fennel code") >> +    (description >> +     "Turn Lua code into Fennel code. This compiler does the opposite >> +     of what the Fennel compiler does.") > It would be nice to expand a bit the description and use sentences, such > as: This package provides a way to turn Lua code into Fennel code by... > >> +    (license (list license:expat)))) > You don't need a list if there is just one license :) > > Could you please send an updated patch? > > Don't hesitate if you need some guidance! > > Mathieu --------------VPbnQ404bRwFnruwDjnPK0f0 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit Hello !
Sorry for the delay (too). Writing guix packages and the git email flow is pretty new to me ^^'

I did my best to fix my patch. 
+              (file-name (git-file-name name version))))
+    (build-system gnu-build-system)
+    (inputs (list lua luajit))
+    (arguments
+     '(#:phases (modify-phases %standard-phases
+                  (delete 'configure)
+                  (delete 'check)

Are tests disabled because there are no tests or because there are not
passing. If we are in the first case you can specify it with a simple
comment such as ;no tests.


    Tests are pretty messy in this project, they work on the `main`
    branch but not in the `2.0.0`. I don't really know what to add about
    it in comment.

    

    

      

        
+                  (replace 'install
+                    (lambda* (#:key outputs #:allow-other-keys)
+                      (let ((bin (string-append (assoc-ref outputs "out")
+                                                "/bin")))


      

      
The preferred way now is to use gexp, meaning that you can directly
write:

(install-file "antifennel" #$output)

    

    Let me know if I did it right, I tried to adapt grepped example in
    the project.

    

    I kinda rushed it at my first try. I hope it is good enough now :)

    

    Rémi Teissier

    

    
Le 26/10/2023 à 15:04, Mathieu Othacehe
      a écrit :

    

    

      
Hello,

Sorry for the delay!



      

        
 From c546257438e4e824ddf54351b77a754d2f466567 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?R=C3=A9mi=20Teissier?= <rteissier.code@chillpc.fr>
Date: Thu, 31 Aug 2023 15:17:28 +0200
Subject: [PATCH] gnu: Add antifennel.



      

      
You are missing a commit message here. It should look like:

* gnu/packages/lua.scm (antifennel): New package.



      

        
+               (base32
+ "1hd9h17q31b3gg88c657zq4han4air2ag55rrakbmcpy6n8acsqc"))


      

      
The indentation seems off here.



      

        
+              (file-name (git-file-name name version))))
+    (build-system gnu-build-system)
+    (inputs (list lua luajit))
+    (arguments
+     '(#:phases (modify-phases %standard-phases
+                  (delete 'configure)
+                  (delete 'check)


      

      
Are tests disabled because there are no tests or because there are not
passing. If we are in the first case you can specify it with a simple
comment such as ;no tests.



      

        
+                  (replace 'install
+                    (lambda* (#:key outputs #:allow-other-keys)
+                      (let ((bin (string-append (assoc-ref outputs "out")
+                                                "/bin")))


      

      
The preferred way now is to use gexp, meaning that you can directly
write:

(install-file "antifennel" #$output)



      

        
+    (home-page "https://git.sr.ht/~technomancy/antifennel")
+    (synopsis "Turn Lua code into Fennel code")
+    (description
+     "Turn Lua code into Fennel code. This compiler does the opposite
+     of what the Fennel compiler does.")


      

      
It would be nice to expand a bit the description and use sentences, such
as: This package provides a way to turn Lua code into Fennel code by...



      

        
+    (license (list license:expat))))


      

      
You don't need a list if there is just one license :)

Could you please send an updated patch?

Don't hesitate if you need some guidance!

Mathieu


    

    

    

  


--------------VPbnQ404bRwFnruwDjnPK0f0--