From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id EFJNLShUDGE6CQAAgWs5BA (envelope-from ) for ; Thu, 05 Aug 2021 23:12:08 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id sL6aKChUDGHgUwAAbx9fmQ (envelope-from ) for ; Thu, 05 Aug 2021 21:12:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BBD1BFA68 for ; Thu, 5 Aug 2021 23:12:07 +0200 (CEST) Received: from localhost ([::1]:58972 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mBkes-0006Du-QP for larch@yhetil.org; Thu, 05 Aug 2021 17:12:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40142) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mBkep-0006Dl-2n for guix-patches@gnu.org; Thu, 05 Aug 2021 17:12:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:37023) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mBkeo-0002Cl-PD for guix-patches@gnu.org; Thu, 05 Aug 2021 17:12:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mBkeo-0005Sm-FS for guix-patches@gnu.org; Thu, 05 Aug 2021 17:12:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49828] [PATCH 00/20] Add minetest mods Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 05 Aug 2021 21:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49828 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Andrew Ward , 49828@debbugs.gnu.org Received: via spool by 49828-submit@debbugs.gnu.org id=B49828.162819786220932 (code B ref 49828); Thu, 05 Aug 2021 21:12:02 +0000 Received: (at 49828) by debbugs.gnu.org; 5 Aug 2021 21:11:02 +0000 Received: from localhost ([127.0.0.1]:48569 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mBkdq-0005RO-B0 for submit@debbugs.gnu.org; Thu, 05 Aug 2021 17:11:02 -0400 Received: from laurent.telenet-ops.be ([195.130.137.89]:49128) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mBkdo-0005R8-CI for 49828@debbugs.gnu.org; Thu, 05 Aug 2021 17:11:01 -0400 Received: from ptr-bvsjgyjmffd7q9timvx.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:aaf1:9810:a0b8:a55d]) by laurent.telenet-ops.be with bizsmtp id dxAy250060mfAB401xAyNb; Thu, 05 Aug 2021 23:10:58 +0200 Message-ID: <12b8c0746b9db7d9e744ad350aa8e1b37e80ad2a.camel@telenet.be> From: Maxime Devos Date: Thu, 05 Aug 2021 23:10:45 +0200 In-Reply-To: <68444560-b887-4c0c-af36-7f8cc609eda9@email.android.com> References: <68444560-b887-4c0c-af36-7f8cc609eda9@email.android.com> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-ohLoO8tmPB6ugCsUObKc" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1628197858; bh=EF3rJn69ARl/lUyPbWFzQY67EG2MB9AljJzj7JVF72A=; h=Subject:From:To:Date:In-Reply-To:References; b=ndqZbd3jbB5YDAYjWPO+Yw6FsMDsLrJZA39lqCbtslO1LvxXYur4hjgouKmJth7PX p2ACMhJB4xQ0ywtEaW2NWoTmLesY9ZBPcD2trb43RU+GnJBwL8biSOakSyyLYeBJ2L vnatZpUHS3H26M3y3EDDULSgZ00Di6LD9ySwXqXwgNbGnm7ZKllr6Lstu5wVueIr47 j16T+E40kk7p3XWeRxDsRYbM+hDh4k6i3/aXBaqjOmiD22YnR91VuOh9FMUSDwReu4 FSuMV1PPNajeBvcxkzBmZkv/DeTbVU9f1fHAYDsi+bYDuHbQTmx6Bh25eui09sks3h KgGWSVTmT01mQ== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1628197927; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=EF3rJn69ARl/lUyPbWFzQY67EG2MB9AljJzj7JVF72A=; b=fq39RlMM+QY9Xo3QnXHmwX5c3jP6Pw3nGa9i+/nn31SRn1vWyqTrvhJCvPRJ6yBDu0pVSj ytuqQ3oDqKF6RLVSRltgKbNRz/EjvI93RXwpV3h9hpfmDoBkRWoNT5+94uCD583zfk1Wb9 oSHLLdCbn5tZzk7Dhg5COJD6cnqtmWj7t/ZQE5ecgQv/RiF4c/PbQicdm0s9RBuwJN1OkE PZbS8EKsEDT8bb69rF6aGG7nC+MlubDtP1Re0YRb1t85D6EfJN/t4aGvrsPSkeJpYEws2v gdgitYg8CNRIUME4B6r1QV1xcvcg6WICHDf1xIvNoJOx5NUkjG7/g7O25zCV3A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1628197927; a=rsa-sha256; cv=none; b=PszamlVQXr/25pDTJ7m0f/0QttVR4UQ+a1AGtW0e8LguuzhocFzKOGooFNrpcTz3lyqorw COB0tPpbUxoYBILxU5yqr+a1PndDFiz/ON6r5vkZN85pUUMebbmF5pVnDziD7YsVJ/5XjL 8UqNNTIlCauhVbWys16GvR8rOU57f/R1KaUXI9FcALaLyIaZPJWAbpGU81SqEZRfRc1OB6 jNw9nz72wFH/LoAMk+9mVL+jfJNZuCjhbgdTbyeY4hmiwdRDxfjHTbnV36ylNCsTqDNHH7 6g45NuuRrIsRXSBDUCPm71Yz7WenflnhZjDSgH8NywicCt8MyUS8bYyKAD04KA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=ndqZbd3j; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -3.42 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=ndqZbd3j; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: BBD1BFA68 X-Spam-Score: -3.42 X-Migadu-Scanner: scn0.migadu.com X-TUID: GfR5mQaibKy+ --=-ohLoO8tmPB6ugCsUObKc Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, Andrew Ward schreef op do 05-08-2021 om 13:46 [+0100]: > Hi, I'm a Minetest core dev and the creator of ContentDB (the service the= powers > the built-in mod/game/etc manager in Minetest). >=20 > It's very annoying when distros include mods but then never update them. > It causes confusion with users, as mods change over time and there can be= breakages. > So, I'd like to make sure that these packages are kept in sync with Conte= ntDB. When the mod is being =E2=80=98built=E2=80=99 in Guix, the 'check' phase wi= ll start Minetest with a new world where the mod and its dependencies are activated. It is v= erified there are no errors in the log. That should help with detecting breakage. It actually detected some breakage: ".mts" files were not being installed, = leading to errors at load time. This is fixed now. To keep in sync, there is "guix refresh minetest-MODA minetest-MODB ..." wh= ich can automatically upgrade packages to the latest version. It currently doe= sn't know about ContentDB however, so it has to fall-back to the generic updater= s which do not appear to work well with Minetest mods: gnu/packages/minetest.scm:345:13: 1.3 is already the latest version of mine= test-worldedit gnu/packages/minetest.scm:365:2: warning: no updater for minetest-unifieddy= es gnu/packages/minetest.scm:173:2: warning: no updater for minetest-mobs gnu/packages/minetest.scm:143:13: minetest-mesecons would be upgraded from = 1.2.1-0.db58797 to 2017.03.05 ^ this is actually a downgrade IIRC gnu/packages/minetest.scm:227:2: warning: no updater for minetest-pipeworks Hopefully that can be improved in the future (maybe keep the "release date"= in the 'properties' field of the Guix package and use that to determine if an = update is available?). > ContentDB also provides two other features: it only provides you with ver= sions of > mods/games that support your Minetest version. It also handles dependenci= es, so I > hope this is set up correctly. The ContentDB->guix importer handles dependencies. It reads the dependenci= es from ContentDB (with the /api/packages/AUTHOR/NAME/dependencies/ API) and adds the hard dependencies to 'propagated-inputs', so "minetest-mobs-animal= " has "minetest-mobs" in its 'propagated-inputs'. See also the 'check' phase mentioned above. > If you are disabling ContentDB completely, you should have the vast major= ity of mods, > games, and texture packs available - especially all the hard dependencies= needed, as > not having these will cause load issues. Minetest is all about customisat= ion. In the original patch series I sent, ContentDB was indeed disabled complete= ly when guix-installed mods are present. But with the revised patch (using the MIN= ETEST_MOD_PATH patch I submitted ), this = is no longer the case --- ContentDB and Guix can be used together. I tested installing mods with both Minetest's built-in installer and guix. = They can be used together. > I recommend adding a button and core.open_url call to the guix dialog tha= t replaces > the content store. It should link to a page describing how to install mod= s using guix, > and how to allow use of ContentDB again if the user desires ContentDB and mods installed with guix can be used together with the revise= d patches. It would be useful though to add some kind of dialog or something, telling = the user that mods can be installed with guix, and how to do so. > Anyway, sorry for being critical - it's great to see more distro support = and integration Greetings, Maxime (aka maximed aka emixa-d). --=-ohLoO8tmPB6ugCsUObKc Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYQxT1RccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7hH5AP0abbCPcvJAOeEqQE8r094M/CTB AGxqiqRcFjgawb1FPAEAxgjkosWm1zDCZ8tDT6YfodqUe9zrSmNo0jtY156Vugo= =dI9n -----END PGP SIGNATURE----- --=-ohLoO8tmPB6ugCsUObKc--