From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id YMGwCqt4o2HbBgAAgWs5BA (envelope-from ) for ; Sun, 28 Nov 2021 13:40:11 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id sJVeBqt4o2HKeAAAB5/wlQ (envelope-from ) for ; Sun, 28 Nov 2021 12:40:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C7E2B9C99 for ; Sun, 28 Nov 2021 13:40:10 +0100 (CET) Received: from localhost ([::1]:36386 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mrJTV-0007Zo-VO for larch@yhetil.org; Sun, 28 Nov 2021 07:40:10 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58504) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mrJTO-0007Zg-8z for guix-patches@gnu.org; Sun, 28 Nov 2021 07:40:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:51769) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mrJTN-0001EG-RL for guix-patches@gnu.org; Sun, 28 Nov 2021 07:40:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mrJTN-0001Vm-OA for guix-patches@gnu.org; Sun, 28 Nov 2021 07:40:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51534] [PATCH v4] gnu: Add smplayer v21.10.0. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 28 Nov 2021 12:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51534 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Attila Lendvai , 51534@debbugs.gnu.org Received: via spool by 51534-submit@debbugs.gnu.org id=B51534.16381031555752 (code B ref 51534); Sun, 28 Nov 2021 12:40:01 +0000 Received: (at 51534) by debbugs.gnu.org; 28 Nov 2021 12:39:15 +0000 Received: from localhost ([127.0.0.1]:35082 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mrJSd-0001Ui-0x for submit@debbugs.gnu.org; Sun, 28 Nov 2021 07:39:15 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:37729) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mrJSY-0001UO-TO for 51534@debbugs.gnu.org; Sun, 28 Nov 2021 07:39:13 -0500 Received: by mail-wm1-f68.google.com with SMTP id k37-20020a05600c1ca500b00330cb84834fso14565860wms.2 for <51534@debbugs.gnu.org>; Sun, 28 Nov 2021 04:39:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:date:in-reply-to:references:user-agent :mime-version:content-transfer-encoding; bh=c8GfOsZ5Qe0JuGn02zDJgm7XPk1NZULNFaF8oTY4ayU=; b=IVTZfTUqz9R9cSS+HmPu6a5ku1c9WEvITYDV6Z/wUjvvTv9XUXlifz8Aqb7v4f1Zym IjinJmhF8LcvqFOiMg40+d2J4apkPiaB5Kv/lWFcXXz4Sl3lQWPW+Zrr+ue7cyYLE/04 OOtntlNkanbYEphOH77UQ3ZtANKYrCt3CVhFfW1zSm9WsMGkDa6P8+gF5LWcOvoj4VLA NQsMaY5txnLMiowZajZ1lGq7njaWU6nxvqdgyo2Rz1wKSVByIRVgPzShAcExQQNqdF60 HBTgA6miY3daLFXOYUbtg6D1qyX9xkR4dWhYgcSvPlkCQrzpcDVr8RptfEAo4Ln+xhvs ex8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=c8GfOsZ5Qe0JuGn02zDJgm7XPk1NZULNFaF8oTY4ayU=; b=RF92e/2oDTRgqdA3w2qBD3hJR3523GUnTHCbSWkBbcoFMsA6yqtRTb2oVRYqH0gCwR BA6ste6CZ6UcgRWh5t1YU9LJ+vsQAuGFFxcXH54lphH7f4+nd3qs2RHPCyDkIWf6sxPe +RpZxmxJHONMRcJGtr6GdJ2MW3eK9P8l8djkcoA8jN5l5L3NocFI/ZGgEj0fwuhDKXN7 pnADk7Ci8yu0Zn1dndjd80NfAHl7i3ylIhqYGBSoqy4fghiJPrgdRvfZybgjd0HcO/vg sQxWHvrfHe2IInn9qhFgeGFRq8YjlNlFnOcRWjQbEuvFef1mvrG7zNvy4wXoZqjHY736 gYdA== X-Gm-Message-State: AOAM531kG0zyGJSHSkrsgGDePymGm7XvxzpYf7TXwKVkY4DB5941DA5x C+n6SDaq3LrdT3T8vYu63Ho= X-Google-Smtp-Source: ABdhPJyrBfuBLcoDGIRdZ0PkmkOFHyEs9mPzvPnCQFK3+EFjxhvgPRisjUjSna/0BYvVsIRhNP0ZDg== X-Received: by 2002:a7b:c008:: with SMTP id c8mr28418940wmb.87.1638103145034; Sun, 28 Nov 2021 04:39:05 -0800 (PST) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id n4sm12346419wri.41.2021.11.28.04.39.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Nov 2021 04:39:04 -0800 (PST) Message-ID: <12afd3fddf83742682611dd468827f64d1d1e5b7.camel@gmail.com> From: Liliana Marie Prikler Date: Sun, 28 Nov 2021 13:39:02 +0100 In-Reply-To: <20211128121204.3348-1-attila@lendvai.name> References: <20211128121204.3348-1-attila@lendvai.name> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1638103210; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=c8GfOsZ5Qe0JuGn02zDJgm7XPk1NZULNFaF8oTY4ayU=; b=UXCXk55C3VK2qlpi5SQJ2DWKfc8BHFZ1zHDX7zwI3Cv//kSY2MB7Ic5d7klY+2HUq7uQ44 voHgfQ2T53pKJMk3NZl2I3+zrg5MsczKO5lmH71qJ1P+ecEaNe/ZiIT+Kbdmi3EB1z32pu LeGOzy2NUfnUP65+olG3AYo+kIpeIOKLa1eLHjKphvivQxwouOPrTzgPu3nYFkmeeqJL4g N2h19aKpascUhXfZ2cvZtV2IOMc4fWsoHjSJsts5pzDfHbo2mrc+Eq7TvNQLP+k4uGjYxP c1ye63OtqMDLyzkuBpGHFbStmnUM9uBlkJsU9NrAlwiPnQNC5XSR5g/h7wwpAw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1638103210; a=rsa-sha256; cv=none; b=P2+onD02oqckiNEJxIP2slrnfMwcuUVRidyDmLp5siStpTHkCd/lXmaXfLEM9kplzLg2NH rO+EsF7s1hWRse9hUppt+KKnIEgYY7hvKhYbBQk3KeiimCoTVaO5vM7/kgUdro3tQBU0gg nf5zVYGo5idVBUPbDq707Xdw6QpG8nGMGj/GSMFnLbf1RYwlKWKyIx3/xqDcFElx7ThFHL 85VIf07R2NcSKRmzfxqjFmt0qRevVbf4/QI7FgvVH9pPDFkPYDgmGpJDE38f832GaGYWrF PQy9CdwJTK9WkHoFc9EuaCUZRWxnL/C3OyAnzGcFr1opu30v3Kna0Of6FPQLhA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=IVTZfTUq; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.81 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=IVTZfTUq; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: C7E2B9C99 X-Spam-Score: -1.81 X-Migadu-Scanner: scn1.migadu.com X-TUID: Q5IM7uShDXFJ Am Sonntag, den 28.11.2021, 13:12 +0100 schrieb Attila Lendvai: > * gnu/packages/video.scm (smplayer): New variable. > --- > > v4 adds bash-minimal to the inputs as per guix lint. sorry for the > miss! > > there's another lint warning that i can't fix: > > "smplayer@21.10.0: source not archived on Software Heritage and > missing from the Disarchive database" This one ought to disappear magically, as it's now queued for archival. > and forgot to mention that v3 switched to the qt-build-system. Don't worry too much about that; I'm the one who mentioned it first after all. > gnu/packages/video.scm | 60 > ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 60 insertions(+) > > diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm > index ff1abb308f..5cb645baac 100644 > --- a/gnu/packages/video.scm > +++ b/gnu/packages/video.scm > @@ -100,6 +100,7 @@ (define-module (gnu packages video) > #:use-module (gnu packages avahi) > #:use-module (gnu packages backup) > #:use-module (gnu packages base) > + #:use-module (gnu packages bash) > #:use-module (gnu packages bison) > #:use-module (gnu packages boost) > #:use-module (gnu packages cdrom) > @@ -2119,6 +2120,65 @@ (define-public mplayer > SVCD, DVD, 3ivx, DivX 3/4/5, WMV and H.264 movies.") > (license license:gpl2))) > > +(define-public smplayer > + (package > + (name "smplayer") > + (version "21.10.0") > + (source (origin > + (method url-fetch) > + (uri (string-append > + "mirror://sourceforge/smplayer/SMPlayer/" > version > + "/smplayer-" version ".tar.bz2")) > + (sha256 > + (base32 > + "12nvcl0cfix1xay9hfi7856vg4lpv8y5b0a22212bsjbvl5g22r > c")))) > + (build-system qt-build-system) > + (native-inputs > + `(("qttools" ,qttools))) > + (inputs > + `(("bash-minimal" ,bash-minimal) > + ("qtbase" ,qtbase-5) > + ("zlib" ,zlib) > + ("mpv" ,mpv))) > + (arguments > + `(#:tests? #false ; no tests > + #:make-flags (list (string-append "PREFIX=" (assoc-ref > %outputs "out")) > + (string-append "CC=" ,(cc-for-target)) > + ;; A KLUDGE to turn off invoking lrelease > on the > + ;; project for now, because it fails > consistently > + ;; with "WARNING: Could not find qmake > spec > + ;; 'default'". See below. > + "LRELEASE=true") > + #:phases > + (modify-phases %standard-phases > + (delete 'configure) > + ;; Due to the above, we must run lrelease separately on > each .ts file > + ;; (as opposed to running `lrelease-pro smplayer.pro` for > the entire > + ;; project, as the Makefile does normally without the above > kludge). > + (add-after 'build 'compile-ts-files > + (lambda _ > + (for-each (lambda (file) > + (invoke "lrelease" file)) > + (find-files "./" "\\.ts$")) > + #true)) > + (add-after 'install 'wrap-executable > + (lambda* (#:key inputs outputs #:allow-other-keys) > + (let* ((out (assoc-ref outputs "out")) > + (mpv (assoc-ref inputs "mpv"))) > + (wrap-program (string-append out "/bin/smplayer") > + `("PATH" ":" prefix > + ,(list (string-append mpv "/bin"))))) > + #true))))) Rather than patching PATH, you ought to rewrite the calls to exec or whatever is used to spawn mpv. > + (home-page "https://www.smplayer.info") > + (synopsis "Complete front-end for MPlayer, a media player") > + (description "SMPlayer is a graphical user interface (GUI) for > +MPlayer, which is capable of playing almost all known video and > audio > +formats. Apart from providing access for the most common and useful > +options of MPlayer, SMPlayer adds other interesting features like > the > +possibility to play Youtube videos, download subtitles, remember > +the last played position, etc.") > + (license license:gpl2+))) Description LGTM now, but perhaps you ought to move the program itself below mpv. Cheers