all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Maxime Devos <maximedevos@telenet.be>
To: Ricardo Wurmus <rekado@elephly.net>, 47972@debbugs.gnu.org
Subject: [bug#47972] [PATCH 1/6] gnu: Add boost-for-irods.
Date: Sat, 24 Apr 2021 13:02:11 +0200	[thread overview]
Message-ID: <115b5c8ccca573a6086d5cbc929619ef30335266.camel@telenet.be> (raw)
In-Reply-To: <20210423143201.12831-1-rekado@elephly.net>

[-- Attachment #1: Type: text/plain, Size: 3872 bytes --]

Ricardo Wurmus schreef op vr 23-04-2021 om 16:31 [+0200]:
> *+;; Sadly, this is needed for irods.  It won't link with 1.69 or later.
> +(define-public boost-for-irods
> +    [...]
> +    (native-inputs
> +     `(("clang" ,clang-6)

> +       ("libcxx" ,libcxx+libcxxabi-6)
> +       ("libcxxabi" ,libcxxabi-6)
"libcxx" and "libcxxabi" look lik they should be in "inputs", but perhaps something
special is going on here.

> +       ("perl" ,perl)
> +       ("tcsh" ,tcsh)))
> +    (arguments
> +     `(#:tests? #f
> +       #:make-flags
> +       (list "threading=multi" "link=shared"
> +             "cxxflags=-stdlib=libc++"
> +             "--without-python"
> +
> +             ;; Set the RUNPATH to $libdir so that the libs find each other.
> +             (string-append "linkflags=-stdlib=libc++ -Wl,-rpath="
> +                            (assoc-ref %outputs "out") "/lib"))
> +       #:phases
> +       (modify-phases %standard-phases
> +         (delete 'bootstrap)
> +         (add-after 'set-paths 'adjust-CPLUS_INCLUDE_PATH
> +           (lambda* (#:key inputs #:allow-other-keys)
> +             (let ((gcc (assoc-ref inputs  "gcc")))

For cross-compilation, this should be (assoc-ref (or native-inputs inputs) "gcc").

> +               (setenv "CPLUS_INCLUDE_PATH"

Maybe you need to set "CROSS_CPLUS_INCLUDE_PATH" here instead, not sure though.

> +                       (string-join
> +                        (cons (string-append (assoc-ref inputs "libcxx")
> +                                             "/include/c++/v1")
> +                              ;; Hide GCC's C++ headers so that they do not interfere with
> +                              ;; the Clang headers.
> +                              (delete (string-append gcc "/include/c++")
> +                                      (string-split (getenv "CPLUS_INCLUDE_PATH")
> +                                                    #\:)))
> +                        ":"))
> +               (format #true
> +                       "environment variable `CPLUS_INCLUDE_PATH' changed to ~a~%"
> +                       (getenv "CPLUS_INCLUDE_PATH")))))
> +         (replace 'configure
> +           (lambda* (#:key inputs outputs #:allow-other-keys)
> +             (let ((icu (assoc-ref inputs "icu4c"))
> +                   (zlib (assoc-ref inputs "zlib"))
> +                   (out (assoc-ref outputs "out")))
> +               (substitute* '("libs/config/configure"
> +                              "libs/spirit/classic/phoenix/test/runtest.sh"
> +                              "tools/build/src/engine/execunix.c"
> +                              "tools/build/src/engine/Jambase"
> +                              "tools/build/src/engine/jambase.c")
> +                 (("/bin/sh") (which "sh")))

When cross-compiling, "which" looks in the 'native-inputs', and not 'inputs'.
For tools/**/*.c, you should use (string-append (assoc-ref inputs "bash") "/bin/sh")
or something like that.  If/when <https://issues.guix.gnu.org/47869> is merged,
you can write the simpler (which "sh" inputs) instead, but that's not (yet) the case.

> +
> +               (setenv "SHELL" (which "sh"))
> +               (setenv "CONFIG_SHELL" (which "sh"))
> +
> +               (invoke "./bootstrap.sh"
> +                       (string-append "--prefix=" out)
> +                       ;; Auto-detection looks for ICU only in traditional
> +                       ;; install locations.
> +                       (string-append "--with-icu=" icu)
> +                       "--with-toolset=clang"))))
> +         (replace 'build
> +           (lambda* (#:key inputs make-flags #:allow-other-keys)
> +             (let ((zlib (assoc-ref inputs "zlib")))

The ((zlib (assoc-ref ...))) binding seems unused here.

Greetings,
Maxime.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

  parent reply	other threads:[~2021-04-24 11:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-23 14:20 [bug#47972] Add irods Ricardo Wurmus
2021-04-23 14:31 ` [bug#47972] [PATCH 1/6] gnu: Add boost-for-irods Ricardo Wurmus
2021-04-23 14:31   ` [bug#47972] [PATCH 2/6] gnu: Add snappy-with-clang6 Ricardo Wurmus
2021-04-23 14:31   ` [bug#47972] [PATCH 3/6] gnu: Add nanodbc-for-irods Ricardo Wurmus
2021-04-23 14:31   ` [bug#47972] [PATCH 4/6] gnu: Add fmt-for-irods Ricardo Wurmus
2021-04-23 14:32   ` [bug#47972] [PATCH 5/6] gnu: Add irods Ricardo Wurmus
2021-04-23 14:32   ` [bug#47972] [PATCH 6/6] gnu: Add irods-client-icommands Ricardo Wurmus
2021-04-24 11:02   ` Maxime Devos [this message]
2021-06-10  8:28   ` [bug#47972] Add irods Ludovic Courtès
2021-06-14 14:48     ` bug#47972: " Ricardo Wurmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=115b5c8ccca573a6086d5cbc929619ef30335266.camel@telenet.be \
    --to=maximedevos@telenet.be \
    --cc=47972@debbugs.gnu.org \
    --cc=rekado@elephly.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.