From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?G=C3=A1bor_Boskovits?= Subject: Java bootstrap cleanups Date: Tue, 11 Sep 2018 09:32:08 +0200 Message-ID: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000518fd80575937988" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:53665) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fzd9v-0003VM-Qy for guix-devel@gnu.org; Tue, 11 Sep 2018 03:32:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fzd9q-0002Uw-6j for guix-devel@gnu.org; Tue, 11 Sep 2018 03:32:27 -0400 Received: from mail-it0-x22f.google.com ([2607:f8b0:4001:c0b::22f]:38589) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fzd9q-0002Ue-0h for guix-devel@gnu.org; Tue, 11 Sep 2018 03:32:22 -0400 Received: by mail-it0-x22f.google.com with SMTP id p129-v6so237291ite.3 for ; Tue, 11 Sep 2018 00:32:21 -0700 (PDT) List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Guix-devel , Ricardo Wurmus , Julien Lepiller --000000000000518fd80575937988 Content-Type: text/plain; charset="UTF-8" Hello guix, I have a few questions/suggestions but I would like to get some feedback before implementing them. This changeset would rebuild all java, so it would be nice to get this right for the first time. 1. https://issues.guix.info/issue/30730 has a partial fix, icedtea-8 out output is fixed. The same fix could be attempted at icedtea-7, and then we could inherit it. Also we could get rid of the repeated code in ant-bootstrap and co. 'strip-jar-timestamps the same way Ricardo did this in icedtea-8. 2. ISTM that https://issues.guix.info/issue/31719 is caused by not running strip on the jre directory. I don't know how widespread this kind of issue is throughout the codebase. If it is, then we might need to come up with a more generic solution, but in the meanwhile I would simply add a 'strip-jre-directory phase, or something like that. I guess that should interact with #: strip-binaries though. 3. some javadoc reproducibility issues could be mitigated by tweaking ant build system to pass -notimestamp to javadoc. WDYT? --000000000000518fd80575937988 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello guix,

I have a few questions/suggestions but I would like to get some feed= back before implementing them. This changeset would rebuild all java, so it= would be nice to get this right for the first time.

1.=C2=A0https://issues.= guix.info/issue/30730 has a partial fix, icedtea-8 out output is fixed.= The same fix could be attempted at icedtea-7, and then we could inherit it= .
Also we could get rid of the repeated code in ant-bootstrap and= co. 'strip-jar-timestamps the same way Ricardo did this in icedtea-8.<= /div>
2. ISTM that=C2=A0https://issues.guix.info/issue/31719 is caused by not running strip o= n the jre directory. I don't know how widespread this kind of issue is = throughout the codebase. If it is, then we might need to come up with a mor= e generic solution, but in the meanwhile I would simply add a 'strip-jr= e-directory phase, or something like that. I guess that should interact wit= h #: strip-binaries though.
3. some javadoc reproducibility issue= s could be mitigated by tweaking ant build system to pass -notimestamp to j= avadoc.
WDYT?

--000000000000518fd80575937988-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Lepiller Subject: Re: Java bootstrap cleanups Date: Tue, 11 Sep 2018 10:40:53 +0200 Message-ID: <1153b43bb7378be9f5be4a674e0d864e@lepiller.eu> References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:42828) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fzeEF-0004y2-Ch for guix-devel@gnu.org; Tue, 11 Sep 2018 04:41:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fzeEC-0008OX-7O for guix-devel@gnu.org; Tue, 11 Sep 2018 04:40:59 -0400 Received: from lepiller.eu ([2a00:5884:8208::1]:44516) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fzeEB-0008L2-Ty for guix-devel@gnu.org; Tue, 11 Sep 2018 04:40:56 -0400 Received: from webmail.lepiller.eu (static-176-182-42-79.ncc.abo.bbox.fr [176.182.42.79]) by lepiller.eu (OpenSMTPD) with ESMTPSA id c0482378 (TLSv1.2:ECDHE-RSA-CHACHA20-POLY1305:256:NO) for ; Tue, 11 Sep 2018 08:42:01 +0000 (UTC) In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Guix-devel Le 2018-09-11 09:32, Gábor Boskovits a écrit : > Hello guix, > > I have a few questions/suggestions but I would like to get some > feedback before implementing them. This changeset would rebuild all > java, so it would be nice to get this right for the first time. > > 1. https://issues.guix.info/issue/30730 has a partial fix, icedtea-8 > out output is fixed. The same fix could be attempted at icedtea-7, and > then we could inherit it. > Also we could get rid of the repeated code in ant-bootstrap and co. > 'strip-jar-timestamps the same way Ricardo did this in icedtea-8. > 2. ISTM that https://issues.guix.info/issue/31719 is caused by not > running strip on the jre directory. I don't know how widespread this > kind of issue is throughout the codebase. If it is, then we might need > to come up with a more generic solution, but in the meanwhile I would > simply add a 'strip-jre-directory phase, or something like that. I > guess that should interact with #: strip-binaries though. > 3. some javadoc reproducibility issues could be mitigated by tweaking > ant build system to pass -notimestamp to javadoc. > WDYT? I'd say go for it if that can fix the reproducibility issues we have :) I don't expect 2. to be very widespread, but it happens elsewhere. That's because some packages install private shared libraries (that's weird, eh?). For instance, we have the same issue with ocaml-zarith: `lib/ocaml/site-lib/zarith/dllzarith.so` is not stripped. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: Java bootstrap cleanups Date: Tue, 11 Sep 2018 15:31:35 +0200 Message-ID: <87zhwojh3c.fsf@elephly.net> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47220) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fziqa-00019x-3Z for guix-devel@gnu.org; Tue, 11 Sep 2018 09:36:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fzilk-0004Oh-Sl for guix-devel@gnu.org; Tue, 11 Sep 2018 09:31:57 -0400 Received: from sender-of-o51.zoho.com ([135.84.80.216]:21003) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fzilk-0004Nj-Gr for guix-devel@gnu.org; Tue, 11 Sep 2018 09:31:52 -0400 In-reply-to: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: =?utf-8?Q?G=C3=A1bor?= Boskovits Cc: Guix-devel Hi G=C3=A1bor, > I have a few questions/suggestions but I would like to get some feedback > before implementing them. This changeset would rebuild all java, so it > would be nice to get this right for the first time. > > 1. https://issues.guix.info/issue/30730 has a partial fix, icedtea-8 out > output is fixed. The same fix could be attempted at icedtea-7, and then we > could inherit it. > Also we could get rid of the repeated code in ant-bootstrap and co. > 'strip-jar-timestamps the same way Ricardo did this in icedtea-8. Yes, this seems like a good idea. > 2. ISTM that https://issues.guix.info/issue/31719 is caused by not running > strip on the jre directory. I don't know how widespread this kind of issue > is throughout the codebase. If it is, then we might need to come up with a > more generic solution, but in the meanwhile I would simply add a > 'strip-jre-directory phase, or something like that. I guess that should > interact with #: strip-binaries though. Do you mean that the shared binaries that end up in the JRE directory are not stripped and that stripping them gets rid of all these references? (You could test this by copying the binaries from the store and stripping them manually.) The icedtea packages use the gnu-build-system, so I would expect them to be stripped by default. > 3. some javadoc reproducibility issues could be mitigated by tweaking ant > build system to pass -notimestamp to javadoc. > WDYT? Sounds good to me. Thanks for working on this, G=C3=A1bor! -- Ricardo