all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Felix Lechner via Bug reports for GNU Guix <bug-guix@gnu.org>
To: 69588@debbugs.gnu.org
Cc: Carlo Zancanaro <carlo@zancanaro.id.au>,
	William <willbilly@fedora.email>,
	Felix Lechner <felix.lechner@lease-up.com>
Subject: bug#69588: [PATCH] Find GRUB root devices for chainloading entries.
Date: Wed,  6 Mar 2024 16:09:20 -0800	[thread overview]
Message-ID: <1123579eb1c40f3ffadadb5599215280a8f8823e.1709770160.git.felix.lechner@lease-up.com> (raw)
In-Reply-To: <20240306181647.7af71dc3@fedora.email>

Maybe this would work? It should help grub-root-search to return a meaningful
search expression but may have unintended side effects.

This patch is untested.

More information may be available here:

  https://issues.guix.gnu.org/issue/69588

Change-Id: I7b97a141b0d0d462d8afdd8c69f0ceb9a2d2da0b
---
 gnu/bootloader/grub.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/bootloader/grub.scm b/gnu/bootloader/grub.scm
index 2723eda5f4..1a229675da 100644
--- a/gnu/bootloader/grub.scm
+++ b/gnu/bootloader/grub.scm
@@ -433,7 +433,7 @@ (define* (make-grub-configuration grub config entries
   chainloader ~a
 }~%"
                   #$label
-                  #$(grub-root-search device chain-loader)
+                  #$(grub-root-search device #f)
                   #$chain-loader)))))
 
   (define (crypto-devices)

base-commit: b4107ca3ad8bb8a6b8e669c298be2f14ff0237da
-- 
2.41.0





      reply	other threads:[~2024-03-07  0:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-06 17:16 bug#69588: (chain-loader) declaration will write invalid string on grub.cfg if "+1" is specified instead of an EFI file path William via Bug reports for GNU Guix
2024-03-07  0:09 ` Felix Lechner via Bug reports for GNU Guix [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1123579eb1c40f3ffadadb5599215280a8f8823e.1709770160.git.felix.lechner@lease-up.com \
    --to=bug-guix@gnu.org \
    --cc=69588@debbugs.gnu.org \
    --cc=carlo@zancanaro.id.au \
    --cc=felix.lechner@lease-up.com \
    --cc=willbilly@fedora.email \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.