From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 4fs3EAwDMGSgEgAASxT56A (envelope-from ) for ; Fri, 07 Apr 2023 13:48:28 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id wGxfDwwDMGTNbgEA9RJhRA (envelope-from ) for ; Fri, 07 Apr 2023 13:48:28 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B69A733605 for ; Fri, 7 Apr 2023 13:48:27 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pkkZZ-00062h-ND; Fri, 07 Apr 2023 07:48:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pkkZW-00062S-Jx for guix-patches@gnu.org; Fri, 07 Apr 2023 07:48:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pkkZW-0007q5-CB for guix-patches@gnu.org; Fri, 07 Apr 2023 07:48:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pkkZW-0004LI-0J for guix-patches@gnu.org; Fri, 07 Apr 2023 07:48:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#61982] [PATCH 2/2] home: services: xdg-base-directories: Deprecate XDG_LOG_HOME. Resent-From: Bruno Victal Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 07 Apr 2023 11:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61982 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Andrew Tropin Cc: philip@philipmcgrath.com, 61982@debbugs.gnu.org Received: via spool by 61982-submit@debbugs.gnu.org id=B61982.168086807116621 (code B ref 61982); Fri, 07 Apr 2023 11:48:01 +0000 Received: (at 61982) by debbugs.gnu.org; 7 Apr 2023 11:47:51 +0000 Received: from localhost ([127.0.0.1]:55862 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pkkZL-0004K0-0M for submit@debbugs.gnu.org; Fri, 07 Apr 2023 07:47:51 -0400 Received: from smtpm3.myservices.hosting ([185.26.105.234]:40436) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pkkZJ-0004Jj-R9 for 61982@debbugs.gnu.org; Fri, 07 Apr 2023 07:47:50 -0400 Received: from mail1.netim.hosting (unknown [185.26.106.173]) by smtpm3.myservices.hosting (Postfix) with ESMTP id 3FB2520F0A; Fri, 7 Apr 2023 13:47:48 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail1.netim.hosting (Postfix) with ESMTP id EAE36800A5; Fri, 7 Apr 2023 13:47:44 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mail1.netim.hosting Received: from mail1.netim.hosting ([127.0.0.1]) by localhost (mail1-2.netim.hosting [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id n4HXpKBoJEdt; Fri, 7 Apr 2023 13:47:44 +0200 (CEST) Received: from [192.168.1.239] (unknown [10.192.1.83]) (Authenticated sender: lumen@makinata.eu) by mail1.netim.hosting (Postfix) with ESMTPSA id 7FEC9800A4; Fri, 7 Apr 2023 13:47:44 +0200 (CEST) Message-ID: <10e30d4c-07f2-8bf9-24ed-7bbf820d12e8@makinata.eu> Date: Fri, 7 Apr 2023 12:47:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Content-Language: en-US References: <3005f8a58ec5afc447f2baf40958956bd0d16099.1678029530.git.mirai@makinata.eu> <0a0764da3fa04f9a02f37a7960a0c9608782854d.1678029530.git.mirai@makinata.eu> <87cz4gw06c.fsf@trop.in> From: Bruno Victal In-Reply-To: <87cz4gw06c.fsf@trop.in> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1680868108; a=rsa-sha256; cv=none; b=D71f7DHK5DXuywbg9Sg5n0Jf5Q2JKPDLakygppcToWEW5YT2WQhEjDgr0byWRpTfQ/Zo6P VlS5Zzm+egkdSQhyEwaH0P1R8VFaUtsPUEB9vmRIvq2NaRls2S9kDEqvUNvhr9dMm8fy1j TfGs2dMjPv+1Uw9wsfWNH3hot2O/4jofTr4rpSmdYOCBOzwwwmr6A+eb1Vy9VylRdTTWrw 1oSUQ/+a9pmxVRTbn2MrRAMd/mW2Fosff2Nfp8mLSrbXl2c7U4uqjWuG0Un1EbJvIP2Sjy oRJYAjcQzmGfzJ9ujXiKaQjoOwgLhZauWDnOyt7QEhLebQNwUwrPEgoMHe3huQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1680868108; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=BhcZ86AY4PGyWSeh7QzJgAni9sfumj3QJjgpY3mjptU=; b=KIFTqmgjbNsTcjlArSiU1wQ/2LZEOEn7rrZ6Jg6TGJXmGuJVyrrPB/Hnoe5ZXa2wj6Walc zcnUSPaUU5D6YTx9vd70JEqxRY+WuMjx3t+dRKSPf4Qshe+izn8AVfOHyJ7KGuT7NtcCs7 4gqIoN+1ms7iHSx9vpP+y6wwmup0fDTIKCNTJDuCnENnoCijLcwQyQMEFfqp+QCJ9DjP49 e1i4aTwrwdmUJqsvP9Pnjmvk7FRimXx5zbm/0s/G0VrR3ACNgR0IF+P4gJU/yqx/iyQOuD 1LvuNYGocrVcZkM/FfWrqj4baKHBX1fGagWiaiShY/HNozCj1Lzn9HqH4SSoTQ== Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -3.32 X-Spam-Score: -3.32 X-Migadu-Queue-Id: B69A733605 X-TUID: YL04gJdNS7mT Hi Andrew, On 2023-04-07 09:45, Andrew Tropin wrote: > On 2023-03-05 15:19, Bruno Victal wrote: >> --- a/gnu/home/services/desktop.scm >> +++ b/gnu/home/services/desktop.scm >> @@ -206,8 +206,8 @@ (define (home-dbus-shepherd-services config) >> (default-environment-variables)) >> #:log-file >> (format #f "~a/dbus.log" >> - (or (getenv "XDG_LOG_HOME") >> - (format #f "~a/.local/var/log" >> + (or (getenv "XDG_STATE_HOME") >> + (format #f "~a/.local/state" > > If we deprecate XDG_LOG_HOME, maybe it's a good idea to make a helper > function, which can be reused across different services? > > Also, how about appending /log subdirectory by default? >> WDYT? I'm wondering if this continued usage of XDG_LOG_HOME was a good idea, maybe the service should just start using XDG_STATE_HOME as soon as possible? (in which case, this patch will have to be reworked to reflect that) This way we avoid introducing yet more code to handle deprecated code. It shouldn't result in any kind of problems, XDG_LOG_HOME will still be set in the meantime for scripts and code that happen to use it and are not part of (upstream) guix. WDYT? Cheers, Bruno