From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55416)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fXpmF-0001X8-TL
	for guix-patches@gnu.org; Tue, 26 Jun 2018 11:21:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fXpmA-0004Fo-98
	for guix-patches@gnu.org; Tue, 26 Jun 2018 11:21:07 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:56733)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1fXpmA-0004FV-4K
	for guix-patches@gnu.org; Tue, 26 Jun 2018 11:21:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fXpm9-0003YZ-VD
	for guix-patches@gnu.org; Tue, 26 Jun 2018 11:21:01 -0400
Subject: [bug#31881] [PATCH 4/4] gnu: Add go-github-com-docker-distribution.
Resent-Message-ID: <handler.31881.B31881.153002642413617@debbugs.gnu.org>
Date: Tue, 26 Jun 2018 17:20:09 +0200 (CEST)
From: Pierre-Antoine Rouby <pierre-antoine.rouby@inria.fr>
Message-ID: <1040680639.2490239.1530026409131.JavaMail.zimbra@inria.fr>
In-Reply-To: <20180620170048.GD1240@jasmine.lan>
References: <20180619084333.8993-1-pierre-antoine.rouby@inria.fr>
	<20180619084333.8993-4-pierre-antoine.rouby@inria.fr>
	<20180620170048.GD1240@jasmine.lan>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Leo Famulari <leo@famulari.name>
Cc: 31881@debbugs.gnu.org

Hi Leo,

> From: "Leo Famulari" <leo@famulari.name>
>> +      (source
>> +       (origin
>> +         (method git-fetch)
>> +         (uri (git-reference
>> +               (url "https://github.com/docker/distribution")
>> +               (commit commit)))
>
> This bundles its entire dependency graph, including the logrus module
> you just packaged, and some other things we have packaged:

I'm not sure vendor version is the same as package version. I have the
impression some Go package have no tag or CHANGELOG, so I'm not sure for
compatibility. Without explicit version number I thinks is more sure to
use the vendor version.

> I think it's okay to add the package with the bundled code if everything
> is freely licensed. Can you confirm that it is?

Yes, everything is free.