From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id YEIaKkVnGGKALgEAgWs5BA (envelope-from ) for ; Fri, 25 Feb 2022 06:21:09 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id IEDXIkVnGGLkUwAAG6o9tA (envelope-from ) for ; Fri, 25 Feb 2022 06:21:09 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F3550DEEF for ; Fri, 25 Feb 2022 06:21:08 +0100 (CET) Received: from localhost ([::1]:57646 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nNT2R-0001R1-Of for larch@yhetil.org; Fri, 25 Feb 2022 00:21:07 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43518) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nNT2M-0001Pu-F8 for guix-patches@gnu.org; Fri, 25 Feb 2022 00:21:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:57149) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nNT2M-0005CT-5U for guix-patches@gnu.org; Fri, 25 Feb 2022 00:21:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nNT2L-0004cq-Uq for guix-patches@gnu.org; Fri, 25 Feb 2022 00:21:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53676] [PATCH v2 2/4] gnu: pulseaudio: Graft to adjust configuration. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 25 Feb 2022 05:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53676 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 53676@debbugs.gnu.org Received: via spool by 53676-submit@debbugs.gnu.org id=B53676.164576644617736 (code B ref 53676); Fri, 25 Feb 2022 05:21:01 +0000 Received: (at 53676) by debbugs.gnu.org; 25 Feb 2022 05:20:46 +0000 Received: from localhost ([127.0.0.1]:51046 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nNT26-0004c0-94 for submit@debbugs.gnu.org; Fri, 25 Feb 2022 00:20:46 -0500 Received: from mail-ej1-f66.google.com ([209.85.218.66]:37491) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nNT24-0004bl-VF for 53676@debbugs.gnu.org; Fri, 25 Feb 2022 00:20:45 -0500 Received: by mail-ej1-f66.google.com with SMTP id bg10so8671694ejb.4 for <53676@debbugs.gnu.org>; Thu, 24 Feb 2022 21:20:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=MthHyFbTDTB38MPLp0SKea62wGfKkj5akqJ146OWOJg=; b=E2UQHzLKYMHOta6W1kmoDLVm6kjfO7SaEikvXC434nPsZfe2eMFua8qQEJDMotpQaN diTgLUeYb0YB1lKgZJEhNLO8NmxhlvzSIowuIcxkTJtzMgrda9mwM7Ph4jQGTrSzL2xM J1iSidkHC7US9JITw4qV52+dmuNC/zHlGHUd2dojw9RQBIHb9fqgLJUEm3ORK0Vq+l+C UvgDv831rE44yGYYqHn60gH9EkhCYqyrbnzPLHVy1Q+YEOVzXGhznxYRcxpk/B5m+dLR K96C/Eh4uEbWy0Wt1O1+EP37bV5fMZY/uCvjSCQKh8jHIGlgojtS4W8jZog8RPprXxwC mUbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=MthHyFbTDTB38MPLp0SKea62wGfKkj5akqJ146OWOJg=; b=CrkQjEruhVoPd9ccJu0BCC37mV1ct8C2JIpHUb1Kh1qZ6KLYywZ+U1j7r7zvTjAc62 Riwtdr12EVijIL97h2TtAw5oy6XxrWu53x9zArV2ce1bICeGxSBoZXbC5pW9d1L/+Mcx 3CRtzHSx9erjC8waXf8pqoUSwKY+8JY/+ovky8jmJr82vNEVQtab61MshGDcos9RmnkG 6cBAxT+wsQfGyNTg8TybzBR8snz5b5H/r/B/fVC0Z9RenfEQdZSKp1QL9/SRIGqCVBim 7PsyXBXDGjIaewHim1vy7qYT5zHAJ32tudTi1inolvnhlBtFCROtdGxZYtReeZZOddGh RUFQ== X-Gm-Message-State: AOAM533xQ+pQ42C1d7Fn3/SyE55P9BsL34+5Go8iMQ0bSTW1n2h9+qWL f+BnbmWe//Z6Vpm5ZTNjexQ= X-Google-Smtp-Source: ABdhPJw6SVrk9SnZwIGtadWrH9FYEQx4U02xSqDahZxq4vfm5V4iC3urh9LDNbFaxuEYszk9RjEPWg== X-Received: by 2002:a17:906:1f11:b0:685:d50e:3bf9 with SMTP id w17-20020a1709061f1100b00685d50e3bf9mr4863517ejj.275.1645766438952; Thu, 24 Feb 2022 21:20:38 -0800 (PST) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id p3-20020a1709060e8300b006d0e8ada804sm553200ejf.127.2022.02.24.21.20.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Feb 2022 21:20:38 -0800 (PST) Message-ID: <103c1a1c803c3d8ae73dffa1e4ee9a71bc28d33b.camel@gmail.com> From: Liliana Marie Prikler Date: Fri, 25 Feb 2022 06:20:37 +0100 In-Reply-To: <877d9j2ad9.fsf@gmail.com> References: <20220224163828.11330-1-maxim.cournoyer@gmail.com> <20220224163828.11330-2-maxim.cournoyer@gmail.com> <387664c06141015c8fbf8db79a29e7ab09367dc2.camel@gmail.com> <877d9j2ad9.fsf@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1645766469; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=MthHyFbTDTB38MPLp0SKea62wGfKkj5akqJ146OWOJg=; b=i8qggtU6EOvhKSO6AUTxoP/tmmrcEBygH4g08B04aMupGzoZlK1TaXtp/0yBHRb0kWUKSA izLeoMVRn4nwUiMDeogZ6vOWWAt4WJpcOJM7tERxz/YuvlgzflFyJxmpFCUPaWytX/Jv4b MovWxwjchXeW8oLQe8xB5Y3l7qUJSwBpQXAPylMBDqUvBy/npdpbQ/7EK3s/9TK2YiNKyN jnZjGyW3NKndH3Elqaz4AsD/+nffu8FcJh0cx7kpGRuZkI8UrMmY2/jRoMix1qH7+S+1dF 0mwelmHQpJn7zAuZUuKl2g0y/2BV+33n+5KsR5krXP5vzn9xbLdo3UPObZjACg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1645766469; a=rsa-sha256; cv=none; b=ZuQ3Dsh4yEEvJLxiJDQJj+P9Sroj1oVlENTqymyXYHoSigxDKYR7iXs0cp6WR3gzPlxzIK 9wOiW2PIn1gYSAByfBi6UtBOoiTSRnbOVEQopqaw2DOhsu9y80RfCyjDAP9WWl8cQWneGJ yiIm83TlgGzyOAI5T8/a9bwNQvxmRV3iwuF/69lGI5psYOKAyb2T5hsoKN4f+hRhMX/lhE 6MpVPt6vn/GgiZZX5huplKx1ljfEMseH2i9GhtmEBMcmUN0MKNaMnAoErv+UbfHJOCr6nY Fcr19/h7HiU6Z6c+7QPVQ1AwwRftNK1+vuozDrROEKrAW1PBZlHP3oE0CpbBew== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=E2UQHzLK; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.03 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=E2UQHzLK; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: F3550DEEF X-Spam-Score: -2.03 X-Migadu-Scanner: scn1.migadu.com X-TUID: pAcsMJawJPT0 Hi Maxim, Am Donnerstag, dem 24.02.2022 um 17:00 -0500 schrieb Maxim Cournoyer: > Thank you for your continued feedback.  The reason I prefer this > simple substitution to a conditional one is two-fold: > > 1. It avoids two actors potentially touching the default 'script- > file' (the pulseaudio-service-type code as well as the user), which > could be unwieldy (do we plug the default.pa.d after their changes to > ensure it is there, or before, which means it'd potentially be > erased?).  Having it part of the shipped default.pa file makes this > simpler to reason with. Sure, but all we'd need here is proper documentation. For the record, I would check if a `source /etc/pulse/default.pa.d' is in the user- supplied file (even if commented) and append it if not. > 2. It allows foreign distribution users to keep their custom user > script working even when they use our pulseaudio package (it makes > our pulseaudio package behave as intended by upstream). That ignores the case where users modify their distro's default.pa *and* put stuff into default.pa.d. This might be necessary in some scenarios where the upstream default breaks user expectations. I'd really prefer if foreign distro users just set their environment variables, as those work unconditionally as intended. > I wouldn't mind using a feature branch to get the < 2k dependent > packages rebuilt as suggested by Leo, if you think that's preferable. That would work for the rebuilds, making this not a graft, but I'm still concerned whether we really want these semantics or not. With the WebkitGTK bug fixed, we can put our generated default.pa into /etc again, making it more debuggable. My personal opinion is still on explicitly declared rather than implicitly assumed. Cheers