From ba1665ee3d1c593c5baf9264cd5c5250eb0c515f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20S=C3=A1nchez=20de=20La=20Lama?= Date: Wed, 19 Oct 2016 09:12:18 +0200 Subject: [PATCH] Issue 696: ppc64le mache ckech failure This issue is not ppc64le specific. I have experienced on my 4.4.22-gnu #1 SMP 1 i686 GNU/Linux. Might be dependant on kernel version and/or machine load. POSIX says errors after posix_spawnp returns can be signaled by child exitting with an 127 exit code. --- cpio/test/test_option_lz4.c | 7 +++++++ tar/test/test_option_lz4.c | 7 +++++++ 2 files changed, 14 insertions(+) diff --git a/cpio/test/test_option_lz4.c b/cpio/test/test_option_lz4.c index d430ac7..afd683d 100644 --- a/cpio/test/test_option_lz4.c +++ b/cpio/test/test_option_lz4.c @@ -63,6 +63,13 @@ DEFINE_TEST(test_option_lz4) "but no such program is available on this system."); return; } + /* On some systems the error won't be detected until closing + time, by a 127 exit error returned by waitpid. */ + if (strstr(p, "Error closing") != NULL && !canLz4()) { + skipping("This version of bsdcpio uses an external lz4 program " + "but no such program is available on this system."); + return; + } failure("--lz4 option is broken: %s", p); assertEqualInt(r, 0); return; diff --git a/tar/test/test_option_lz4.c b/tar/test/test_option_lz4.c index 5dc9452..01ca6bb 100644 --- a/tar/test/test_option_lz4.c +++ b/tar/test/test_option_lz4.c @@ -63,6 +63,13 @@ DEFINE_TEST(test_option_lz4) "but no such program is available on this system."); return; } + /* On some systems the error won't be detected until closing + time, by a 127 exit error returned by waitpid. */ + if (strstr(p, "Error closing") != NULL && !canLz4()) { + skipping("This version of bsdcpio uses an external lz4 program " + "but no such program is available on this system."); + return; + } failure("--lz4 option is broken: %s", p); assertEqualInt(r, 0); return;