From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:47321) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jPSOV-00073F-S4 for guix-patches@gnu.org; Fri, 17 Apr 2020 10:55:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jPSOU-0005jP-M5 for guix-patches@gnu.org; Fri, 17 Apr 2020 10:55:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58124) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jPSOU-0005jE-7W for guix-patches@gnu.org; Fri, 17 Apr 2020 10:55:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jPSOU-0008Vq-75 for guix-patches@gnu.org; Fri, 17 Apr 2020 10:55:02 -0400 Subject: [bug#36599] [PATCH] gnu: Add node-semver. (Updated) References: <20190711121221.16123-1-goodoldpaul@autistici.org> In-Reply-To: <20190711121221.16123-1-goodoldpaul@autistici.org> Resent-Message-ID: MIME-Version: 1.0 Date: Fri, 17 Apr 2020 14:54:43 +0000 From: goodoldpaul@autistici.org Message-ID: <0dc7cf533fa5aa29a12e7b1da9532869@autistici.org> Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: julien@lepiller.eu Cc: 36599@debbugs.gnu.org Hi Julien, > Does npm install the test.js files when run by ittself (in which case > we replicate its behavior), or does it have a mechanism to know what > files to install? If so we thould replicate that mecanism. On my system I get giacomo@frarch /tmp$ npm i semver npm WARN saveError ENOENT: no such file or directory, open '/tmp/package.json' npm WARN enoent ENOENT: no such file or directory, open '/tmp/package.json' npm WARN tmp No description npm WARN tmp No repository field. npm WARN tmp No README data npm WARN tmp No license field. + semver@7.3.2 added 1 package and audited 1 package in 0.626s found 0 vulnerabilities giacomo@frarch /tmp$ ls -l node_modules/semver/ total 48 drwxr-xr-x 2 giacomo giacomo 60 Apr 17 16:43 bin/ -rw-r--r-- 1 giacomo giacomo 2257 Oct 26 1985 CHANGELOG.md drwxr-xr-x 2 giacomo giacomo 120 Apr 17 16:43 classes/ drwxr-xr-x 2 giacomo giacomo 520 Apr 17 16:43 functions/ -rw-r--r-- 1 giacomo giacomo 1982 Oct 26 1985 index.js drwxr-xr-x 2 giacomo giacomo 120 Apr 17 16:43 internal/ -rw-r--r-- 1 giacomo giacomo 765 Oct 26 1985 LICENSE -rw-r--r-- 1 giacomo giacomo 1645 Apr 17 16:43 package.json -rw-r--r-- 1 giacomo giacomo 69 Oct 26 1985 preload.js -rw-r--r-- 1 giacomo giacomo 619 Oct 26 1985 range.bnf drwxr-xr-x 2 giacomo giacomo 260 Apr 17 16:43 ranges/ -rw-r--r-- 1 giacomo giacomo 22109 Oct 26 1985 README.md so I believe that npm uses the "files" key [0] in package.json to decide what to install. I'm definitely available to implement that but it could take a week or two, if we feel it should be changed right away I'm probably not the best person to do that. What do you think? Should I open another issue about this? Giacomo [0]: https://github.com/npm/node-semver/blob/master/package.json#L21