From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id mLJEGwRTu2Jp6gAAbAwnHQ (envelope-from ) for ; Tue, 28 Jun 2022 21:14:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id qCBOGwRTu2JOyQAA9RJhRA (envelope-from ) for ; Tue, 28 Jun 2022 21:14:12 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0B5259DFF for ; Tue, 28 Jun 2022 21:14:12 +0200 (CEST) Received: from localhost ([::1]:38596 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o6Gf4-0002QQ-Fi for larch@yhetil.org; Tue, 28 Jun 2022 15:14:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45194) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o6Gew-0002Q1-EK for guix-patches@gnu.org; Tue, 28 Jun 2022 15:14:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:34217) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o6Gew-0007Yg-5v for guix-patches@gnu.org; Tue, 28 Jun 2022 15:14:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o6Gev-0000tQ-Uy for guix-patches@gnu.org; Tue, 28 Jun 2022 15:14:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#56286] [PATCH 3/3] gnu: Add pkgconf. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 28 Jun 2022 19:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56286 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "(" , 56286@debbugs.gnu.org Received: via spool by 56286-submit@debbugs.gnu.org id=B56286.16564436143391 (code B ref 56286); Tue, 28 Jun 2022 19:14:01 +0000 Received: (at 56286) by debbugs.gnu.org; 28 Jun 2022 19:13:34 +0000 Received: from localhost ([127.0.0.1]:56347 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o6GeU-0000sd-Bn for submit@debbugs.gnu.org; Tue, 28 Jun 2022 15:13:34 -0400 Received: from mail-ed1-f68.google.com ([209.85.208.68]:33517) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o6GeO-0000sK-WD for 56286@debbugs.gnu.org; Tue, 28 Jun 2022 15:13:32 -0400 Received: by mail-ed1-f68.google.com with SMTP id n8so4989407eda.0 for <56286@debbugs.gnu.org>; Tue, 28 Jun 2022 12:13:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:date:in-reply-to:references:user-agent :mime-version:content-transfer-encoding; bh=AEstoikmyiferH5tdRBAnoY2qR8P9fP8cCAG32Jvli8=; b=BPjKNw0V4Jmk0atA7bQwGa06dtDy4JRphv3nXHC0yWpZm7nnv9GTQzbD5iIMiwAYcs V44dcy1uhplmDqeDm5/3TwmFmY+ib8xzhhSGSWnxRMkkLfFaoRxzfs+JvB4Sd1tyuWOw UdCgqpX8MqGf/JQOF5hloUqYjI5KdHymiaEKNvljzd4u1qgTf6pWLaUbOT2NzKoYAazm gNpJ3UQML5X+Cu/z4HIkZ+d5BB3nkseEibLebVhH/rdViEFwe1ssz2BzfbB9RH2iBTwf vSDL94GC3a1vC+71av9PAXIC3/whKqMvpe1Ko0XED0FZkriQVsXTcJ0m60T+3kVKER/Z pJMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=AEstoikmyiferH5tdRBAnoY2qR8P9fP8cCAG32Jvli8=; b=xJPBJMXD/mHR2SwAu0nr5rBpD+qaZJvc1a3g3DUe31Oq9H7kuc4t4sD8B+66EfCVUz PTcKnMRLtsdxUvNDStEw9Pdv1aqcvzif3XMXf67PaEtluhodKC2Js20l4+8rWOy1FuJp jjh23ZfZ8kLxolg9g7tsKJlAy2irTOxgiqRxMmDq8SAh9p/2TK7lDRXGdnoQC6z26fc1 UdReaGCHKdsmQWOgVX3GPCaJPOekP10nyJvOsk1cHeONs61FQCT8sV2c7K+DPAQd4yPU ejwVh/+8ont0bajI1kTEyRntd/z+bXjRU8L8DQSuGNhQCGQwSTfPLN68Y1JEAJ43F8cQ xrNw== X-Gm-Message-State: AJIora9GU2b+rYqqJpKadkydPaWVrHJ1cKHG9B7YIVFeZyb9v5byBMUr AGD345XPI7Lz0s7sQSoM9V8= X-Google-Smtp-Source: AGRyM1shczVrHFdAGyha83TpQCVShHXSbCC+oxzNJGbtD883Zj/N+98tTj+HUGv2rcDEmLjIsGxcgA== X-Received: by 2002:aa7:d484:0:b0:435:65b0:e2d8 with SMTP id b4-20020aa7d484000000b0043565b0e2d8mr25363482edr.373.1656443603053; Tue, 28 Jun 2022 12:13:23 -0700 (PDT) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id o12-20020a056402038c00b0043561e0c9adsm9904065edv.52.2022.06.28.12.13.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jun 2022 12:13:22 -0700 (PDT) Message-ID: <0d359aa389bbeae5cc6852067c995286e0cc3922.camel@gmail.com> From: Liliana Marie Prikler Date: Tue, 28 Jun 2022 21:13:21 +0200 In-Reply-To: <20220628180831.9792-3-paren@disroot.org> References: <20220628180831.9792-1-paren@disroot.org> <20220628180831.9792-3-paren@disroot.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1656443652; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=AEstoikmyiferH5tdRBAnoY2qR8P9fP8cCAG32Jvli8=; b=RplpA2jXDxJOjvYWAbHnj6N9l5j61ljuvjhB4KNEPqxcvDzefupEiNa49XN8ozy2sUSziq 8Do+WuoBQy4bYRAjWky/L9PayYeZwVUNbT1Q1d6OEO48jHTL9H/cUXWcktJTc5J4va49bB +aDHD53nYCsl3LPUqxlcMb/97YE84wfZjJ5/SBFO54VNMEY1cx13cNCcnEGlqXltnTB0LD iinmI/ZqmTo7OFSFxG3GMyBOq2BTUFRKdUZOUVViE9E5gfNTW3DWDqRmLQyrq1xcpop9An rfXYROKHwcNFSb4Kf/P5QPQAzJoFYUytamoXT85gXBjxwsZN5wOb5hWDOqZ3qA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1656443652; a=rsa-sha256; cv=none; b=bbYg8S2pFErQXYtX/epZSBTc3CKNUkHDsQyNtJ3fJzYW9PYmL7NyZFRYcNhrZ5CyaeS0o9 el16RUZ3XBn2Vgg/dH0qnNNW6vnfMm21bO8+euEg1l1dGOlbiOWL+Nmx/TRnYlGf5RyF4N Gg0ygy399M8Q5LGxmY5gp7lQiaD1cv6bQBZnOYeHo79fFw9IdHFny7XNFxKY5fsiiliJvT Kim+i2HKGn7lmPUB1J+jrDBpA9sTL6Md68xFjVKmbxkNPtdBeo+Wtdz3hrMxmMgn3eNWSR AOP6p3Q5z/sDhWBcGM6/AvUrgFU8gBR9KUBCbmdfx73Kqwfwbibu4/mPkFRM6A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=BPjKNw0V; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 4.44 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=BPjKNw0V; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 0B5259DFF X-Spam-Score: 4.44 X-Migadu-Scanner: scn0.migadu.com X-TUID: IPwI7ritxyBN Am Dienstag, dem 28.06.2022 um 19:08 +0100 schrieb (: > Note that this package produces a `guix lint` warning that is > basically unfixable: > > ``` > /home/paren/code/guix/gnu/packages/pkg-config.scm:213:16: > pkgconf@1.8.0-0.b0802cb: TLS certificate error: X.509 server > certificate > for 'pkgconf.org' does not match: > C=US,ST=California,L=San Francisco,O=GitHub\, Inc.,CN=*.github.com > ``` > > This is because pkgconf.org is actually hosted via Github Pages. Note that plain HTTP works :) > * gnu/packages/pkg-config.scm (pkgconf): New variable. > --- >  gnu/packages/pkg-config.scm | 48 > +++++++++++++++++++++++++++++++++++++ >  1 file changed, 48 insertions(+) > > diff --git a/gnu/packages/pkg-config.scm b/gnu/packages/pkg- > config.scm > index dcd6ba3353..8c826ca25d 100644 > --- a/gnu/packages/pkg-config.scm > +++ b/gnu/packages/pkg-config.scm > @@ -24,9 +24,11 @@ (define-module (gnu packages pkg-config) >    #:use-module (guix build-system gnu) >    #:use-module (guix download) >    #:use-module (guix gexp) > +  #:use-module (guix git-download) >    #:use-module ((guix licenses) #:prefix license:) >    #:use-module (guix memoization) >    #:use-module (guix packages) > +  #:use-module (gnu packages autotools) >    #:use-module (gnu packages bash) >    #:export (pkg-config)) >   > @@ -168,3 +170,49 @@ (define where (string-append #$output "/bin/pkg- > config")) >               (inherit original) >               (variable "PKG_CONFIG_PATH_FOR_BUILD"))) >            (package-native-search-paths %pkg-config))))) > + > +(define-public pkgconf > +  ;; The last release was tagged on 2021-07-25, and there's been a > lot of activity > +  ;; since then. > +  (let ((commit "b0802cb3d19b5b963ad20eed464a2da6e7d7b0b5") > +        (revision "0")) > +    (package > +     (name "pkgconf") > +     (version (git-version "1.8.0" revision commit)) > +     (source (origin > +              (method git-fetch) > +              (uri (git-reference > +                    (url "https://github.com/pkgconf/pkgconf") > +                    (commit commit))) > +              (file-name (git-file-name name version)) > +              (sha256 > +               (base32 > +                > "1xcpvzahrp34jhdfsazdhbj9byr2wqwmjx7jfarhpc1x4z3l37a0")))) > +     (build-system gnu-build-system) > +     (arguments > +      ;; Kyua, which pkgconf uses for testing, is not packaged in > Guix, > +      ;; though it should be trivial to add; the problem is that it > "cannot > +      ;; find test programs" that it needs when run during this > package's > +      ;; check phase. > +      ;; Did you try running check after install? That is often required by package which don't do pre-inst-env well. > +      ;; The silver lining is that omitting Kyua means we drop > dependencies > +      ;; on pkg-config, Lua, and C++. It does not, in fact, seem as > if the > +      ;; tests are even supposed to be run by anyone but the pkgconf > +      ;; developers, as touts pkgconf's > dependency-free > +      ;; nature as an advantage over pkg-config. I think this is a misinterpretation on your part or a confusing wording on theirs. Basically, pkgconf does not *link* against any "huge" binary, so it's fine. Never mind that glib is a sane dependency to have or that it also complains about pkg-config's license, which is most meaningless in the context of tools you invoke at build time. > +      (list #:tests? #f)) > +     (native-inputs (list ;; pkgconf's autotools setup forbids the > use of any > +                          ;; earlier version of autoconf than 2.71. > +                          autoconf-2.71 > +                          automake > +                          libtool)) > +     (native-search-paths > +      (list (search-path-specification > +             (variable "PKG_CONFIG_PATH") > +             (files '("lib/pkgconfig" "lib64/pkgconfig" > "share/pkgconfig"))))) I'm not sure if we want to provide $PKG_CONFIG_PATH as a variable, but there's at least two definitions within the same file now :) > +     (home-page "https://pkgconf.org") > +     (synopsis "Package compiler and linker metadata toolkit") > +     (description "@code{pkgconf} is a compiler and linker > configuration toolkit, > +mostly compatible with freedesktop.org's @code{pkg-config}.  A > library called > +@code{libpkgconf} is provided so that programs can embed its > functionality.") > +     (license license:isc)))) Cheers