From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id CI9ELrw4GmIUqwAAgWs5BA (envelope-from ) for ; Sat, 26 Feb 2022 15:27:08 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id kPoMJ7w4GmJ4TQAAG6o9tA (envelope-from ) for ; Sat, 26 Feb 2022 15:27:08 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 743512C58A for ; Sat, 26 Feb 2022 15:27:08 +0100 (CET) Received: from localhost ([::1]:52500 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nNy2M-0008Gu-SR for larch@yhetil.org; Sat, 26 Feb 2022 09:27:06 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60250) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nNy2I-0008Gm-PZ for guix-patches@gnu.org; Sat, 26 Feb 2022 09:27:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:60708) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nNy2I-0002Qu-HM for guix-patches@gnu.org; Sat, 26 Feb 2022 09:27:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nNy2I-0007sL-E8 for guix-patches@gnu.org; Sat, 26 Feb 2022 09:27:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53878] [PATCH v5 03/22] gnu: racket: Use Git origins for Racket packages. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 26 Feb 2022 14:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53878 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Philip McGrath , 53878@debbugs.gnu.org, zimoun Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , Maxime Devos , Attila Lendvai , Malte Gerdes , raingloom Received: via spool by 53878-submit@debbugs.gnu.org id=B53878.164588560530251 (code B ref 53878); Sat, 26 Feb 2022 14:27:02 +0000 Received: (at 53878) by debbugs.gnu.org; 26 Feb 2022 14:26:45 +0000 Received: from localhost ([127.0.0.1]:54605 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nNy21-0007rr-KO for submit@debbugs.gnu.org; Sat, 26 Feb 2022 09:26:45 -0500 Received: from mailrelay.tugraz.at ([129.27.2.202]:3490) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nNy1z-0007ri-Md for 53878@debbugs.gnu.org; Sat, 26 Feb 2022 09:26:44 -0500 Received: from kagayaki.fritz.box (85-127-52-93.dsl.dynamic.surfer.at [85.127.52.93]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4K5TTy1j3Mz1DH9C; Sat, 26 Feb 2022 15:26:30 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4K5TTy1j3Mz1DH9C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1645885590; bh=jIJ0eHhZCnqJftVQLJ6lJOoczQF7ciGwt0McrEFKEx4=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=JDegogZLnQGDhFOKUIxInCxy9+6/cqjvPpD/Yu7w8ms4t70wcvHgQZ/LhTas/hjUU esmVkNaAj9mhsHLGZ9sZzd80OJunfe4F5TPl1IKhqzPz44lmbW3M5IhDuZx/Fifdqq rA1q3Dhn/dD/oq5tI6Y6SCqYFx2d8aTkTVOE8a2I= Message-ID: <0c9963cedab248085b106effdd68649647a41ca2.camel@ist.tugraz.at> From: Liliana Marie Prikler Date: Sat, 26 Feb 2022 15:26:29 +0100 In-Reply-To: <3354324.gHnXMxdNb5@bastet> References: <20220220060610.178131-1-philip@philipmcgrath.com> <20220226130254.1301333-4-philip@philipmcgrath.com> <649ff53c6b4ff05db5bad3c75abd9d49752930d1.camel@ist.tugraz.at> <3354324.gHnXMxdNb5@bastet> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: waObeELIUl4ypBWmcn/8wQ X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1645885628; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=jIJ0eHhZCnqJftVQLJ6lJOoczQF7ciGwt0McrEFKEx4=; b=IdMnHxukau3EtH+gMp4uaga4GphMSQsH8ThfwTraurxChrQkNrpoQTDA8WQO2o+zYa7zsR Q1RjkS9msU9wiFmAMB4ApafkpzYp/3drSzZc8iVbopVs5WmnktAcVfCsK8iLL8HdR4lGez /kXNEHYEoZ0vzodkE8CRqo1XOtN5bhN+H98c/+MksFi4jxGrrbVamkl5jxQz/LPAmHmE4o G8v6DPwWJYRdlWG5pFap0Z0DO/GInQMfGW6g4cE2k2XggabnqZIPmP9Dl4CL1jFap0Nn34 w0xEHG2zPRzCmbllMphIFqLKA2hduogeq687M+susZleiX2ETzDOReXHPyjOOg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1645885628; a=rsa-sha256; cv=none; b=DW3gjCWWWO2Z87iVJDnghNWwokg84UliKx2L/3GPOzC9EiVMBfJXEtfkt43xzjoHXgq+Qu BZrlScCp4XqCz6eHjgq6aVM52bBz1Johrl88ncKFmMyJ8KxfoIHqRMaytmFnJDhJtkeC/0 yhZRxMj8321GuoyGLFfgH+846PdE7gqEPLT5KZ4oz94VmoChn736wfVIarJROej7zfmMlB czUnDVtMl/9jYkrT6htrx6f87l671CFfNx2Hu7mZ+7k3Sy6fYu/9Eq9yeKSrhjFaE0luTg AvsQ6fOVsTFPXPyUDogYpdz+JCcZQU776P9M0CLQIKa0KjaXVyEK3OwxAbQnWg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=JDegogZL; dmarc=fail reason="SPF not aligned (relaxed)" header.from=tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 6.18 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=JDegogZL; dmarc=fail reason="SPF not aligned (relaxed)" header.from=tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 743512C58A X-Spam-Score: 6.18 X-Migadu-Scanner: scn0.migadu.com X-TUID: PNPUjt4RUYxv Hi,  Am Samstag, dem 26.02.2022 um 09:20 -0500 schrieb Philip McGrath: > Hi, > > On Saturday, February 26, 2022 8:47:45 AM EST Liliana Marie Prikler > wrote: > > First, can we simplify "make-installation-layer.rkt" to "make- > > installation-layer"?  I don't think the file extension conveys much > > meaning here, or does it? > > To me (I don't know about anyone else), the ".rtk" extension tells me > that I have to pass the file as an argument to `racket`, i.e. that > the file is not a launcher from `raco exe` or a script with a shebang > that I could `invoke` directly. I'm not talking about the generated file, but the procedure that generates it. Special characters like dots and slash are still pretty special in Scheme, even if they're allowed as identifiers. > > I think some way to shorten those origins would do wonders in terms > > of the number of lines this patch adds. > > > > At one point, I had abbreviated the origins as something like: > >   (REPO-SPEC SHA256 [COMMIT]) > > where REPO-SPEC is one of: > >   (GITHUB-OWNER GITHUB-REPO) >   ; ^ e.g. for https://github.com/RenaissanceBug/racket-cookies >   GITHUB-REPO ; "racket" is owner > > and COMMIT defaults to `%racket-commit`, but could be overridden for > . > > I think I'd given SHA256 as a literal string, but it could be e.g.: > >   (extract-package-source* >     `((("2d" ,(base32 > "1zzcz5qyjv7syi41vb8jkxjp1rqgj61zbsdrg0nlc4qy9qsafzgr")) >        "2d" "2d-doc" "2d-lib") >       ...)) I wouldn't do this inside of extract-package-source, but define a one or two liner for adding specifically packages hosted on racket's github. WDYT? > I wasn't sure about the trade-off between being slightly more cryptic > than explicit origins, but a lot shorter. Note that the goal is not to code golf, but to be understandable. When adding a bunch of origins as inputs, understandability suffers by induced scrolling. Cheers