[bug#63091] [PATCH] gnu: sssd: Fix failing tests by using samba/pinned input

[bug#63091] [PATCH] gnu: sssd: Fix failing tests by using samba/pinned input

[Brian Cully via Guix-patches via]

The latest samba package (4.18.1) causes a SIGABRT in ad_common_tests and
ad_gpo_tests. The pinned version (4.17.0) allows them to succeed, so use that
instead.

* gnu/packages/sssd.scm (sssd) [inputs]: Change samba to samba/pinned.
---
 gnu/packages/sssd.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/sssd.scm b/gnu/packages/sssd.scm
index a6b4c8aa90..4e585a62de 100644
--- a/gnu/packages/sssd.scm
+++ b/gnu/packages/sssd.scm
@@ -267,7 +267,7 @@ (define-public sssd
            pcre2
            popt
            python
-           samba
+           samba/pinned
            talloc
            tdb
            tevent))
-- 
2.39.2

[bug#63091] [PATCH] gnu: sssd: Fix failing tests by using samba/pinned input

[Brian Cully via Guix-patches via]

Note that this patch requires #63044, or some other fix for the 
zipfile date issue.

-bjc

[bug#63091] [PATCH v2 1/2] gnu: sssd: Fix failing tests by using samba/pinned input

[Brian Cully via Guix-patches via]

The latest samba package (4.18.1) causes a SIGABRT in ad_common_tests and
ad_gpo_tests. The pinned version (4.17.0) allows them to succeed, so use that
instead.

* gnu/packages/sssd.scm (sssd) [inputs]: Change samba to samba/pinned.
---
 gnu/packages/sssd.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/sssd.scm b/gnu/packages/sssd.scm
index a6b4c8aa90..4e585a62de 100644
--- a/gnu/packages/sssd.scm
+++ b/gnu/packages/sssd.scm
@@ -267,7 +267,7 @@ (define-public sssd
            pcre2
            popt
            python
-           samba
+           samba/pinned
            talloc
            tdb
            tevent))
-- 
2.39.2

[bug#63091] [PATCH v2 2/2] gnu: sssd: Fix build

[Brian Cully via Guix-patches via]

Use python-toolchain explicitly in order to pull in our patched ZipFile
creation which ignores timestamp.

* gnu/packages/sssd.scm (sssd) [native-inputs]: Add python-toolchain.
---
 gnu/packages/sssd.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/sssd.scm b/gnu/packages/sssd.scm
index 4e585a62de..47f5d1e559 100644
--- a/gnu/packages/sssd.scm
+++ b/gnu/packages/sssd.scm
@@ -266,7 +266,7 @@ (define-public sssd
            p11-kit ; for PKCS#11 support
            pcre2
            popt
-           python
+           python ; for wrap-program phase
            samba/pinned
            talloc
            tdb
@@ -286,6 +286,7 @@ (define-public sssd
            libxslt
            openssh ; for tests
            pkg-config
+           python-toolchain
            po4a
            softhsm ; for tests
            `(,util-linux "lib"))) ; for uuid.h, reqired for KCM
-- 
2.39.2

[bug#63091] [PATCH] gnu: sssd: Fix failing tests by using samba/pinned input

[Ludovic Courtès]

Brian Cully <bjc@spork.org> skribis:

> Use python-toolchain explicitly in order to pull in our patched ZipFile
> creation which ignores timestamp.
>
> * gnu/packages/sssd.scm (sssd) [native-inputs]: Add python-toolchain.

Hi!  Apparently that’s not working; I get:

--8<---------------cut here---------------start------------->8---
  File "/gnu/store/06cjgrygh79bxbsr0x44ryx1wy1pwvh4-python-setuptools-67.6.1/lib/python3.10/site-packages/setuptools/command/bdist_egg.py", line 444, in visit
    z.write(path, p)
  File "/gnu/store/dy3xh053ahkhrp2jamggq8cpsyvp8mg0-python-3.10.7/lib/python3.10/zipfile.py", line 1739, in write
    zinfo = ZipInfo.from_file(filename, arcname,
  File "/gnu/store/dy3xh053ahkhrp2jamggq8cpsyvp8mg0-python-3.10.7/lib/python3.10/zipfile.py", line 518, in from_file
    zinfo = cls(arcname, date_time)
  File "/gnu/store/dy3xh053ahkhrp2jamggq8cpsyvp8mg0-python-3.10.7/lib/python3.10/zipfile.py", line 362, in __init__
    raise ValueError('ZIP does not support timestamps before 1980')
ValueError: ZIP does not support timestamps before 1980
make[4]: *** [Makefile:43890: install-exec-hook] Error 1
make[4]: Leaving directory '/tmp/guix-build-sssd-2.8.1.drv-0/source'
make[3]: *** [Makefile:41784: install-exec-am] Error 2
make[3]: Leaving directory '/tmp/guix-build-sssd-2.8.1.drv-0/source'
make[2]: *** [Makefile:39905: install-am] Error 2
make[2]: Leaving directory '/tmp/guix-build-sssd-2.8.1.drv-0/source'
make[1]: *** [Makefile:38753: install-recursive] Error 1
make[1]: Leaving directory '/tmp/guix-build-sssd-2.8.1.drv-0/source'
make: *** [Makefile:39898: install] Error 2
error: in phase 'install': uncaught exception:
%exception #<&invoke-error program: "make" arguments: ("install" "CFLAGS=-DRENEWAL_PROG_PATH=\\\"/gnu/store/6zgxgnsx65kqcmhi6kxjhcmh53pjc9hb-adcli-0.9.2/sbin/adcli\\\"" "DOCBOOK_XSLT=/gnu/store/ljajixj3z0pc98lvk4rfr7lydq4mwa16-docbook-xsl-1.79.2-0.fe16c90/xml/xsl/docbook-xsl-1.79.2-0.fe16c90/manpages/docbook.xsl" "XMLLINT_FLAGS = --catalogs --nonet --noent --xinclude --noout") exit-status: 2 term-signal: #f stop-signal: #f> 
phase `install' failed after 22.8 seconds
command "make" "install" "CFLAGS=-DRENEWAL_PROG_PATH=\\\"/gnu/store/6zgxgnsx65kqcmhi6kxjhcmh53pjc9hb-adcli-0.9.2/sbin/adcli\\\"" "DOCBOOK_XSLT=/gnu/store/ljajixj3z0pc98lvk4rfr7lydq4mwa16-docbook-xsl-1.79.2-0.fe16c90/xml/xsl/docbook-xsl-1.79.2-0.fe16c90/manpages/docbook.xsl" "XMLLINT_FLAGS = --catalogs --nonet --noent --xinclude --noout" failed with status 2
--8<---------------cut here---------------end--------------->8---

Could you take a look?

(This is on top of aecc6e70587f8412cbbb9b2c13141de4f534518e.)

Thanks,
Ludo’.

[bug#63091] [PATCH] gnu: sssd: Fix failing tests by using samba/pinned input

[Brian Cully via Guix-patches via]

Ludovic Courtès <ludo@gnu.org> writes:
> Hi!  Apparently that’s not working; I get:
>
>   File 
>   "/gnu/store/06cjgrygh79bxbsr0x44ryx1wy1pwvh4-python-setuptools-67.6.1/lib/python3.10/site-packages/setuptools/command/bdist_egg.py", 
>   line 444, in visit
>     z.write(path, p)
>   File 
>   "/gnu/store/dy3xh053ahkhrp2jamggq8cpsyvp8mg0-python-3.10.7/lib/python3.10/zipfile.py", 
>   line 1739, in write
>     zinfo = ZipInfo.from_file(filename, arcname,
>   File 
>   "/gnu/store/dy3xh053ahkhrp2jamggq8cpsyvp8mg0-python-3.10.7/lib/python3.10/zipfile.py", 
>   line 518, in from_file
>     zinfo = cls(arcname, date_time)
>   File 
>   "/gnu/store/dy3xh053ahkhrp2jamggq8cpsyvp8mg0-python-3.10.7/lib/python3.10/zipfile.py", 
>   line 362, in __init__
>     raise ValueError('ZIP does not support timestamps before 
>     1980')

This is the same ZipFile error as in #63044, so that has to be 
fixed first. I mentioned that eariler in this report, but probably 
should have re-iterated it here. #63149 is similar in this regard.

-bjc

[bug#63091] [PATCH v3 1/2] gnu: sssd: Fix failing tests by using samba/pinned input

[Brian Cully via Guix-patches via]

The latest samba package (4.18.1) causes a SIGABRT in ad_common_tests and
ad_gpo_tests. The pinned version (4.17.0) allows them to succeed, so use that
instead.

* gnu/packages/sssd.scm (sssd) [inputs]: Change samba to samba/pinned.
---
 gnu/packages/sssd.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/sssd.scm b/gnu/packages/sssd.scm
index a6b4c8aa90..4e585a62de 100644
--- a/gnu/packages/sssd.scm
+++ b/gnu/packages/sssd.scm
@@ -267,7 +267,7 @@ (define-public sssd
            pcre2
            popt
            python
-           samba
+           samba/pinned
            talloc
            tdb
            tevent))

base-commit: 91bfd30ee3f35dfb7048bf42aea92f939cffbf17
prerequisite-patch-id: 5908eef27f1e709c3d066ab89eb094458c0109ac
-- 
2.39.2

[bug#63091] [PATCH v3 2/2] gnu: sssd: Fix build

[Brian Cully via Guix-patches via]

* gnu/packages/sssd.scm (sssd) [native-inputs]: Add python-toolchain.
[ensure-no-mtimes-pre-1980]: New phase.
---
 gnu/packages/sssd.scm | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/sssd.scm b/gnu/packages/sssd.scm
index 4e585a62de..25ff300aa9 100644
--- a/gnu/packages/sssd.scm
+++ b/gnu/packages/sssd.scm
@@ -27,6 +27,7 @@ (define-module (gnu packages sssd)
   #:use-module (guix download)
   #:use-module (guix gexp)
   #:use-module (guix git-download)
+  #:use-module (guix modules)
   #:use-module (guix utils)
   #:use-module (guix build utils)
   #:use-module (guix build-system gnu)
@@ -151,6 +152,8 @@ (define-public sssd
     (build-system gnu-build-system)
     (arguments
      (list
+      #:imported-modules (source-module-closure
+                          '((guix build python-build-system)))
       #:make-flags
       #~(list (string-append "CFLAGS=-DRENEWAL_PROG_PATH=\\\""
                              #$(this-package-input "adcli") "/sbin/adcli"
@@ -184,6 +187,8 @@ (define-public sssd
                              "/xml/dtd/docbook/catalog.xml"))
       #:phases
       #~(modify-phases %standard-phases
+          (add-after 'unpack 'ensure-no-mtimes-pre-1980
+            (@@ (guix build python-build-system) ensure-no-mtimes-pre-1980))
           (add-after 'patch-source-shebangs 'patch-more-shebangs
             (lambda _
               (substitute* '("src/tools/analyzer/sss_analyze"
@@ -266,7 +271,7 @@ (define-public sssd
            p11-kit ; for PKCS#11 support
            pcre2
            popt
-           python
+           python ; for wrap-program phase
            samba/pinned
            talloc
            tdb
@@ -286,6 +291,7 @@ (define-public sssd
            libxslt
            openssh ; for tests
            pkg-config
+           python-toolchain
            po4a
            softhsm ; for tests
            `(,util-linux "lib"))) ; for uuid.h, reqired for KCM
-- 
2.39.2

bug#63091: [PATCH] gnu: sssd: Fix failing tests by using samba/pinned input

[Ludovic Courtès]

Brian Cully <bjc@spork.org> skribis:

> The latest samba package (4.18.1) causes a SIGABRT in ad_common_tests and
> ad_gpo_tests. The pinned version (4.17.0) allows them to succeed, so use that
> instead.
>
> * gnu/packages/sssd.scm (sssd) [inputs]: Change samba to samba/pinned.

[...]

> * gnu/packages/sssd.scm (sssd) [native-inputs]: Add python-toolchain.
> [ensure-no-mtimes-pre-1980]: New phase.

Finally applied, thanks!

Ludo’.