From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47820) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dYvJC-0005Nm-6g for guix-patches@gnu.org; Sat, 22 Jul 2017 10:23:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dYvJ8-0001c0-U4 for guix-patches@gnu.org; Sat, 22 Jul 2017 10:23:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:49815) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dYvJ8-0001bv-Oh for guix-patches@gnu.org; Sat, 22 Jul 2017 10:23:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dYvJ8-0001cm-Iq for guix-patches@gnu.org; Sat, 22 Jul 2017 10:23:02 -0400 Subject: [bug#27790] text-editor: mg Resent-Message-ID: References: <20170722113613.shefcwrn3m2t6suu@abyayala> From: Tobias Geerinckx-Rice Message-ID: <0be93d82-ed4c-6024-62c9-426ed6e3a268@tobias.gr> Date: Sat, 22 Jul 2017 16:24:29 +0200 MIME-Version: 1.0 In-Reply-To: <20170722113613.shefcwrn3m2t6suu@abyayala> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="BdKeIMl7GmxUvaHvuic2qpO0CaQT8XEdW" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 27790@debbugs.gnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --BdKeIMl7GmxUvaHvuic2qpO0CaQT8XEdW Content-Type: multipart/mixed; boundary="1AR4MVCeLQmMUURu7JbAjxHwLv6CIp5XM"; protected-headers="v1" From: Tobias Geerinckx-Rice To: 27790@debbugs.gnu.org Message-ID: <0be93d82-ed4c-6024-62c9-426ed6e3a268@tobias.gr> Subject: Re: [bug#27790] text-editor: mg References: <20170722113613.shefcwrn3m2t6suu@abyayala> In-Reply-To: <20170722113613.shefcwrn3m2t6suu@abyayala> --1AR4MVCeLQmMUURu7JbAjxHwLv6CIp5XM Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable ng0, Thanks! Some minor points, most of which can be taken care of by the committer (i.e. probably me) when they push: ng0 wrote on 22/07/17 at 13:36: > From d1cae87a9b13b5624deb16666a1da3333bd05681 Mon Sep 17 00:00:00 2001 > From: ng0 > Date: Sat, 22 Jul 2017 11:31:37 +0000 > Subject: [PATCH] gnu: Add mg. >=20 > * gnu/packages/text-editors.scm (mg): New variable. > --- > gnu/packages/text-editors.scm | 57 +++++++++++++++++++++++++++++++++++= +++++++- > 1 file changed, 56 insertions(+), 1 deletion(-) >=20 > diff --git a/gnu/packages/text-editors.scm b/gnu/packages/text-editors.= scm > index 98df48119..9277dd1f5 100644 > --- a/gnu/packages/text-editors.scm > +++ b/gnu/packages/text-editors.scm > @@ -3,7 +3,7 @@ > ;;; Copyright =C2=A9 2016 Carlo Zancanaro > ;;; Copyright =C2=A9 2017 Eric Bavier > ;;; Copyright =C2=A9 2017 Feng Shu > -;;; Copyright =C2=A9 2017 ng0 > +;;; Copyright =C2=A9 2017 ng0 > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -34,6 +34,7 @@ > #:use-module (gnu packages gcc) > #:use-module (gnu packages glib) > #:use-module (gnu packages gtk) > + #:use-module (gnu packages libbsd) > #:use-module (gnu packages lua) > #:use-module (gnu packages ncurses) > #:use-module (gnu packages pkg-config) > @@ -227,3 +228,57 @@ Wordstar-, EMACS-, Pico, Nedit or vi-like key bind= ings. e3 can be used on > 16, 32, and 64-bit CPUs.") > (supported-systems '("x86_64-linux" "i686-linux")) > (license license:gpl2+))) > + > +(define-public mg > + (package > + (name "mg") > + (version "20170401") > + (source > + (origin > + (method url-fetch) > + (uri (string-append "http://homepage.boetes.org/software/mg/" > + "mg-" version ".tar.gz")) HTTPS works, so let's use it just because we can. Same for home-page. > + (sha256 > + (base32 > + "1arasswgdadbb265rahq3867r9s54jva6k4m3p5n0f8mgjqhhdha")))) > + (build-system gnu-build-system) > + (arguments > + `(#:tests? #f ; There is no testsuite s/There/there/, and s/testsuite/test suite/ since I'm already being pedantic. > + #:make-flags (list "CC=3Dgcc") > + #:phases > + (modify-phases %standard-phases > + (delete 'configure) ; There is no configure script Same here. > + (add-before 'build 'replace-usr > + (lambda* (#:key outputs #:allow-other-keys) > + (substitute* "GNUmakefile" > + (("/usr/bin/") "") > + (("/usr/local") > + (assoc-ref outputs "out"))) > + #t)) > + (add-before 'build 'correct-location-of-difftool > + (lambda _ > + (substitute* "buffer.c" > + (("/usr/bin/diff") > + (which "diff"))) Cool. I learn new things every day. > + #t)) > + (add-before 'install 'install-tutorial > + (lambda* (#:key outputs #:allow-other-keys) > + ;; This isn't handled by install but is expect s/expect/expected/, but: > + ;; by the tutorial part of mg to be present. What exactly do you mean by =E2=80=98the tutorial part of mg=E2=80=99? I = tried C-h t with no result, and the only mentions of =E2=80=98tutorial=E2=80=99 in th= e tarball are in the manual page and the tutorial itself. > + (let* ((out (assoc-ref outputs "out")) > + (doc (string-append out "/share/doc/mg"))) > + (install-file "tutorial" > + (string-append doc "/tutorial")) > + #t)))))) > + (inputs > + `(("ncurses" ,ncurses) > + ("libbsd" ,libbsd))) > + (native-inputs > + `(("pkg-config" ,pkg-config))) > + (home-page "http://homepage.boetes.org/software/mg/") > + (synopsis "OpenBSD variant of the editor mg") This appears to be the canonical modern =E2=80=98portable=E2=80=99 mg, so= I'd move the OpenBSD bit to the description. We're packaging this as mg, after all, not mg-openbsd. What do you think of "Small and fast text editor in the style of GNU Emacs"? > + (description > + "Mg is a public domain text editor intended to loosely resemble > +GNU Emacs, while still retaining fast speed and a small memory footpri= nt. > +It is based on MicroEMACS.") =E2=80=98Public-domain=E2=80=99 can be dropped, and IMO so can its MicroE= MACS history. This does leave us with a very short description indeed... > + (license license:public-domain))) True freedom=E2=84=A2! T G-R --1AR4MVCeLQmMUURu7JbAjxHwLv6CIp5XM-- --BdKeIMl7GmxUvaHvuic2qpO0CaQT8XEdW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQFBBAEBCgArFiEEeqzfDJ8DWw5d4xcqkczbm0hUG5kFAllzYB0NHG1lQHRvYmlh cy5ncgAKCRCRzNubSFQbmT04B/4i50lm0rljsRqlTpX2azDMMtYhVGb0eeXGdR2E 6wNjITL4SxgPsAW5GOT3zLPr9OSRNdxQ9cb4oV4D8UOc6g1cf9wqPuFbzAQLUSYC I7ZDknpz+u2gzdrSoi1yAXR0ZeOypvKy7cwImn87OnAoqDzpYdZ8d8HmVfHwhbcx HzjLMAKmZHJ5iX5t4poGBUrnXPPzHhpOmAGRaqiK4T3lRiH5Tk76DGE5xwXkMrma 0pqLgH4lZiXMTQWegAjvO2wDF5ASQ1XtD4WsqVw0gmGvxm7Q2HzdhAJ6ppoffy8F ArTIvhT78jlb05SJKP56ZN726Ft60xlElpJ5lLZv5ASzguaL =G2SG -----END PGP SIGNATURE----- --BdKeIMl7GmxUvaHvuic2qpO0CaQT8XEdW--