all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#72016] [PATCH] gnu: emacs-lsp-mode: Enable plists.
@ 2024-07-09 11:52 Danny Milosavljevic
  2024-07-18 15:03 ` Ludovic Courtès
  0 siblings, 1 reply; 3+ messages in thread
From: Danny Milosavljevic @ 2024-07-09 11:52 UTC (permalink / raw)
  To: 72016
  Cc: Danny Milosavljevic, Andrew Tropin, Katherine Cox-Buday,
	Liliana Marie Prikler

* gnu/packages/emacs-xyz.scm (emacs-lsp-mode)[arguments]<#:phases>
[enable-plists]: New phase.

Change-Id: I5088954b683b23ab51bd5d6adc09dcc9a1c85ec1
---
 gnu/packages/emacs-xyz.scm | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index d5257f16a9..fd04e2432b 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -31169,6 +31169,14 @@ (define-public emacs-lsp-mode
               (for-each (lambda (f)
                           (install-file f "."))
                         (find-files "clients/" "\\.el$"))))
+          (add-after 'unpack 'enable-plists
+            (lambda _
+              (substitute* "lsp-protocol.el"
+               ;; This is faster, and it's officially recommended,
+               ;; and it's required by emacs-lsp-booster.
+               ;; See also:
+               ;; <https://emacs-lsp.github.io/lsp-mode/page/performance/>.
+               (("\\(getenv \"LSP_USE_PLISTS\"\\)") "t"))))
           (add-before 'move-clients-libraries 'fix-patch-el-files
             ;; /bin/ksh is only used on macOS, which we don't support, so we
             ;; don't want to add it as input.

base-commit: 13f0f52314244f08eb9fdd626d907c0c3976e06a
-- 
2.45.2





^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [bug#72016] [PATCH] gnu: emacs-lsp-mode: Enable plists.
  2024-07-09 11:52 [bug#72016] [PATCH] gnu: emacs-lsp-mode: Enable plists Danny Milosavljevic
@ 2024-07-18 15:03 ` Ludovic Courtès
  2024-07-21 10:15   ` bug#72016: " Liliana Marie Prikler
  0 siblings, 1 reply; 3+ messages in thread
From: Ludovic Courtès @ 2024-07-18 15:03 UTC (permalink / raw)
  To: Danny Milosavljevic
  Cc: Katherine Cox-Buday, 72016, Liliana Marie Prikler, Andrew Tropin

Hey Danny!

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> * gnu/packages/emacs-xyz.scm (emacs-lsp-mode)[arguments]<#:phases>
> [enable-plists]: New phase.
>
> Change-Id: I5088954b683b23ab51bd5d6adc09dcc9a1c85ec1
> ---
>  gnu/packages/emacs-xyz.scm | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index d5257f16a9..fd04e2432b 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -31169,6 +31169,14 @@ (define-public emacs-lsp-mode
>                (for-each (lambda (f)
>                            (install-file f "."))
>                          (find-files "clients/" "\\.el$"))))
> +          (add-after 'unpack 'enable-plists
> +            (lambda _
> +              (substitute* "lsp-protocol.el"
> +               ;; This is faster, and it's officially recommended,
> +               ;; and it's required by emacs-lsp-booster.
> +               ;; See also:
> +               ;; <https://emacs-lsp.github.io/lsp-mode/page/performance/>.
> +               (("\\(getenv \"LSP_USE_PLISTS\"\\)") "t"))))

I’m know next to nothing about LSP, but that sounds reasonable to me!

Ludo’.




^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#72016: [PATCH] gnu: emacs-lsp-mode: Enable plists.
  2024-07-18 15:03 ` Ludovic Courtès
@ 2024-07-21 10:15   ` Liliana Marie Prikler
  0 siblings, 0 replies; 3+ messages in thread
From: Liliana Marie Prikler @ 2024-07-21 10:15 UTC (permalink / raw)
  To: Ludovic Courtès, Danny Milosavljevic
  Cc: Katherine Cox-Buday, 72016-done, Andrew Tropin

Am Donnerstag, dem 18.07.2024 um 17:03 +0200 schrieb Ludovic Courtès:
> Hey Danny!
> 
> Danny Milosavljevic <dannym@scratchpost.org> skribis:
> 
> > * gnu/packages/emacs-xyz.scm (emacs-lsp-mode)[arguments]<#:phases>
> > [enable-plists]: New phase.
> > 
> > Change-Id: I5088954b683b23ab51bd5d6adc09dcc9a1c85ec1
> > ---
> >  gnu/packages/emacs-xyz.scm | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> > 
> > diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-
> > xyz.scm
> > index d5257f16a9..fd04e2432b 100644
> > --- a/gnu/packages/emacs-xyz.scm
> > +++ b/gnu/packages/emacs-xyz.scm
> > @@ -31169,6 +31169,14 @@ (define-public emacs-lsp-mode
> >                (for-each (lambda (f)
> >                            (install-file f "."))
> >                          (find-files "clients/" "\\.el$"))))
> > +          (add-after 'unpack 'enable-plists
> > +            (lambda _
> > +              (substitute* "lsp-protocol.el"
> > +               ;; This is faster, and it's officially recommended,
> > +               ;; and it's required by emacs-lsp-booster.
> > +               ;; See also:
> > +               ;;
> > <https://emacs-lsp.github.io/lsp-mode/page/performance/>.
> > +               (("\\(getenv \"LSP_USE_PLISTS\"\\)") "t"))))
> 
> I’m know next to nothing about LSP, but that sounds reasonable to me!
I agree.  Pushed.

Cheers

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-07-21 10:17 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-09 11:52 [bug#72016] [PATCH] gnu: emacs-lsp-mode: Enable plists Danny Milosavljevic
2024-07-18 15:03 ` Ludovic Courtès
2024-07-21 10:15   ` bug#72016: " Liliana Marie Prikler

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.