all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: 68258@debbugs.gnu.org
Cc: "Ludovic Courtès" <ludo@gnu.org>
Subject: [bug#68258] [PATCH 7/7] services: bitlbee: Use ‘make-inetd-constructor’ unconditionally.
Date: Fri,  5 Jan 2024 11:59:34 +0100	[thread overview]
Message-ID: <0b95b9f23a3d09919a9d49d2c297abfe826b1eda.1704451578.git.ludo@gnu.org> (raw)
In-Reply-To: <cover.1704451578.git.ludo@gnu.org>

This construct was introduced in Shepherd 0.9.0.

* gnu/services/messaging.scm (bitlbee-shepherd-service): Use
‘make-inetd-constructor’ unconditionally.

Change-Id: Id1b79077d60609c7f95439ee0d097dfe6e66dd2e
---
 gnu/services/messaging.scm | 51 ++++++++++++++------------------------
 1 file changed, 18 insertions(+), 33 deletions(-)

diff --git a/gnu/services/messaging.scm b/gnu/services/messaging.scm
index 7505810e7c..9702170b3e 100644
--- a/gnu/services/messaging.scm
+++ b/gnu/services/messaging.scm
@@ -1,7 +1,7 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2017, 2018 Clément Lassieur <clement@lassieur.org>
 ;;; Copyright © 2017 Mathieu Othacehe <m.othacehe@gmail.com>
-;;; Copyright © 2015, 2017-2020, 2022, 2023 Ludovic Courtès <ludo@gnu.org>
+;;; Copyright © 2015, 2017-2020, 2022-2024 Ludovic Courtès <ludo@gnu.org>
 ;;; Copyright © 2018 Pierre-Antoine Rouby <contact@parouby.fr>
 ;;;
 ;;; This file is part of GNU Guix.
@@ -857,39 +857,24 @@ (define bitlbee-shepherd-service
               ;; on 'networking'.
               (requirement '(user-processes networking))
 
-              (start #~(if (defined? 'make-inetd-constructor)
+              (start #~(make-inetd-constructor
+                        (list #$bitlbee* "-I" "-c" #$conf)
+                        (list (endpoint
+                               (addrinfo:addr
+                                (car (getaddrinfo #$interface
+                                                  #$(number->string port)
+                                                  (logior AI_NUMERICHOST
+                                                          AI_NUMERICSERV))))))
+                        #:requirements '#$requirement
+                        #:service-name-stem "bitlbee"
+                        #:user "bitlbee" #:group "bitlbee"
 
-                           (make-inetd-constructor
-                            (list #$bitlbee* "-I" "-c" #$conf)
-                            (list (endpoint
-                                   (addrinfo:addr
-                                    (car (getaddrinfo #$interface
-                                                      #$(number->string port)
-                                                      (logior AI_NUMERICHOST
-                                                              AI_NUMERICSERV))))))
-                            #:requirements '#$requirement
-                            #:service-name-stem "bitlbee"
-                            #:user "bitlbee" #:group "bitlbee"
-
-                            ;; Allow 'bitlbee-purple' to use libpurple plugins.
-                            #:environment-variables
-                            (list (string-append "PURPLE_PLUGIN_PATH="
-                                                 #$plugins "/lib/purple-2")
-                                  "GUIX_LOCPATH=/run/current-system/locale"))
-
-                           (make-forkexec-constructor
-                            (list #$(file-append bitlbee "/sbin/bitlbee")
-                                  "-n" "-F" "-u" "bitlbee" "-c" #$conf)
-
-                            ;; Allow 'bitlbee-purple' to use libpurple plugins.
-                            #:environment-variables
-                            (list (string-append "PURPLE_PLUGIN_PATH="
-                                                 #$plugins "/lib/purple-2"))
-
-                            #:pid-file "/var/run/bitlbee.pid")))
-              (stop  #~(if (defined? 'make-inetd-destructor)
-                           (make-inetd-destructor)
-                           (make-kill-destructor)))))))))
+                        ;; Allow 'bitlbee-purple' to use libpurple plugins.
+                        #:environment-variables
+                        (list (string-append "PURPLE_PLUGIN_PATH="
+                                             #$plugins "/lib/purple-2")
+                              "GUIX_LOCPATH=/run/current-system/locale")))
+              (stop  #~(make-inetd-destructor))))))))
 
 (define %bitlbee-accounts
   ;; User group and account to run BitlBee.
-- 
2.41.0





  parent reply	other threads:[~2024-01-05 11:01 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-05 10:59 [bug#68258] [PATCH 0/7] Upgrading Shepherd and moving the Hurd to 0.10.x Ludovic Courtès
2024-01-05 10:56 ` [bug#68258] [PATCH 1/7] services: openssh: Add dependency on ‘networking’ Ludovic Courtès
2024-01-05 18:00   ` Janneke Nieuwenhuizen
2024-01-05 10:59 ` [bug#68258] [PATCH 2/7] tests: childhurd: Increase SSH connection timeout Ludovic Courtès
2024-01-05 10:59 ` [bug#68258] [PATCH 3/7] DRAFT gnu: shepherd: Update to 0.10.3 Ludovic Courtès
2024-01-05 10:59 ` [bug#68258] [PATCH 4/7] system: hurd: Use the Shepherd 0.10.x Ludovic Courtès
2024-01-05 10:59 ` [bug#68258] [PATCH 5/7] services: shepherd: Use the 0.10.x GOOPS-less interface Ludovic Courtès
2024-01-05 10:59 ` [bug#68258] [PATCH 6/7] home: services: shepherd: Use the 0.10.x interface Ludovic Courtès
2024-01-05 10:59 ` Ludovic Courtès [this message]
2024-01-05 17:59 ` [bug#68258] [PATCH 0/7] Upgrading Shepherd and moving the Hurd to 0.10.x Janneke Nieuwenhuizen
2024-01-06 16:15   ` Janneke Nieuwenhuizen
2024-01-06 16:32     ` Janneke Nieuwenhuizen
2024-01-07 11:12     ` Ludovic Courtès
2024-01-07 14:54       ` Janneke Nieuwenhuizen
2024-01-08 23:54         ` bug#68258: " Ludovic Courtès
2024-01-07 11:14   ` [bug#68258] " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0b95b9f23a3d09919a9d49d2c297abfe826b1eda.1704451578.git.ludo@gnu.org \
    --to=ludo@gnu.org \
    --cc=68258@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.