From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:1008:1e59::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id sAWSK6UPfmWxNQAAkFu2QA (envelope-from ) for ; Sat, 16 Dec 2023 21:59:17 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id mMXeJ6UPfmUNUgAA62LTzQ (envelope-from ) for ; Sat, 16 Dec 2023 21:59:17 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1702760357; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=qRmSClzC1FBtb+FyXf/ulcqLaBKPjwvzw37P7FURIk4=; b=GrPQLtQz3wHNUWPwNVDpdWER3FgXJoDAcU2BvMWrPYdP8R144UE3k1zRMfIJOXVwGd7WNC 0FY86A3hF/JJDgJI+QewBEB7n2rh/sdKk/yI4pJITJ/w2D2eChm+P2py2sULP8j3qAOMOW 7o6itCwtA3+XTg8lUW2Q/xqHbSpabC0Dz5+7syz8Fv0zqVq3aJPyHNe3ccP06MfS7K3qko Jne+EwerKbHnmMW+AOT16bp4Fl7TKOLJeBkxLxoqqL4Xxm/rUYL+KZM5+fcdmLHZbRVJhE v7nd843yPQJ3Ti4sjpWfvnqrqykAb3NXIf3BJmNiE7Qwpyuhzxj+tkR3bQXOfQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1702760357; a=rsa-sha256; cv=none; b=n8VS/e5MINcA3wyF+lMPVx2eI7s3bFu4tKBnibDxID8jmmyfOsWdDn8q5AENR3wl9X9qEv 8gq2gjZ8QP5zI+HGhQkXMA/7WLRdE6gWDwloDb95TYzmgYb/xe3h19UdvX6+X5Hsgu3vsA EnA1TXaPdbmxsUwueNVZY1yhJ8kS4D8UkhCQ0newr1BWtL3sQSNyFGL4Ui8R8acfL9VxQT /ch4o++RXm2i15NmCjDrC1J21nbDCIO10ABUhXujlBeyqkOB+h4mgRli1O1xS1y1/rCN/V oXEvjatwArXwubyRdQYX0TyBThlNBaUAtB1rD9v6snSezSO7u4WVb0YqPVqqpg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7EE0250DC2 for ; Sat, 16 Dec 2023 21:59:17 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rEbkV-0002u4-J3; Sat, 16 Dec 2023 15:59:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rEbkT-0002tw-Js for guix-patches@gnu.org; Sat, 16 Dec 2023 15:59:01 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rEbkT-0002de-5x for guix-patches@gnu.org; Sat, 16 Dec 2023 15:59:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rEbkT-0003KP-Le for guix-patches@gnu.org; Sat, 16 Dec 2023 15:59:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#67497] [PATCH 2/4] In certbot documentation, call environment variables by their proper name. Resent-From: Bruno Victal Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 16 Dec 2023 20:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67497 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Felix Lechner Cc: 67497@debbugs.gnu.org Received: via spool by 67497-submit@debbugs.gnu.org id=B67497.170276032612749 (code B ref 67497); Sat, 16 Dec 2023 20:59:01 +0000 Received: (at 67497) by debbugs.gnu.org; 16 Dec 2023 20:58:46 +0000 Received: from localhost ([127.0.0.1]:56172 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEbkD-0003JY-Rk for submit@debbugs.gnu.org; Sat, 16 Dec 2023 15:58:46 -0500 Received: from smtpm3.myservices.hosting ([185.26.105.234]:36792) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEbkA-0003JO-Nu for 67497@debbugs.gnu.org; Sat, 16 Dec 2023 15:58:44 -0500 Received: from mail1.netim.hosting (unknown [185.26.106.173]) by smtpm3.myservices.hosting (Postfix) with ESMTP id 52961210AE; Sat, 16 Dec 2023 21:58:39 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mail1.netim.hosting (Postfix) with ESMTP id 9F2E680095; Sat, 16 Dec 2023 21:58:39 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail1.netim.hosting Received: from mail1.netim.hosting ([127.0.0.1]) by localhost (mail1-2.netim.hosting [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id jzqLbTRfECKO; Sat, 16 Dec 2023 21:58:39 +0100 (CET) Received: from [192.168.1.116] (unknown [10.192.1.83]) (Authenticated sender: lumen@makinata.eu) by mail1.netim.hosting (Postfix) with ESMTPSA id 2973280067; Sat, 16 Dec 2023 21:58:39 +0100 (CET) Message-ID: <0b64f8bb-755d-4c09-af51-871392de8262@makinata.eu> Date: Sat, 16 Dec 2023 20:58:37 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US References: From: Bruno Victal In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------s80WGHVnW0hdWx0P99uCBDzY" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -8.26 X-Spam-Score: -8.26 X-Migadu-Queue-Id: 7EE0250DC2 X-TUID: oEgUy1U0VBkC This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------s80WGHVnW0hdWx0P99uCBDzY Content-Type: multipart/mixed; boundary="------------SGGSRoTD2D05xj1fs0Dkl8Eu"; protected-headers="v1" From: Bruno Victal To: Felix Lechner Cc: 67497@debbugs.gnu.org Message-ID: <0b64f8bb-755d-4c09-af51-871392de8262@makinata.eu> Subject: Re: [PATCH 2/4] In certbot documentation, call environment variables by their proper name. References: In-Reply-To: --------------SGGSRoTD2D05xj1fs0Dkl8Eu Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 2023-11-27 21:20, Felix Lechner wrote: > Certbot's hooks can be written in any language. in fact, they can be an= y kind > of executable. Environment variables are widely used to communicate val= ues > across that type of fork(2) boundary. In the context here, it is more a= ccurate > to talk about environment variables. >=20 > Change-Id: If0b476c3367a3108d9365d718a74faa7d9fe7530 > --- > doc/guix.texi | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/doc/guix.texi b/doc/guix.texi > index b0b1c05c73..440a5f3efa 100644 > --- a/doc/guix.texi > +++ b/doc/guix.texi > @@ -32139,24 +32139,24 @@ Certificate Services > =20 > @item @code{authentication-hook} (default: @code{#f}) > Command to be run in a shell once for each certificate challenge to be= > -answered. For this command, the shell variable @code{$CERTBOT_DOMAIN}= > +answered. For this command, the environment variable @code{$CERTBOT_D= OMAIN} [=E2=80=A6] > will contain the domain being authenticated, @code{$CERTBOT_VALIDATION= } [=E2=80=A6] > contains the validation string and @code{$CERTBOT_TOKEN} contains the [=E2=80=A6] > variables available in the @code{auth-hook} script are still available= , and > additionally @code{$CERTBOT_AUTH_OUTPUT} will contain the standard out= put [=E2=80=A6] > @code{$RENEWED_LINEAGE} will point to the config live subdirectory (fo= r > example, @samp{"/etc/letsencrypt/live/example.com"}) containing the ne= w > -certificates and keys; the shell variable @code{$RENEWED_DOMAINS} will= > +certificates and keys; the environment variable @code{$RENEWED_DOMAINS= } will > contain a space-delimited list of renewed certificate domains (for > example, @samp{"example.com www.example.com"}. The correct Texinfo @-command should be @env{CERTBOT_DOMAIN}, =E2=80=A6. Could you amend and send a v2 that addresses these issues as well? Other than that, it LGTM. --=20 Furthermore, I consider that nonfree software must be eradicated. Cheers, Bruno. --------------SGGSRoTD2D05xj1fs0Dkl8Eu-- --------------s80WGHVnW0hdWx0P99uCBDzY Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQTAPCseV0HOaN0YFheobOGDL+spVQUCZX4PfgAKCRCobOGDL+sp VVTiAQCatAiQllltzz9arRgpE1fDw64cmwzFTsI5tPDfVTPRxgEAn5nq/vOg3/VU wpqrUC22QaneB6QJZepQ1HP/N9hKAQQ= =irh9 -----END PGP SIGNATURE----- --------------s80WGHVnW0hdWx0P99uCBDzY--