From mboxrd@z Thu Jan 1 00:00:00 1970 From: mjbecze@riseup.net Subject: Re: [PATCH] WIP patches for the rust importer Date: Wed, 27 Nov 2019 16:36:20 -0800 Message-ID: <0b2db52d687fc2acf34dc1e00618dae7.squirrel@sm.riseup.net> References: <20191126120408.GL1124@E5400> <1E01C051-2EE5-4050-B826-C60E858AAC2B@flashner.co.il> Mime-Version: 1.0 Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:51809) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ia7tJ-0004JF-QL for guix-devel@gnu.org; Wed, 27 Nov 2019 19:42:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ia7nC-0001mn-6C for guix-devel@gnu.org; Wed, 27 Nov 2019 19:36:23 -0500 Received: from mx1.riseup.net ([198.252.153.129]:54366) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ia7nB-0001kl-Pm for guix-devel@gnu.org; Wed, 27 Nov 2019 19:36:22 -0500 In-Reply-To: <1E01C051-2EE5-4050-B826-C60E858AAC2B@flashner.co.il> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Efraim Flashner Cc: guix-devel@gnu.org > I'd love to see what you have so far if you want to share Okie Dokie, I posted it and cc'd ya. Also I took a look at your patches. 0001-import-crate-Don-t-include-optional-dependencies.patch should work just fine with my patch. But 0003-import-crate-Honor-versioned-dependencies-when-impor.patch will not work. I took a different route here with the naming. If you are interested take a look take a look at my second patch. (recusive-import-semver) only will add the version number to the name if the crate being imported is not the latest version. I thought this was more inline with the canonical names, but if always adding version number the export symbol is desirable it wil= l simplify things. Also I added a function (find-packages-by-name*/direct) to packages.scm which will return the export symbol of a package that already exists. I use this in case there are some non-canocal export name already added.