From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id qDO+Lon7AmBfcwAA0tVLHw (envelope-from ) for ; Sat, 16 Jan 2021 14:43:21 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id oISmKon7AmBrXgAA1q6Kng (envelope-from ) for ; Sat, 16 Jan 2021 14:43:21 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3CABB94021E for ; Sat, 16 Jan 2021 14:43:21 +0000 (UTC) Received: from localhost ([::1]:49200 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l0mnQ-0000ZF-2k for larch@yhetil.org; Sat, 16 Jan 2021 09:43:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38720) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l0mn8-0000Yx-Af for guix-patches@gnu.org; Sat, 16 Jan 2021 09:43:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:59387) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l0mn8-0007li-2y for guix-patches@gnu.org; Sat, 16 Jan 2021 09:43:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l0mn7-0004sr-W8 for guix-patches@gnu.org; Sat, 16 Jan 2021 09:43:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45889] Nextcloud Desktop (v4) Resent-From: Raghav Gururajan Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 16 Jan 2021 14:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45889 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: =?UTF-8?Q?Nicol=C3=B2?= Balzarotti , 45889@debbugs.gnu.org Received: via spool by 45889-submit@debbugs.gnu.org id=B45889.161080814118724 (code B ref 45889); Sat, 16 Jan 2021 14:43:01 +0000 Received: (at 45889) by debbugs.gnu.org; 16 Jan 2021 14:42:21 +0000 Received: from localhost ([127.0.0.1]:42700 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l0mmT-0004rw-Dg for submit@debbugs.gnu.org; Sat, 16 Jan 2021 09:42:21 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:54491) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l0mmR-0004rg-Br for 45889@debbugs.gnu.org; Sat, 16 Jan 2021 09:42:19 -0500 X-Originating-IP: 76.68.120.100 Received: from [192.168.5.10] (bras-vprn-toroon474rw-lp130-08-76-68-120-100.dsl.bell.ca [76.68.120.100]) (Authenticated sender: rg@raghavgururajan.name) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 4D6F360006; Sat, 16 Jan 2021 14:42:11 +0000 (UTC) References: <87o8hp6tu7.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> From: Raghav Gururajan Message-ID: <0ac1a1a7-825a-0737-268f-b41502db0045@raghavgururajan.name> Date: Sat, 16 Jan 2021 09:42:10 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Icedove/78.6.0 MIME-Version: 1.0 In-Reply-To: <87o8hp6tu7.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.35 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 3CABB94021E X-Spam-Score: -2.35 X-Migadu-Scanner: scn1.migadu.com X-TUID: oAxuwgIqqijW Hi Nicolò! > Why is it placed inside a new module? It should fit nicely in sync.scm Nextcloud is a big project. There will be other packages like server, plugins etc., which can then be added to this module. Concept is similar to linphone.scm. > .git shouldn't be needed Updated in v5. > This hash is wrong, I get 022k7b3c30dymrjc1g3ly2cac1c34gkqnvjya6p7w2j3qw2w1dm2 Updated in v5. > Something along the line of: > > (let ((preserved-3rdparty-files > '("QProgressIndicator" "qtlockedfile" "qtokenizer" > "qtsingleapplication" "kmessagewidget"))) > (with-directory-excursion "src/3rdparty" > (for-each > (lambda (directory) > (simple-format #t "deleting: ~A\n" directory) > (delete-file-recursively directory)) > (lset-difference string=? > (scandir ".") > (cons* "." ".." preserved-3rdparty-files)))) > #t) The snippet didn't work, but I added comments in v5. > This line is too long, you can use something like > ("PKGCONFIG_GETVAR\\(.*") instead. If I use this, it causes parsing error. > Other long line, maybe string-append. Ah, I have been advised before not to break lines like this via string-append. > Why? Added comments in v5. > It's missing a comment on why this is needed (like qttest tries to create > $HOME/.qttest/config/autostart/) >> + (license license:gpl2+))) Added comments in v5. > Unbundled dependencies have different licenses > QprogressIndicator is under expat while others lgpl2.1+ if I'm not wrong Updated in v5. > Also, I tried removing ruby and python-sphinx from the dependencies and > it did build fine, so be sure all of them are needed (or are they used > for some optional feature?). Ruby is for patch-shebangs phase. Sphinx was looked for during configure phase, but doesn't seem to do anything, so I removed it in v5. Thanks so much for the review. :-) Regards, RG.