From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id WC2zNfd1fWCVTAEAgWs5BA (envelope-from ) for ; Mon, 19 Apr 2021 14:22:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id yHyeMPd1fWA1TQAA1q6Kng (envelope-from ) for ; Mon, 19 Apr 2021 12:22:15 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8D76025AD0 for ; Mon, 19 Apr 2021 14:22:15 +0200 (CEST) Received: from localhost ([::1]:54058 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lYSus-0003UD-Pm for larch@yhetil.org; Mon, 19 Apr 2021 08:22:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59500) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYSug-0003U5-D9 for guix-patches@gnu.org; Mon, 19 Apr 2021 08:22:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:37095) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lYSug-0005kx-5E for guix-patches@gnu.org; Mon, 19 Apr 2021 08:22:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lYSug-0003Wy-18 for guix-patches@gnu.org; Mon, 19 Apr 2021 08:22:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47884] [PATCH] Add package: ibus-chewing References: In-Reply-To: Resent-From: Raghav Gururajan Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 19 Apr 2021 12:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47884 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 47884@debbugs.gnu.org Received: via spool by 47884-submit@debbugs.gnu.org id=B47884.161883488113515 (code B ref 47884); Mon, 19 Apr 2021 12:22:01 +0000 Received: (at 47884) by debbugs.gnu.org; 19 Apr 2021 12:21:21 +0000 Received: from localhost ([127.0.0.1]:48641 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYSu0-0003Vv-VH for submit@debbugs.gnu.org; Mon, 19 Apr 2021 08:21:21 -0400 Received: from out2.migadu.com ([188.165.223.204]:43912) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYStw-0003Vd-4y for 47884@debbugs.gnu.org; Mon, 19 Apr 2021 08:21:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raghavgururajan.name; s=key1; t=1618834873; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=9c0ZuxZ+Rpl1Ap/prFNxx89qtTZ/CLjNQy9+MRCeYMc=; b=ia5U7nsooQSy+ilm0MzWxA/eluETq/R9XlkuxlD1wWyemIZMIxaJKVXgEaRZT7xB6n0tqD /37H2CFREM4xOHzIyjHOj1aLMRcO3OLWrNESqmtCcKKK6rF1fR8HtCF3AXZMIp79q6dQgB NVT3gh2v4t+PkIorvYecjfvjjK1BydikkU+izui3pHKi1DJLFSPeUgb2j2c8413/PuL5B8 vWb4qbvJhSNbsjfIDdCoy5NlZs11G2pwGRCSKK++9H3JnGWhpNgjkBm1Ii5nokxlyNH4O8 PKezlxk+Zh7ceLv7bCy2zvOJOHCj48jgTNw9X6MEI3+b/ZaN5lfFbtlE0Zn6lQ== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. Message-ID: <0a063953-4699-72e5-ead5-3d9bea22f7b9@raghavgururajan.name> Date: Mon, 19 Apr 2021 08:21:11 -0400 MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ELm7E0MYPPhaDWkmqJAw9zEvWEC8NJpE5" X-Migadu-Auth-User: rg@raghavgururajan.name X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Raghav Gururajan X-ACL-Warn: , Raghav Gururajan via Guix-patches From: Raghav Gururajan via Guix-patches via X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1618834935; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=9c0ZuxZ+Rpl1Ap/prFNxx89qtTZ/CLjNQy9+MRCeYMc=; b=tqnOgdVV+T2rxNpRWz1TwdmeX5PfYyUBUFCUCD6zfNW1v97TJqn3Wd2bZuifPGQz/7zp5P X47J+rD5UQ6xBkEJCMbxnCtEYIBCrwcNO6rfquPXbAO/UCPijpySPFm7Q3DmIMp2+PHnvv 72IhCxj8AxQaqNXp58zPOCRu1kVcMtZhGF/ABaeAwgPoSQm0QZXd4o7ksFuWKXw+IC2YC2 av6lwM7F+Jmx69W9JpN8EfQXTqpd0sbKC1LlNRg2IN0Uh/goGvHYsC55Qom7tdNO6RrDm6 /9r9nOHyM9vdYAZ0etwmF/Nb4F9waPzRQ52Dxokbkg9UAkE+BsKkQBpM2YUl/w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1618834935; a=rsa-sha256; cv=none; b=Wi/FXO8JTyWPyf3eSzFR70ITQC4/2EyqHlZBAABP+QxjKpdr8O/dx6ZLeNkyxrQ8x0klkz oFcx2Q0qbWfiANQFPe5O/dJClZUJUbl7D7rLhZuNCREupHLAGOQsBK74CB9pr9ieBncCbo iV8WL+jDqXIEnW7ydZUfYoYruBxud0QCVFzK3DkDdSN7hRnMawpHRp9Y8mYyM4+CZG/sks 1qdpk7sAvkK8ufV4Pfw1LQ2S8UR+c8Aqqbj0JxxCfNxXeB7YwXzpB4Vv6m3GP7Cx+KakDn NGM0HPwVcZR9dsq+NwIicElyZeR5zJUqDH1XrOHWuw6S1APyTrm0IwqFEf8CRw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=raghavgururajan.name header.s=key1 header.b=ia5U7nso; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -5.04 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=raghavgururajan.name header.s=key1 header.b=ia5U7nso; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 8D76025AD0 X-Spam-Score: -5.04 X-Migadu-Scanner: scn0.migadu.com X-TUID: 2sDbnE6MKwIw This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ELm7E0MYPPhaDWkmqJAw9zEvWEC8NJpE5 Content-Type: multipart/mixed; boundary="J4g0RmrzhDX0ryucYDeLV4reAKsdNpXty"; protected-headers="v1" From: Raghav Gururajan To: 47884@debbugs.gnu.org Message-ID: <0a063953-4699-72e5-ead5-3d9bea22f7b9@raghavgururajan.name> Subject: Re: [PATCH] Add package: ibus-chewing --J4g0RmrzhDX0ryucYDeLV4reAKsdNpXty Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Hi Jin-Cheng! Congratulations on your first patch. \o/ You don't have to under-sell your work. I just cleaned up the pack-def=20 and fixed the glib schema error. All others are your work. :-) Also, if anyone helps you with code/snippet in #guix, you don't have to=20 use the same code/snippet. You are free to adopt them in any way you see = fit. Folks usually share a code/snippet, purely for informational purpose= s. REVIEW: [1] As Julien mentioned in #guix, it is better to make two patches, one=20 for dependency package and one for the main package. [2] Package gob appears to be a candidate for glib.scm. So its better to = move this package to glib.scm. [3] In Guix, we try to avoid bundled stuff, for better security and=20 reproducibilty. It'd be great if you package cmake-fedora separately=20 (like gob) and remove the use of `recursive? #t`, in ibus-chewing. As usual, if you have any questions, feel to free to ask around in=20 #guix. ;-) Regards, RG. --J4g0RmrzhDX0ryucYDeLV4reAKsdNpXty-- --ELm7E0MYPPhaDWkmqJAw9zEvWEC8NJpE5 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wnsEABYIACMWIQTNLV6qqYzLN9qR1rBfWBZkf4vlUQUCYH11twUDAAAAAAAKCRBfWBZkf4vlUQux AP9zrbw0PgNTWuvxTsAP5+pPU/WaDnoEdHEnzVFx1QEYiQD/Z58hWJwx/hu5E3F9sYFmI95bXHpZ nFCvawkqWutZMwA= =rkwx -----END PGP SIGNATURE----- --ELm7E0MYPPhaDWkmqJAw9zEvWEC8NJpE5--