all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#72747: tensorflow and tensorflow lite is broken
@ 2024-08-21 14:04 Enrico Schwass via Bug reports for GNU Guix
  2024-08-28 14:23 ` bug#72747: [PATCH] gnu: tensorflow-lite: Fix build Andy Tai
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Enrico Schwass via Bug reports for GNU Guix @ 2024-08-21 14:04 UTC (permalink / raw)
  To: 72747

Hello

It seems, that the current version of tensorflow-lite 2.13.1 does not build because of the flatbuffers version it depends on. Before guix updated its flatbuffers version it was doing well. 

I don‘t know if package transformations help here. Never got it right

Bye
Enno



^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#72747: [PATCH] gnu: tensorflow-lite: Fix build.
  2024-08-21 14:04 bug#72747: tensorflow and tensorflow lite is broken Enrico Schwass via Bug reports for GNU Guix
@ 2024-08-28 14:23 ` Andy Tai
  2024-08-28 14:47 ` bug#72747: [PATCH v2] " Andy Tai
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 6+ messages in thread
From: Andy Tai @ 2024-08-28 14:23 UTC (permalink / raw)
  To: 72747; +Cc: Andy Tai

* gnu/packages/machine-learning.scm (tensorflow-lite): Fix build.
[inputs]: Change flatbuffers-next to flatbuffers-23.1.

* gnu/packages/serialization.scm (flatbuffers-23.1): New variable.

Change-Id: I257c3563cb91cbf8e0f0874367aafced248ab4dc
---
 gnu/packages/machine-learning.scm |  2 +-
 gnu/packages/serialization.scm    | 15 +++++++++++++++
 2 files changed, 16 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/machine-learning.scm b/gnu/packages/machine-learning.scm
index 4c5b713cbf..fd790e4455 100644
--- a/gnu/packages/machine-learning.scm
+++ b/gnu/packages/machine-learning.scm
@@ -3487,7 +3487,7 @@ (define-public tensorflow-lite
        ("cpuinfo" ,cpuinfo)
        ("eigen" ,eigen)
        ("fp16" ,fp16)
-       ("flatbuffers" ,flatbuffers-next)
+       ("flatbuffers" ,flatbuffers-23.1)
        ("gemmlowp" ,gemmlowp)
        ("mesa-headers" ,mesa-headers)
        ("neon2sse" ,neon2sse)
diff --git a/gnu/packages/serialization.scm b/gnu/packages/serialization.scm
index 6aaf416467..c33b251b13 100644
--- a/gnu/packages/serialization.scm
+++ b/gnu/packages/serialization.scm
@@ -899,6 +899,21 @@ (define-public flatbuffers
 game development and other performance-critical applications.")
     (license license:asl2.0)))
 
+(define-public flatbuffers-23.1
+    ;; needed explicitly by tensorflow-lite 2.13.1
+  (package
+    (inherit flatbuffers)
+    (version "23.1.21")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/google/flatbuffers")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name "flatbuffers" version))
+              (sha256
+               (base32
+                "1z3a6l8g2y53i5xzraswfs2i0i3kk52zv7nzc2q3fgisbyiri3pz"))))))
+
 (define-public flatbuffers-next
   (package
     (inherit flatbuffers)

base-commit: 53396a22afc04536ddf75d8f82ad2eafa5082725
-- 
2.34.1





^ permalink raw reply related	[flat|nested] 6+ messages in thread

* bug#72747: [PATCH v2] gnu: tensorflow-lite: Fix build.
  2024-08-21 14:04 bug#72747: tensorflow and tensorflow lite is broken Enrico Schwass via Bug reports for GNU Guix
  2024-08-28 14:23 ` bug#72747: [PATCH] gnu: tensorflow-lite: Fix build Andy Tai
@ 2024-08-28 14:47 ` Andy Tai
  2024-09-01 22:24 ` [bug#72747] [PATCH v3] " Andy Tai
  2024-09-03 10:16 ` [bug#72747] " Enrico Schwass via Guix-patches via
  3 siblings, 0 replies; 6+ messages in thread
From: Andy Tai @ 2024-08-28 14:47 UTC (permalink / raw)
  To: 72747; +Cc: Andy Tai

* gnu/packages/machine-learning.scm (tensorflow-lite): Fix build.
[inputs]: Change flatbuffers-next to flatbuffers-23.1.

* gnu/packages/serialization.scm (flatbuffers-23.1): New variable.

Change-Id: I257c3563cb91cbf8e0f0874367aafced248ab4dc
---
 gnu/packages/machine-learning.scm |  2 +-
 gnu/packages/serialization.scm    | 19 +++++++++++++++++++
 2 files changed, 20 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/machine-learning.scm b/gnu/packages/machine-learning.scm
index 4c5b713cbf..fd790e4455 100644
--- a/gnu/packages/machine-learning.scm
+++ b/gnu/packages/machine-learning.scm
@@ -3487,7 +3487,7 @@ (define-public tensorflow-lite
        ("cpuinfo" ,cpuinfo)
        ("eigen" ,eigen)
        ("fp16" ,fp16)
-       ("flatbuffers" ,flatbuffers-next)
+       ("flatbuffers" ,flatbuffers-23.1)
        ("gemmlowp" ,gemmlowp)
        ("mesa-headers" ,mesa-headers)
        ("neon2sse" ,neon2sse)
diff --git a/gnu/packages/serialization.scm b/gnu/packages/serialization.scm
index 6aaf416467..31d3ed9feb 100644
--- a/gnu/packages/serialization.scm
+++ b/gnu/packages/serialization.scm
@@ -899,6 +899,25 @@ (define-public flatbuffers
 game development and other performance-critical applications.")
     (license license:asl2.0)))
 
+(define-public flatbuffers-23.1
+    ;; needed explicitly by tensorflow-lite 2.13.1
+  (package
+    (inherit flatbuffers)
+    (version "23.1.21")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/google/flatbuffers")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name "flatbuffers" version))
+              (sha256
+               (base32
+                "1z3a6l8g2y53i5xzraswfs2i0i3kk52zv7nzc2q3fgisbyiri3pz"))))
+    (arguments
+     (substitute-keyword-arguments (package-arguments flatbuffers)
+       ((#:configure-flags flags #~'())
+        #~(append #$flags '("-DCMAKE_POSITION_INDEPENDENT_CODE=ON")))))))
+
 (define-public flatbuffers-next
   (package
     (inherit flatbuffers)

base-commit: 53396a22afc04536ddf75d8f82ad2eafa5082725
-- 
2.34.1





^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [bug#72747] [PATCH v3] gnu: tensorflow-lite: Fix build.
  2024-08-21 14:04 bug#72747: tensorflow and tensorflow lite is broken Enrico Schwass via Bug reports for GNU Guix
  2024-08-28 14:23 ` bug#72747: [PATCH] gnu: tensorflow-lite: Fix build Andy Tai
  2024-08-28 14:47 ` bug#72747: [PATCH v2] " Andy Tai
@ 2024-09-01 22:24 ` Andy Tai
  2024-09-03  9:55   ` bug#72747: tensorflow and tensorflow lite is broken Ludovic Courtès
  2024-09-03 10:16 ` [bug#72747] " Enrico Schwass via Guix-patches via
  3 siblings, 1 reply; 6+ messages in thread
From: Andy Tai @ 2024-09-01 22:24 UTC (permalink / raw)
  To: 72747; +Cc: Andy Tai

* gnu/packages/machine-learning.scm (tensorflow-lite): Fix build.
[inputs]: Change flatbuffers-next to flatbuffers-23.1.

* gnu/packages/serialization.scm (flatbuffers-23.1): New variable.

Change-Id: I257c3563cb91cbf8e0f0874367aafced248ab4dc
---
 gnu/packages/machine-learning.scm |  2 +-
 gnu/packages/serialization.scm    | 19 +++++++++++++++++++
 2 files changed, 20 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/machine-learning.scm b/gnu/packages/machine-learning.scm
index 62b9ac00e9..20c49a6422 100644
--- a/gnu/packages/machine-learning.scm
+++ b/gnu/packages/machine-learning.scm
@@ -3487,7 +3487,7 @@ (define-public tensorflow-lite
        ("cpuinfo" ,cpuinfo)
        ("eigen" ,eigen)
        ("fp16" ,fp16)
-       ("flatbuffers" ,flatbuffers-next)
+       ("flatbuffers" ,flatbuffers-23.1)
        ("gemmlowp" ,gemmlowp)
        ("mesa-headers" ,mesa-headers)
        ("neon2sse" ,neon2sse)
diff --git a/gnu/packages/serialization.scm b/gnu/packages/serialization.scm
index 6aaf416467..31d3ed9feb 100644
--- a/gnu/packages/serialization.scm
+++ b/gnu/packages/serialization.scm
@@ -899,6 +899,25 @@ (define-public flatbuffers
 game development and other performance-critical applications.")
     (license license:asl2.0)))
 
+(define-public flatbuffers-23.1
+    ;; needed explicitly by tensorflow-lite 2.13.1
+  (package
+    (inherit flatbuffers)
+    (version "23.1.21")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/google/flatbuffers")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name "flatbuffers" version))
+              (sha256
+               (base32
+                "1z3a6l8g2y53i5xzraswfs2i0i3kk52zv7nzc2q3fgisbyiri3pz"))))
+    (arguments
+     (substitute-keyword-arguments (package-arguments flatbuffers)
+       ((#:configure-flags flags #~'())
+        #~(append #$flags '("-DCMAKE_POSITION_INDEPENDENT_CODE=ON")))))))
+
 (define-public flatbuffers-next
   (package
     (inherit flatbuffers)

base-commit: 61a7930cb03f5eb9e8003bade21d61262c3db8df
-- 
2.34.1





^ permalink raw reply related	[flat|nested] 6+ messages in thread

* bug#72747: tensorflow and tensorflow lite is broken
  2024-09-01 22:24 ` [bug#72747] [PATCH v3] " Andy Tai
@ 2024-09-03  9:55   ` Ludovic Courtès
  0 siblings, 0 replies; 6+ messages in thread
From: Ludovic Courtès @ 2024-09-03  9:55 UTC (permalink / raw)
  To: Andy Tai; +Cc: 72747-done

Andy Tai <atai@atai.org> skribis:

> * gnu/packages/machine-learning.scm (tensorflow-lite): Fix build.
> [inputs]: Change flatbuffers-next to flatbuffers-23.1.
>
> * gnu/packages/serialization.scm (flatbuffers-23.1): New variable.
>
> Change-Id: I257c3563cb91cbf8e0f0874367aafced248ab4dc

Applied, thanks!




^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#72747] tensorflow and tensorflow lite is broken
  2024-08-21 14:04 bug#72747: tensorflow and tensorflow lite is broken Enrico Schwass via Bug reports for GNU Guix
                   ` (2 preceding siblings ...)
  2024-09-01 22:24 ` [bug#72747] [PATCH v3] " Andy Tai
@ 2024-09-03 10:16 ` Enrico Schwass via Guix-patches via
  3 siblings, 0 replies; 6+ messages in thread
From: Enrico Schwass via Guix-patches via @ 2024-09-03 10:16 UTC (permalink / raw)
  To: 72747

Hello

Thank you Andy and Ludovic for creating the patch and for applying it. 

The same patch would work for the full tensorflow package, provided by the guix-science channel. *nudge nudge*. 

I am not sure if there is an ML team for Guix, but if not - regarding the hotness of the topic - it would be nice to have one. I can provide simpler packages and test on M1, x86 and if I finally set it up on honeycomb. 

Thank you again
Enno



^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2024-09-03 14:14 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-21 14:04 bug#72747: tensorflow and tensorflow lite is broken Enrico Schwass via Bug reports for GNU Guix
2024-08-28 14:23 ` bug#72747: [PATCH] gnu: tensorflow-lite: Fix build Andy Tai
2024-08-28 14:47 ` bug#72747: [PATCH v2] " Andy Tai
2024-09-01 22:24 ` [bug#72747] [PATCH v3] " Andy Tai
2024-09-03  9:55   ` bug#72747: tensorflow and tensorflow lite is broken Ludovic Courtès
2024-09-03 10:16 ` [bug#72747] " Enrico Schwass via Guix-patches via

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.