From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 4Iw1Og25RmLbXQEAgWs5BA (envelope-from ) for ; Fri, 01 Apr 2022 10:34:21 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id mCfINg25RmK+jAAAauVa8A (envelope-from ) for ; Fri, 01 Apr 2022 10:34:21 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8F945286E6 for ; Fri, 1 Apr 2022 10:34:21 +0200 (CEST) Received: from localhost ([::1]:36020 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1naCjc-0006de-5y for larch@yhetil.org; Fri, 01 Apr 2022 04:34:20 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49384) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1naCh1-0003oH-GO for guix-devel@gnu.org; Fri, 01 Apr 2022 04:31:44 -0400 Received: from libre.brussels ([144.76.234.112]:60632) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1naCgx-00008w-0o for guix-devel@gnu.org; Fri, 01 Apr 2022 04:31:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=libre.brussels; s=mail; t=1648801890; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iNDQcUo1Dlv7yNfkVAKlAM8TNXv16sLO7bluYmxdU2U=; b=Xbg05cSypo6s6fPjhnfE9LvAN1rtgZsXdaggbQZa1EAT6O2DX9sisliLo13dHhs5Pg0YKG I6B/gZMcZgdhMXNax/DAyTYN2qzdS8k01LBaXEHZswTIBQEM5iaB/lu7CmEiWPcrJOmDZb 8vMvOKJgfrHLIEPR0xyMFwu3uQA2YGA= MIME-Version: 1.0 Date: Fri, 01 Apr 2022 08:31:30 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: "Jonathan McHugh" Message-ID: <09dd04b49b66448a9ee32bdbef3f1495@libre.brussels> Subject: Re: New review checklist To: "Liliana Marie Prikler" , guix-devel@gnu.org In-Reply-To: <0912e3091c2bc34866f2795ec4f0413fc0928bdc.camel@gmail.com> References: <0912e3091c2bc34866f2795ec4f0413fc0928bdc.camel@gmail.com> Received-SPF: pass client-ip=144.76.234.112; envelope-from=indieterminacy@libre.brussels; helo=libre.brussels X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1648802061; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=iNDQcUo1Dlv7yNfkVAKlAM8TNXv16sLO7bluYmxdU2U=; b=e3Zg/FR8e/5GoEyisRBf9Tv488aH4whWiHFUruDsLofZOsdnsy71PnxgIh7j8kgQ+85soh x2I0lHVRhDg6ahpAaxyTC5gFuO+XGzj6n91KU//DNHr4+Ku94/qPkzVfksUWnyRyibZSw3 heSJ8lhlotej6EY72flBvX+95ea/9PCVzdXiI7pMDL9PZmLDDKN8vNYgFRtWSFEF7VjqZV 6DxFj61pZ2IW0uEQT9CD/KsngAx620ie7ByoeT0KS4iPMVHEVznrdnvX0vXXBWk3iE/eFk kY9TicbA6SmXE2MtSOVUbjgIQ3BHLn430497mQtWs1udlWyJJX5tVOdlB2FiAA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1648802061; a=rsa-sha256; cv=none; b=SvzLpY7uUOCa3lItZMwCpTPZdE/N0U06NO98JIK9YvCKy7mL4CyUtzXkJOsVI9+XMJ243C y7KKja9SBg8bi+7r13BkurCmzjsmcHUX/ZmwPeB7BzMJrlbGU7P9WHS0w6EhuTf0YEZJkF rfZo8sQ9wR/yW6lqgxpl2Y0s8VxfWcyPNQZyvYdpEAYoU9peWwZn9ZoMF04/fTmsDFSeUZ grp39nOLHyr+m0mx9NbWtXLxMjs3ojm89+FmGXR0SCLjWofkQmGs/Z4cch6kmiEzc9fYK1 aAtyAWKv3ArqpYZ+N6URYyJiLfXHQEbmvb8OC44sm+nBiHOby4nnGspLa2RG0Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=libre.brussels header.s=mail header.b=Xbg05cSy; dmarc=pass (policy=none) header.from=libre.brussels; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.07 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=libre.brussels header.s=mail header.b=Xbg05cSy; dmarc=pass (policy=none) header.from=libre.brussels; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 8F945286E6 X-Spam-Score: -4.07 X-Migadu-Scanner: scn0.migadu.com X-TUID: PWW2KVhzw4/z There is no reference to XML. Nor does it provide any interopabilietie wi= th SOAP. Please stop wasting the mailinglists time with this non XML based hokum, = this is Guxi.FFSaek. :) =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D Jonathan McHugh indieterminacy@libre.brussels April 1, 2022 6:15 AM, "Liliana Marie Prikler" wrote: > Dear reviewer, >=20 >=20in the sequel find the new review checklist, effective immediately.= =20 >=20Failure to apply it will result in the confiscation of your machine f= or > the purpose of making it usable for continuous integration. >=20 >=20Happy April Fools >=20 >=20----- >=20 >=20So you want to package a > [ ] C [ ] C++ [ ] C# [ ] Common Lisp [ ] Emacs Lisp [ ] Fortran > [ ] Guile [ ] Haskell [ ] Java [ ] Javascript [ ] Julia [ ] Nim > [ ] OCaml [ ] Python [ ] R [ ] Rust [ ] V [ ] Zig [ ] ________ > application/library/________. > It won't be added to Guix. Here's why it won't. >=20 >=20You appear to believe that > [ ] linter warnings can easily be ignored > [ ] `make check' does not need to succeed > [ ] nobody will ever want to build your package on > [ ] x86_64 [ ] i686 [ ] aarch64 [ ] armhf [ ] mips____ > [ ] powerpc____ [ ] riscv__ [ ] ______-mingw32 [ ] the Hurd > [ ] commit hashes make for good version numbers > [ ] hard-coding the commit field is a good idea > [ ] using trivial-build system is a good idea > [ ] we hard-code > [ ] invocations of command line tools > [ ] shared libraries > [ ] _________ > for fun > [ ] updating ______ to add your package does not cause a world rebuild > [ ] committers have nothing better to do than trailing a branch that > receives _____ commits per day. >=20 >=20Sadly your patch has/lacks > [ ] copyright headers > [ ] changes in other parts of the file > [ ] indentation > [ ] speling misstakes > [ ] new-style inputs > [ ] propagated inputs > [ ] a useful synopsis > [ ] a meaningful description > [ ] a valid home-page > [ ] correct licensing information > [ ] significant improvements over the three other patches adding this= =20=20 >=20package, which themselves are stuck in review hell >=20 >=20The following technophilosophical objections also apply: > [ ] the GNU FSDG prohibit _____________________________ > [ ] your package bundles a meaningless copy of > [ ] ffmpeg > [ ] v8 > [ ] font-awesome > [ ] bundler > [ ] rustc > [ ] ________ > [ ] your package bootstraps itself using a sparse autoencoder trained > on /dev/urandom > [ ] your package is not reproducible thanks to > [ ] embedded timestamps > [ ] CPU feature detection during configure/compile time > [ ] a flaky test suite > [ ] an evil hack to call rand() inside a constexpr context > [ ] Guix should not have to carry every fork of suckmore tools >=20 >=20In conclusion, this is what I think of you: > [ ] Your patch looks good, but I'm not going to push it. > [ ] Your patch would need some work, and I'm not going to invest that > time on your behalf. > [ ] Your patch is bad and you should feel bad for submitting it. > [ ] Maintaining this package in your own channel is an adequate > punishment for writing it.