From: Maxime Devos <maximedevos@telenet.be>
To: "Ludovic Courtès" <ludo@gnu.org>, 48224@debbugs.gnu.org
Subject: [bug#48224] [PATCH 2/2] gnu: guix: Phases refer to #:system and #:target.
Date: Tue, 04 May 2021 21:21:24 +0200 [thread overview]
Message-ID: <09cee506693a26af13b7fbc318f7a09528161bbc.camel@telenet.be> (raw)
In-Reply-To: <20210504133958.11011-2-ludo@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1778 bytes --]
> The second patch is stylistic: it avoids missing phases, which I
> find more readable.
I don't see any missing phases. (I read this as ‘The second patch is
stylistic: it avoids making the existence of a phase dependent on
%current-target-system.’)
> - (guile ,@(if (%current-target-system)
> - '((assoc-ref native-inputs "guile"))
> - '((assoc-ref inputs "guile"))))
> + (guile (if target
> + (assoc-ref native-inputs "guile")
> + (assoc-ref inputs "guile")))
Something I tend to do is
(assoc-ref (or native-inputs inputs) "guile")
Do you have any particular preference?
> (deps (list gcrypt json sqlite gnutls git
> bs ssh zlib lzlib zstd guile-lib))
> - (deps* ,@(if (%current-target-system)
> - '(deps)
> - '((cons avahi deps))))
> + (deps* (if target deps (cons avahi deps)))
Why not simply
;; avahi is #f (not in 'inputs') when cross-compiling.
;; Remove it.
(deps* (delete #f avahi))
? Then, when guile-avahi becomes cross-compilable at some point, we only
need to adjust 'propagated-inputs' and not anything else.
Also, was this code (deps* ,@(if (%current-target-system) '(deps) ...)) needed in
the first place? guile2.2-guix inherits its phases from guix, and guile2.2-guix does
not have a guile-zlib or guile-lzlib input.
Greetings,
Maxime.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
next prev parent reply other threads:[~2021-05-04 19:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 13:25 [bug#48224] [PATCH 0/2] Avoid Bash wrapper in 'guix' package Ludovic Courtès
2021-05-04 13:39 ` [bug#48224] [PATCH 1/2] gnu: guix: Avoid Bash wrapper Ludovic Courtès
2021-05-04 13:39 ` [bug#48224] [PATCH 2/2] gnu: guix: Phases refer to #:system and #:target Ludovic Courtès
2021-05-04 19:21 ` Maxime Devos [this message]
2021-05-04 23:05 ` [bug#48224] [PATCH 0/2] Avoid Bash wrapper in 'guix' package Ludovic Courtès
2021-05-04 23:26 ` Vagrant Cascadian
2021-05-09 21:56 ` Ludovic Courtès
2021-05-13 3:45 ` Vagrant Cascadian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09cee506693a26af13b7fbc318f7a09528161bbc.camel@telenet.be \
--to=maximedevos@telenet.be \
--cc=48224@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.