From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id kAnSJegYvmHZegAAgWs5BA (envelope-from ) for ; Sat, 18 Dec 2021 18:22:48 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id GBduIegYvmEdIgAAbx9fmQ (envelope-from ) for ; Sat, 18 Dec 2021 17:22:48 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 079C5DE97 for ; Sat, 18 Dec 2021 18:22:48 +0100 (CET) Received: from localhost ([::1]:55690 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mydPz-00074g-02 for larch@yhetil.org; Sat, 18 Dec 2021 12:22:47 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40650) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mydPW-0006i7-5c for guix-patches@gnu.org; Sat, 18 Dec 2021 12:22:18 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:60427) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mydPG-00054a-Un for guix-patches@gnu.org; Sat, 18 Dec 2021 12:22:17 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mydPG-0005Sf-RM for guix-patches@gnu.org; Sat, 18 Dec 2021 12:22:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#52578] [PATCH] updating openldap and adding service definition Resent-From: Jean-Francois GUILLAUME Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 18 Dec 2021 17:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52578 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 52578 <52578@debbugs.gnu.org> Received: via spool by 52578-submit@debbugs.gnu.org id=B52578.163984809320933 (code B ref 52578); Sat, 18 Dec 2021 17:22:02 +0000 Received: (at 52578) by debbugs.gnu.org; 18 Dec 2021 17:21:33 +0000 Received: from localhost ([127.0.0.1]:43733 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mydOm-0005RS-VH for submit@debbugs.gnu.org; Sat, 18 Dec 2021 12:21:33 -0500 Received: from smtp1.univ-nantes.fr ([193.52.82.18]:38736 helo=smtp-prv.univ-nantes.fr) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myXHa-00059K-94 for 52578@debbugs.gnu.org; Sat, 18 Dec 2021 05:49:43 -0500 Received: from localhost (localhost [127.0.0.1]) by smtp-prv.univ-nantes.fr (Postfix) with ESMTP id 19217734D8 for <52578@debbugs.gnu.org>; Sat, 18 Dec 2021 11:49:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=univ-nantes.fr; s=mailv2; t=1639824581; bh=xdlFwznEMXuvDDSSG51btOUJo2C28dYlYf2Ug0rDofQ=; h=Date:From:To:Subject:In-Reply-To:References:From; b=D6Nekz3Xeek8+BQ3PPt8L6+KkD//mfcUBHv53geHGDU/Vp78+sQVDRO5FBgyez5Uv YJ2WS3TGlkNoJ7ITx+b472WQT6nR5+KDvDeR2KhEeoZVTNtcFWI/8wDbnSK4TulVLB 1Yu9HoDrIKnjRjehDJvEh41W2nOix+E1GYQTORHlSgemNSxq2lPcqsJMne6I3OUevR g+XtSCjMr8cp3njAphiJsF7efR/EkQ2nK0fGh9atNWoYe9rCOvDnancqe0FJPD7WBU bDsHs8zRtlNSy5HAAlpSf+Slby2HGUbpP5epyoU07h4Ad6t3Xp3KD3mBs/ATtQCwh9 vZOjAAfClmdGg== X-Virus-Scanned: Debian amavisd-new at smtp2 Received: from smtp-prv.univ-nantes.fr ([127.0.0.1]) by localhost (smtp1.u12.univ-nantes.prive [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 40R2oOyiU6g4 for <52578@debbugs.gnu.org>; Sat, 18 Dec 2021 11:49:41 +0100 (CET) Received: from webmail.univ-nantes.fr (webmail1-loi.cprv.univ-nantes.prive [172.26.0.62]) by smtp-prv.univ-nantes.fr (Postfix) with ESMTP id EAF1B33F37 for <52578@debbugs.gnu.org>; Sat, 18 Dec 2021 11:49:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=univ-nantes.fr; s=mailv2; t=1639824580; bh=xdlFwznEMXuvDDSSG51btOUJo2C28dYlYf2Ug0rDofQ=; h=Date:From:To:Subject:In-Reply-To:References:From; b=lt+91w4xuER4NkR5JYL/zAsnwbB1hp6pXZLSEZ3+4xzP9HQKnVf2DnWYrFJXJ8p2R xlVl0i+Oi31wFHCPXiyqYh2gE0dQ2yDA50s9E02tvUXUUW/81q2i7qeEYXamyuu70C /CTXgZWVyiCJPFxrdLozxtDHRVyVzn0y5noQBm9w1vYozHux6l58IzEZ8l57T6L0iH IWDm9ybPoaocKixV4cL6GUe8JXz7n8xVZ71Y99sb4+1ZdUIBDT2rJxrn1zwkkxSN/h kkhlwa67V5++nBkmtBVJixUA94FSF4R+mLG4mY+SWP9xKGagGdjlpcSDnUYtX0buh6 Pxtkp7umQ/mlQ== MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Date: Sat, 18 Dec 2021 11:49:40 +0100 From: Jean-Francois GUILLAUME Organization: UFR MEDECINE/FED 4203 SFR SANTE In-Reply-To: <272054126ba496f811756b19fc5e77fa@imap.univ-nantes.prive> References: <272054126ba496f811756b19fc5e77fa@imap.univ-nantes.prive> Message-ID: <08c0697fe0be36391d845c521315355e@imap.univ-nantes.prive> X-Sender: Jean-Francois.Guillaume@univ-nantes.fr User-Agent: Roundcube Webmail/1.1.2 X-Mailman-Approved-At: Sat, 18 Dec 2021 12:21:31 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1639848168; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=xdlFwznEMXuvDDSSG51btOUJo2C28dYlYf2Ug0rDofQ=; b=Y0BMJmeFBe5YRS97zbLlotmpjcfsS9DndUFba5XOYL/SFwYApLPxNoS2Z74iSpvOZEN0t1 XP0SXE4MEJp8tRyt4Ai4vg75TzDSYU5IgQ6bvhhCosujXTSUulU8pm27UeeabIzI+fCOkv pYC+TFMgvkZfNdQrTGefBwg6CW2GO7sTLjjsnzVVakqbC3ReUWRCL47tBPmpL3RLQD+Nof +V/W2EnUfg6RgODMVvrJSYjQxvzzrVMvYxV2VBEsC5WZN3slYJE1sZK+s/i6HI9hxeAUt2 pFswv0McS7jeX0Q9xOSDaqhYta2vcjH3plf2Kb2OtmqCwF0w4d+UU+nMZ9d56g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1639848168; a=rsa-sha256; cv=none; b=MuEhypdzDwRjXxN3ngIGvH25x2YM0iuZZn6ErRYfZaVuQbJemwmaXqKElUGPR6OkOLDHXD SH3HlJo7o7bWUrLODcN1kz4AR3qNXUUqQHbV7U4/UczqhfDeiLZUEPtdwOQFTcXHGkvqle WrpZBgg5gPyoLB+lCG9nIPwKXP4/ynUVwtSzN785+4T/bCt+GC1C7QReCVO2h2pYfSsbty hfbUucgTcGGdoGkY6NmSKJSsBp78i+aekQNeG04HBOwvHPJN8rtxGN71FiaNrOPv+K5DoL CZU2vf2Y5/nZhWjfR1y0pZjYqCAltjSg/U4gT8XeNVSsxeaIMgkqfgf8SyqdsA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=univ-nantes.fr header.s=mailv2 header.b=D6Nekz3X; dkim=fail ("headers rsa verify failed") header.d=univ-nantes.fr header.s=mailv2 header.b=lt+91w4x; dmarc=fail reason="SPF not aligned (relaxed)" header.from=univ-nantes.fr (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.21 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=univ-nantes.fr header.s=mailv2 header.b=D6Nekz3X; dkim=fail ("headers rsa verify failed") header.d=univ-nantes.fr header.s=mailv2 header.b=lt+91w4x; dmarc=fail reason="SPF not aligned (relaxed)" header.from=univ-nantes.fr (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 079C5DE97 X-Spam-Score: -3.21 X-Migadu-Scanner: scn0.migadu.com X-TUID: SowXdmgPiisD Hi Maxime, > A single "--disable-static" should be suficient. Indeed, copy-paste from our local repository went wrong. > is this speculation on what's necessary for cross-compilation, or has=20 > it been determined these flags are necessary? These were necessary with the old autoconf in <=3D 2.5 realeases. It's=20 mostly a leftover from the older definition already in guix. > Why? Stripping was sometime leading to crash of the build on my side. > This is the default, no need to mention it. True, leftover from when i needed the build to be monothread to see=20 where it failed. > You can use ,(cc-for-target) here. Also, CC can be set in #:make-flags. Ok, i will look into it. > That's a very terse description --- is it a server, a client=20 > application, programming APIs for communicating with a server, or all=20 > of these? Also, no need to mention it's free, everything in Guix is=20 > free. I'll be honest, it's a copy-paste from the already defined package. I'll=20 update it to be more meaningfull. > What's the reason for defining multiple versions of openldap? Usually,=20 > it is only necessary to keep the latest version of a package (with some= =20 > rare exceptions). This is mostly another case of copy-paste from our local repository went=20 wrong. > A copyright + license header is missing, and this file needs to be=20 > added to Makefile.am (or local.mk, I'm not sure about the details). Ok, i will look into it. > This seems unlikely to compile, what's the space doing here? Well, we use this in our local guix infrastructure and it doesn't=20 complain, nor does our building of ldap server vms with guix system=20 build. > Something I'm missing here, is some documentation. As it is, this=20 > openldap service isn't documented anywhere, so nobody would figure out=20 > it even exists, unless they search in the source code. True, forgot about this, my bad. Could you please point me to an example=20 ? > As-is, this service would be run as root, which is very suboptimal from= =20 > a security perspective. Consider running it as a separate user & group,= =20 > and if feasible in a container (the latter is optional but would be=20 > great). True, i'll try to get it work with it's own user and group. > I don't see the point in making this customisable. Why would anyone=20 > want to change the log locations or location of the pid file? Unless=20 > there's some compelling reason otherwise, I'd prefer to keep complexity= =20 > down by not making this configurable. This allow us to run multiple instance of this service on the same=20 machine (granted you also change the storage directory slapd.conf). > Allowing writing the configuration with configuration records would be=20 > preferred (with an 'extra-content'-style escape hatch, because it would= =20 > probably be infeasible to support every single configuration option of=20 > openldap, but some basic options like =E2=80=98which network port to bind= =20 > to=E2=80=99 should be configurable in Scheme). Well this is beyond my current abilities. > This service probably requires a network interface, so loopback might=20 > be required. Also, why is user-processes included? I know many services= =20 > include it, but it doesn't appear to be documented anywhere when=20 > user-processes must be added to 'requirement'. True. From my understanding, when you reach user-processes you're in the=20 late stage of booting your system and everything network-wise should be=20 available. > These parentheses are lonely, consider moving the parenthese to right=20 > after openldap-service-type, to keep the style consistent in Guix. Leftovers from our local repo, we rely a bit to much on indentation to=20 help us have a better view of where blocks start and stop. > What do you mean with =E2=80=98does not work inside guix=E2=80=99? For some strange reasons, when the tests are run by guix build they do=20 not properly clean after each steps and ends up failing. If you do the=20 same inside a guix environment test work properly. And i think some=20 tests need some kinds of network connection but that could be on another=20 package. Sorry for the messy patch. Best, --- Cordialement, Jean-Fran=C3=A7ois GUILLAUME Plateforme Bioinformatique BiRD T=C3=A9l. : +33 (0)2 28 08 00 57 www.pf-bird.univ-nantes.fr Inserm UMR 1087/CNRS UMR 6291 IRS-UN - 8 quai Moncousu - BP 70721 44007 Nantes Cedex 1