From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 4AkTKytS2mRPZQAASxT56A (envelope-from ) for ; Mon, 14 Aug 2023 18:11:23 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id sDD5KitS2mSnpAAA9RJhRA (envelope-from ) for ; Mon, 14 Aug 2023 18:11:23 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 13AFB3F6E2 for ; Mon, 14 Aug 2023 18:11:23 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1692029483; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=L3E/1HB0qtSnZomvpRi/MSeFaLDiH15qiJ1inHCOyT8=; b=bT4avtuupP5JxIAtmQ5NQWijYMfKAckETiW+XCSVeKzstEsmdQt98qLKbQ/hwGc7xdhi1V OHMnQkQSc+Hs3C65Jg8SbFi7pLMjsBHYVZv8ZdTLsDnqldqiOOFuGu6KmkPjfXrZjY6tUE L/lduAAzr7k8bQHznt9VlwiETf+GRllE/QUoeRr05gR6uieg1DZiNXdK4ua/xUzTbBiPi8 NBdG17fmH7AINq/ODmsGFS7Wb26RYRcI7szQCzd8ZH55DQ8GPaj7oh1gvDBP5C/Fq4RaAK ZE7sQxaCH+hhOsL2iHoUL8NZOCv9Q8Xz84JOpljqBlLHhdmto6HMgRa9TlJaQQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1692029483; a=rsa-sha256; cv=none; b=ZSl0DQ1cenm/ozcPNahb0ljc0EgGfU02o/ovvKdn0xTNAUFyBFwX/dBES5cto+UWPY3NQF TAa/SXSpfw+9jdIsDhhwruo8d1KkSCgAcoMUlwp9HYWdxdkeoBtXjQyw9G3phqZk4CvTWr FCLDAGc2tRgkbCFFn3vp+9GFOlbRdgCfpZFFe+egcf6+wgRa2Zr9CsaApANBHf8qj6tsFR feZcrelOYYLl2cofw0tcP6ps7bokmcZ8lozEUEHruN/ZwVdQv9YqcwI7dzABHG9Qc7HjWS Y1PuYBibM1D1XgkIW5NVqLNS78pWgS8etFH6mV5kEprJSSEABNOmlm/ujX7Tsw== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qVa9w-0007TX-Mx; Mon, 14 Aug 2023 12:11:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qVa9o-0007T5-6k for guix-patches@gnu.org; Mon, 14 Aug 2023 12:11:06 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qVa9m-0007ca-Jl for guix-patches@gnu.org; Mon, 14 Aug 2023 12:11:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qVa9m-0003vy-FB for guix-patches@gnu.org; Mon, 14 Aug 2023 12:11:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#64504] [PATCH] gnu: Add unsio. Resent-From: Iliya Tikhonenko Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 14 Aug 2023 16:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64504 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Andreas Enge Cc: 64504@debbugs.gnu.org, Sharlatan Hellseher , Efraim Flashner , Eric Bavier Received: via spool by 64504-submit@debbugs.gnu.org id=B64504.169202944115071 (code B ref 64504); Mon, 14 Aug 2023 16:11:02 +0000 Received: (at 64504) by debbugs.gnu.org; 14 Aug 2023 16:10:41 +0000 Received: from localhost ([127.0.0.1]:34231 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qVa9P-0003ux-Mk for submit@debbugs.gnu.org; Mon, 14 Aug 2023 12:10:40 -0400 Received: from mpemail.mpe.mpg.de ([130.183.137.111]:51348 helo=mail.mpe.mpg.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qVWt2-00022y-9U for 64504@debbugs.gnu.org; Mon, 14 Aug 2023 08:41:33 -0400 Received: from [89.246.96.65] (helo=[192.168.178.187]) by mail.mpe.mpg.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qVWst-0006mS-3s; Mon, 14 Aug 2023 14:41:23 +0200 Message-ID: <07cba047-bd5a-f7fe-2bdf-a0b8c9781456@mpe.mpg.de> Date: Mon, 14 Aug 2023 14:41:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 From: Iliya Tikhonenko References: <521af611d0794672c19a4899e42eb5e448ab1c1f.1688681498.git.sharlatanus@gmail.com> <138b0fbd-ca5b-17ac-9c18-4d657737d4c0@mpe.mpg.de> Content-Language: en-US, ru In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated-Id: tikhonenko X-Mailman-Approved-At: Mon, 14 Aug 2023 12:10:38 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -6.38 X-Spam-Score: -6.38 X-Migadu-Queue-Id: 13AFB3F6E2 X-Migadu-Scanner: mx2.migadu.com X-TUID: 5BG2C3TSr3GG On 8/8/23 17:49, Andreas Enge wrote: > Am Tue, Aug 08, 2023 at 01:37:14PM +0200 schrieb Iliya Tikhonenko: >> On 8/8/23 11:29, Andreas Enge wrote: >> The debug build type is unnecessary verbose (see src/uns.cc line 71-73 for >> an example) to the point that it impacts performance sometimes, which is >> important considering the usecase of the library. > Okay, I have reinstated your line and added a comment.Fine, maybe "to disable debug printing" would sound slightly more clear, but I am not sure. >> Checked again, I still cannot compile it without -DCMAKE_CXX_STANDARD=14 > I can... Patch attached. Yeah, it builds now. > #:configure-flags #~(list "-DCMAKE_CXX_STANDARD=20") > passes without these warnings. Should we add this? > Although such constructs look a bit brittle to me, and it is not suggested by the author. > > There is still the question about the lib64/ installation directory, > I think this should be changed. I think I am fine with both changes. I did a few quick tests and have not noticed any issues. All the best, Iliya