From: Iliya Tikhonenko <tikhonenko@mpe.mpg.de>
To: Andreas Enge <andreas@enge.fr>
Cc: 64504@debbugs.gnu.org,
Sharlatan Hellseher <sharlatanus@gmail.com>,
Efraim Flashner <efraim@flashner.co.il>,
Eric Bavier <bavier@posteo.net>
Subject: [bug#64504] [PATCH] gnu: Add unsio.
Date: Mon, 14 Aug 2023 14:41:55 +0200 [thread overview]
Message-ID: <07cba047-bd5a-f7fe-2bdf-a0b8c9781456@mpe.mpg.de> (raw)
In-Reply-To: <ZNJkHrqckbCOdt7J@jurong>
On 8/8/23 17:49, Andreas Enge wrote:
> Am Tue, Aug 08, 2023 at 01:37:14PM +0200 schrieb Iliya Tikhonenko:
>> On 8/8/23 11:29, Andreas Enge wrote:
>> The debug build type is unnecessary verbose (see src/uns.cc line 71-73 for
>> an example) to the point that it impacts performance sometimes, which is
>> important considering the usecase of the library.
> Okay, I have reinstated your line and added a comment.Fine, maybe "to disable debug printing" would sound slightly more clear,
but I am not sure.
>> Checked again, I still cannot compile it without -DCMAKE_CXX_STANDARD=14
> I can... Patch attached.
Yeah, it builds now.
> #:configure-flags #~(list "-DCMAKE_CXX_STANDARD=20")
> passes without these warnings. Should we add this?
> Although such constructs look a bit brittle to me, and it is not suggested by the author.
>
> There is still the question about the lib64/ installation directory,
> I think this should be changed.
I think I am fine with both changes. I did a few quick tests and have
not noticed any issues.
All the best,
Iliya
next prev parent reply other threads:[~2023-08-14 16:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-06 22:13 [bug#64504] [PATCH] gnu: Add unsio Sharlatan Hellseher
2023-08-08 9:29 ` Andreas Enge
2023-08-08 11:37 ` Iliya Tikhonenko
2023-08-08 15:49 ` Andreas Enge
2023-08-14 12:41 ` Iliya Tikhonenko [this message]
2023-08-17 18:10 ` bug#64504: " Andreas Enge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07cba047-bd5a-f7fe-2bdf-a0b8c9781456@mpe.mpg.de \
--to=tikhonenko@mpe.mpg.de \
--cc=64504@debbugs.gnu.org \
--cc=andreas@enge.fr \
--cc=bavier@posteo.net \
--cc=efraim@flashner.co.il \
--cc=sharlatanus@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.