From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id wPyfKqrY32E32gAAgWs5BA (envelope-from ) for ; Thu, 13 Jan 2022 08:45:46 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id wPQKKKrY32E0BwEA9RJhRA (envelope-from ) for ; Thu, 13 Jan 2022 08:45:46 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 131FE405CC for ; Thu, 13 Jan 2022 08:45:46 +0100 (CET) Received: from localhost ([::1]:49204 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n7unf-0008No-Fn for larch@yhetil.org; Thu, 13 Jan 2022 02:45:37 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40138) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7ueR-0003Q6-II for guix-patches@gnu.org; Thu, 13 Jan 2022 02:36:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:38830) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n7ueQ-0006b6-2z for guix-patches@gnu.org; Thu, 13 Jan 2022 02:36:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n7ueP-0004CP-PJ for guix-patches@gnu.org; Thu, 13 Jan 2022 02:36:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53222] [PATCH] gnu: Add autokey. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 13 Jan 2022 07:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53222 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: John Kehayias , Nicolas Goaziou Cc: 53222@debbugs.gnu.org Received: via spool by 53222-submit@debbugs.gnu.org id=B53222.164205930316049 (code B ref 53222); Thu, 13 Jan 2022 07:36:01 +0000 Received: (at 53222) by debbugs.gnu.org; 13 Jan 2022 07:35:03 +0000 Received: from localhost ([127.0.0.1]:59966 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7udS-0004Ab-20 for submit@debbugs.gnu.org; Thu, 13 Jan 2022 02:35:02 -0500 Received: from baptiste.telenet-ops.be ([195.130.132.51]:39516) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7udO-0004AF-U3 for 53222@debbugs.gnu.org; Thu, 13 Jan 2022 02:35:01 -0500 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by baptiste.telenet-ops.be with bizsmtp id i7aw260054UW6Th017aw0m; Thu, 13 Jan 2022 08:34:57 +0100 Message-ID: <05d3e53be7eb53cf7d015e0fdf422c219fcabdb2.camel@telenet.be> From: Maxime Devos Date: Thu, 13 Jan 2022 08:34:51 +0100 In-Reply-To: <7vJ_B5FCWyHFJBMr1a2ubM4eF1T74OW0DGXi6Fwh4bqc_fyAq2wTdtHJ0H9LwFS1pom9o6CsUskqDW5QHRA3fcXUMVNY2W8umzWYZojFbAU=@protonmail.com> References: <684980f3b278c0953766b7108dfd6401bd890af2.camel@telenet.be> <7vJ_B5FCWyHFJBMr1a2ubM4eF1T74OW0DGXi6Fwh4bqc_fyAq2wTdtHJ0H9LwFS1pom9o6CsUskqDW5QHRA3fcXUMVNY2W8umzWYZojFbAU=@protonmail.com> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-WumCBHHqxQgK1ICKtZol" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1642059297; bh=SsCVkJ6GBh8f2WAi9eUTsEMTgsSAM8GJo4Ayzw3Lx6k=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=G6hZ92GL9MCgw+thqzTLDfMi7mHz3IMYgfJoyUkOnD69oD37YqIz+FIivPAg8Ao79 wCv0t3DzKRAaRnAWqHsZvJk8HK+oYoBgCaefYlYcshbsHXAONBsxbewGxqwPGQwijN 4rrCzemtiQ+ttR+k7KdGzKs3nobe6L0YvWufYmd7TcAAjPqn8FwINf/ktmkGN53213 qp7n52sso3t1Xcz4liLvda2bIcfXSNZlqpoeDsnUDP8FN81XilifgdfsFz8OQM5iGs 9gAT0xhca2NEiEILMmr8Ns9U1+HA5SITb35Te1gLKKunc+gjpgZVyxbdpz1dtvofUC COXKHNV1reuEw== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1642059946; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=SsCVkJ6GBh8f2WAi9eUTsEMTgsSAM8GJo4Ayzw3Lx6k=; b=BdCUu5xuHLIQWK8kUC9dRPecbgDWJhFCFaHlNzBtBi3oO9JFVzN8MV1Qsk33MiLpfnJAna ReRBYipwJbPPC7UIFxoGqpBSartHT/oJKSWORLa5Qq5DufNmJaiybLmj7eEK3x3oax4Oim gakUkGiB4uu0MXFu7WkMTQ/h8KiU2exyws8mx2dqtPx7IMriXTFneeEKuIZPt9IUjFnsqH ZRvRtpfzurZLVKeCeWOQHZr3ub7BCGWeSiWj32xZLNUOvDErQFE4nv5i7s0LwxwY1fw7BM TShFHZQ4Z9hlCIzMfIQkV95SrZOssRITpFcg9z+QA53HfMyUWW5GMnsJgFgv+Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1642059946; a=rsa-sha256; cv=none; b=i5faDhp0YO0OBzWai9Ef7ygVpSXtC7Wd5lbbpiT+ufOnWpLTfLTDWkGc9x4M7YD41bIDzq cWvkfOPSi2Z/coJ91kpoSAwg3RleV9c0/OqgOGkxNhFIUaejEbGUek67geF2xHFiG6NGCh rvyDUM4b3YbqWEbPfrWWGokplUuF7kcIsA24+9TbwPYxanGuqxq8t4qUot7YQAgTcs+cYt 96xQ0KXsunyfvd7+I5h32xDu0xif6MCtF5HNFGuKj6WmSrH2WLbUfR4Hrm0fK1cu9yJ4fH XRgn/cwi0MFp3wbm9M/n9ET/vs+6+6c3BiKXSJ4F3txsgs1XezCLdhQ6ap/QEg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=G6hZ92GL; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -5.92 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=G6hZ92GL; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 131FE405CC X-Spam-Score: -5.92 X-Migadu-Scanner: scn0.migadu.com X-TUID: v68vto22AFV2 --=-WumCBHHqxQgK1ICKtZol Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable John Kehayias schreef op wo 12-01-2022 om 21:55 [+0000]: > Hi Maxime and Nicolas, >=20 > =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 Original = Message =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 >=20 > On Wednesday, January 12th, 2022 at 4:26 PM, Maxime Devos wrote: >=20 > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 #:tests? #f ; Tests are deprecated/br= oken until next version. > >=20 > > How can a test be deprecated? > > What tests are broken? > > Are the tests broken, or do they fail because of a real issue? > >=20 > Sort of both? They relied on python2 and had not been updated, so they di= dn't work (at all from what I see) and were therefore due for replacement i= n the new version (forthcoming). >=20 > See https://github.com/autokey/autokey/issues/327 where they say "The cur= rent tests are deprecated and won=E2=80=99t work." That's why I said it tha= t way in the comment, sorry if that wasn't clear. The new version that seem= s due soon has a new test framework (tox). Adding a link to in the comment should be sufficient: ;; Tests are deprecated and broken until the next version, see ;; . #:tests? #false > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (wrap-program program > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 `("GI_TYPELIB_PATH" = ":" prefix (,gi-typelib- > > > path)))) > >=20 > > Do we need to include the GI_TYPELIB_PATH from the environment? > > If not, I recommend '=3D' instead of 'prefix' to avoid potential troubl= e. > >=20 >=20 > I'm not sure, I was following the examples I saw. For whatever reason, ne= arly all of them do it that way (I think I only saw one or two as '=3D', in= my quick look). Anyway, I think you are right that it shouldn't be needed,= probably the same for a lot of other packages? I think it works with '=3D'= instead, in my quick test. I think it isn't needed, but because it allows scripting in python (and hence can benefit from any python libraries in the environment, possibly including python libraries using GI_TYPELIB_PATH) ... > >=20 > > If you add "GUIX_PYTHONPATH" =C2=A0to the wrap-program, > > then probably the propagated inputs can be moved to the regular inputs > > (since 'autokey' appeas to be used as a few binaries and not > > as a python library). > >=20 >=20 > I'm confused on this as these are already wrapped with GUIX_PYTHONPATH (t= he bin outputs are python scripts) without adding it explicitly. Trying wit= h the propagated-inputs being regular inputs seems to work fine too. (seems like this is done implicitely by 'wrap' in (guix build python- build-system)) > Although I haven't used it this way, there is also scripting with autokey= . One of the included programs is autokey-shell which is a python shell of = sorts. I'm not sure if that would make a difference and I don't have anythi= ng offhand to test with. it would be nice if the user could install additional python libraries to use from their scripts, so I think 'prefix' would be better here. (If I'm not mistaken about Python's loading order, locations early in GUIX_PYTHONPATH have priority above later entries, so there shouldn't be any problems unless autokey has undeclared dependencies). > I can submit a patch to change the wrap and inputs if that would be clean= er. * Maybe you make the GUIX_PYTHONPATH wrapping explicit (e.g. by removing the wrap phase, or moving the 'wrap-autokey' phase before the 'wrap', or letting it replace the 'wrap' phase), adding a comment ;; Use 'prefix' instead of '=3D' to allow the user to use additional ;; Python libraries from their autokey scripts. * or maybe don't do that, but still add a similar comment to the 'wrap' phase. * Could you make the comment next to #:tests? a bit more explicit? Greetings, Maxime. --=-WumCBHHqxQgK1ICKtZol Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYd/WGxccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7r/pAP0XajOddrk44lposkH4AQQrBq5J o5yoOoq+BoQsJYeI1wEA/zoFgaDA/Ftp93ZhJDrB+0lO8y354ZwYS/CWBpd9lQU= =IcFO -----END PGP SIGNATURE----- --=-WumCBHHqxQgK1ICKtZol--