From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id K+jAEA2PN2JeKgAAgWs5BA (envelope-from ) for ; Sun, 20 Mar 2022 21:31:09 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id mEiGDA2PN2IqJAEAauVa8A (envelope-from ) for ; Sun, 20 Mar 2022 21:31:09 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C3D113A107 for ; Sun, 20 Mar 2022 21:31:08 +0100 (CET) Received: from localhost ([::1]:47518 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nW2Ch-00068E-IL for larch@yhetil.org; Sun, 20 Mar 2022 16:31:07 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36406) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nW2Cc-000670-39 for guix-patches@gnu.org; Sun, 20 Mar 2022 16:31:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:41294) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nW2Cb-0006zm-Qx for guix-patches@gnu.org; Sun, 20 Mar 2022 16:31:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nW2Cb-0004I1-Og for guix-patches@gnu.org; Sun, 20 Mar 2022 16:31:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#54309] [PATCH] services: auditd: use exclusive log directory for auditd Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 20 Mar 2022 20:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54309 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: fesoj000 , 54309@debbugs.gnu.org Received: via spool by 54309-submit@debbugs.gnu.org id=B54309.164780824816468 (code B ref 54309); Sun, 20 Mar 2022 20:31:01 +0000 Received: (at 54309) by debbugs.gnu.org; 20 Mar 2022 20:30:48 +0000 Received: from localhost ([127.0.0.1]:35191 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nW2CN-0004HR-QL for submit@debbugs.gnu.org; Sun, 20 Mar 2022 16:30:48 -0400 Received: from xavier.telenet-ops.be ([195.130.132.52]:50946) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nW2CK-0004HH-Ie for 54309@debbugs.gnu.org; Sun, 20 Mar 2022 16:30:46 -0400 Received: from [192.168.100.254] ([178.119.10.153]) by xavier.telenet-ops.be with bizsmtp id 8kWi2700D3J72EA01kWiH5; Sun, 20 Mar 2022 21:30:42 +0100 Message-ID: <05b76afd93703efe8fca7fd11513c07343123dd3.camel@telenet.be> From: Maxime Devos Date: Sun, 20 Mar 2022 21:30:36 +0100 In-Reply-To: References: <80cc8802439c49138638dee6d4fb9015723f9727.camel@telenet.be> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-Oy/6y2axoZzbDxXNO+7C" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1647808242; bh=KTDy/MNabENoXvstrN7kDu0Rduo4kgyWdFWw1tb+zX8=; h=Subject:From:To:Date:In-Reply-To:References; b=c8bRoKQ8lMoR6nnm8QCh0zoFDi9fYGdbhSiMXIu00pR6TXpXRmqfrByW4i3btUsWQ qjSAmVjr2hsLXLjhkCQT4ymKf99VIkJJpRXcM+tjhl67dYbXCuq0bsmX6u7MRddFu0 yw8ZAdLB7GKKgz9GxqYEyiVP9KRggpY0NTcbvYaIa0XvdM9oBKM3dSp64fBC4gDZZg NedknSflqeAyyOp8lV98ahOBY0/vK0Pcl9huWLNP7MeaxH5dr3X5fT0sL8xiEVCwf7 DOUhZKFe9aKWaC89HmlAUCBFNnFr7eXYlPmcVSJ1Et9VQB9NrzRJ2HJj0/lXThAcW0 b0NsCM709v8yQ== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1647808269; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=KTDy/MNabENoXvstrN7kDu0Rduo4kgyWdFWw1tb+zX8=; b=fdFP7xZPMKxkMKHWCwT4zreRTvDOLpx9ec0fmxhSNjc8ufZw06zIq2VkJzRFIza/5/4fTz Nmo9cE6oRlSW0udVrEOWwMp8iOXHCY8Ve+GoID5PUalYp214A1T7BzEjXhQBGXdVlAcSq7 033yml+yzYTQ0rHzQ4Op6bnP/imSzW35A81IEcnof2DL3zSkNJVjbbV/dWLV85uRNZT+9f cIElv+licrvx1XWxT/ebYuen0OhI5WS4auZB7xPqtQSCWo5RZS6e0cuJHtaOVVTnqk8Q6g TEUzQhTSTM5ByN86FB4amrfLQdI6Eyb1ltD08JTHjaNHXZ+VSezkNd9VK5c2Pg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1647808269; a=rsa-sha256; cv=none; b=nRiqTg/dLj9gMCmhPwYwZwB4ziimC/YK6R8g4FQDBiIGRZkbDp3kBbVfGX2SoZ2OLuU/XU 3qgwUWsq54au2co+rtCp+2hWCBVqugRreyMv0LE99gCeUDiVOjlfpHQbbPUwhQ5t3Bma5u iJc5QaelWcoWjjBWLlrlWh68T+A2YobU2uDx740BNIT2wBl36XgczAZ/6DqGNMzs4gLVYx 4FVSetvlvjo5JTZ9T1MXWp/ykr+PXk4LoBgNpKm2SQqq87JfOiOJnNhrz5KKSzMMnbmXvD Ip8WHyZOFoadbmwr5l6/ULobRjzT84D4wtqwxH/XzpqfZ1Utahq6yIsHkvqSxA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=c8bRoKQ8; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 3.77 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=c8bRoKQ8; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: C3D113A107 X-Spam-Score: 3.77 X-Migadu-Scanner: scn1.migadu.com X-TUID: zJ4JZ9LXX2kO --=-Oy/6y2axoZzbDxXNO+7C Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable fesoj000 schreef op zo 20-03-2022 om 21:22 [+0100]: > > I cannot recommend this, what if 'mkdir-p' throws an exception? > > That might cause problems.=C2=A0 Or maybe not, but it would require > > some analysis that can be avoided with 'mkdir-p/perms'. > Hm, but i still have to set umask to prevent TOCTOU, the > implementation of 'mkdir-p/perms' does not take care of that. mkdir-p/perms could be modified to take care of that. If that is done, then other users of mkdir-p/perms would benefit as well. To implement this, I recommend using the prodecures from -- that patch was written to remove the TOCTOU! Greetings, Maxime. --=-Oy/6y2axoZzbDxXNO+7C Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYjeO7BccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7uaQAP9x64C9LxQ9a7zwaAtTpMjlRs0A CAbEvZkjjIi/cREyIQEAn1JIs/z1wT5juNCj1DdhWeQvW4wFpaASFS0VEs6AyAk= =vQlN -----END PGP SIGNATURE----- --=-Oy/6y2axoZzbDxXNO+7C--