From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id cn5YEBYxVmHhVAEAgWs5BA (envelope-from ) for ; Thu, 30 Sep 2021 23:50:14 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id GOd8CxYxVmGyYAAA1q6Kng (envelope-from ) for ; Thu, 30 Sep 2021 21:50:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D8DCDB1A9 for ; Thu, 30 Sep 2021 23:50:13 +0200 (CEST) Received: from localhost ([::1]:37356 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mW3wT-0002Hp-0p for larch@yhetil.org; Thu, 30 Sep 2021 17:50:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42680) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mW3wI-0002Hh-Uq for guix-patches@gnu.org; Thu, 30 Sep 2021 17:50:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42702) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mW3wI-0001Ca-Kg for guix-patches@gnu.org; Thu, 30 Sep 2021 17:50:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mW3wI-0007NJ-H4 for guix-patches@gnu.org; Thu, 30 Sep 2021 17:50:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50620] [PATCH 0/2] Unify 'computed-origin-method' (linux, icecat) Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 30 Sep 2021 21:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50620 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Mark H Weaver , 50620@debbugs.gnu.org, zimoun Received: via spool by 50620-submit@debbugs.gnu.org id=B50620.163303855628285 (code B ref 50620); Thu, 30 Sep 2021 21:50:02 +0000 Received: (at 50620) by debbugs.gnu.org; 30 Sep 2021 21:49:16 +0000 Received: from localhost ([127.0.0.1]:54247 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mW3vY-0007M8-3Z for submit@debbugs.gnu.org; Thu, 30 Sep 2021 17:49:16 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:45638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mW3vS-0007Lr-55 for 50620@debbugs.gnu.org; Thu, 30 Sep 2021 17:49:14 -0400 Received: by mail-wr1-f65.google.com with SMTP id d21so12292423wra.12 for <50620@debbugs.gnu.org>; Thu, 30 Sep 2021 14:49:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=ynB7DOxt3f9FukQ4Qjyef3j9C2bfAAH4wd4oanSiqgM=; b=o0wdz8oa1gSs85Rmb7tZzF2aO3p+QBI7fFJvRvkrcAptAS8LhFJeRZNebMK2jek6Ic jITmo8sZC+mBD3IrW2kk4r6cpGj+a3ijZPDk1nyT52mAuAKn+7v1tDPdVFMG064d3WJZ pH6mgZ+pKjeyQvmoeAFBZVsX7ufHhgtyIfFch3ds7obApoOB4bTyJajV44WzkA85Skia S/wYLsoTOJBMxbFIJ7VbK8EAwM+Y1fyEuseeOPnwNDP3wc1g1LFV9gI8dOnHmfcKMpB2 fZ3HzjacCVsWV7z/827Q7hH62hCFGmNGNbAchfMfWD5fSe3klRUiQ57L2fAC/FBd57Dk Np4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=ynB7DOxt3f9FukQ4Qjyef3j9C2bfAAH4wd4oanSiqgM=; b=zQ5SFdgRZaS1X8B0S376FVBC2UGbmP/7NSVWh0bVvMtmr9YFxOaQrKnP4oDWAdWVDn ZKdiYE98u/amzO9mEjm5JW7yck/0Xm6Qbj4JrrSV6cN3DitSRm5kzagF5FPcrisgrycX 4qOGyqSWvRMr3gNddi8NK/6jNnJxbAleL6RXmsDcIFA+EmhUoACriTzTR6EeSqlARl7R hKpvX0yTX1TSr7zYwg3C3OWoSD5khbiDiqt5NBvfsYGndatkxfm1ki93RdEHy1j1mUPL FYKm1zi4zZiRQOfvrI+yJftM0zTrEEDD9kn0+SpA37Plf4JlBeUrJHMdRfjG5FHUtUm/ qCDQ== X-Gm-Message-State: AOAM530k1ETf5Cs/5HjuTyA74wKWzcqgKuba989nIeGWj5X7K5dWvCzv vnpd41qPuIE+zZxXVUglZ8A= X-Google-Smtp-Source: ABdhPJzou5nJlmfM5QPPdLgukU8Pqa9kdcUKBFhX7NA1Psh4UWPk+PAIFiTUH2zJk1+2RFtjhO/81Q== X-Received: by 2002:adf:f583:: with SMTP id f3mr8453319wro.116.1633038543971; Thu, 30 Sep 2021 14:49:03 -0700 (PDT) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id o3sm4071686wra.52.2021.09.30.14.49.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Sep 2021 14:49:03 -0700 (PDT) Message-ID: <0541a55a86b604ec45980341ea64ace7b9312db3.camel@gmail.com> From: Liliana Marie Prikler Date: Thu, 30 Sep 2021 23:49:02 +0200 In-Reply-To: <87wnmx3jx3.fsf@gnu.org> References: <20210916114734.2686426-1-zimon.toutoune@gmail.com> <9b6ee27ff10e1042a5d61d0f93d957cf760e9ecb.camel@gmail.com> <87v930ay5y.fsf@netris.org> <87pmstghx0.fsf@netris.org> <87a6jv8qu7.fsf_-_@gnu.org> <87pmsr5a0z.fsf_-_@gnu.org> <09c009ec61b8f9c1746f98916f492b8953b16dcc.camel@gmail.com> <87r1d64gd3.fsf_-_@gnu.org> <735304d110f5e99c66904fc7ced3465bf1815baf.camel@gmail.com> <87wnmx3jx3.fsf@gnu.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1633038614; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=ynB7DOxt3f9FukQ4Qjyef3j9C2bfAAH4wd4oanSiqgM=; b=Abofw921LduK0wpT6O6rnUIBuJDGUCq17ofbWjby7QV936/TfLMww46/JePB1nFWESRS5q 3mdC55KZz4mQKtU+cLRxIt8uO87Mbtp94z3cs/8UJxfp0aRL4K5o2aJjGXTBo+GT3zuplQ av8FT+BAqCk7VbDgduU9oGxWGUp7LNkzvzxRBFGGxGfpv+GLUAKAOM+avcnIOcNGY8Tmnl uVV8cfXcx56ol2Ib0LWk7SVkDeUbzf+9rJdLmuOftEjRJjeS5Hp3Cz6jMCM2Xy3vRR6syG VKTz65NFIB2GC+c/+jsTC3hQ/fSLo6Kqz7X0x3NZ3css6NVpE63OBD3ReCEdzg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1633038614; a=rsa-sha256; cv=none; b=SaVl5oXFHmUr7wCvnzkijag+LIEdi3rltEWmjquL6lTIMGgc8Gzg8v8C6WWEgiTFID1/EG PLUE1ftgbNZUJ3TSrytP8gwSoUzH7C9sZOZu8tVLctXKY6P3LrGm3wY1TrimyH9Dozg5ok S+9KuBAfJ51aPpwDy/euxcVnvDCvB//2Q+1SPIpbeRXvA6si0g+yFVdQ/qyeYE0ZvgBHGJ 8pneNDHYHyZLHzHC81HUTjbSsSv1D4t/SJ/73BQylNuhdWMhTK6A3EJS4GaosJ9eoumUTF RgAawBWtFFHfEo7xmT4ABCjkGuChrmAkJjm7Ll8fTSbzYD6s7/y+uT8eN2gPGg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=o0wdz8oa; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: 0.20 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=o0wdz8oa; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: D8DCDB1A9 X-Spam-Score: 0.20 X-Migadu-Scanner: scn0.migadu.com X-TUID: la8qsqCT8xfE Hi, Am Donnerstag, den 30.09.2021, 22:09 +0200 schrieb Ludovic Courtès: > Liliana Marie Prikler skribis: > > > [...] > > Which is a practical issue because it'd mean that the tarball gets > > built as soon as the source is interpreted? > > It’s impractical because typical usage introduces top-level circular > references (e.g., if you write #$gzip). Ah, right. > > I mean that we don't need to wrap local-file inside an origin for > > example whereas we do need to wrap e.g. svn-fetch instead of having > > an svn-checkout constructor at the top. It's not really that > > noticable normally, but weird once you start thinking a little too > > hard about it. > > Hmm yeah, I must not be thinking hard enough. :-) Perhaps it's just me who finds it weird tho. ¯\_(ツ)_/¯ > > Slightly similar, but I don't think I'd want a singular source > > url. Instead > > > > (define-record-type* computed-tarball > > make-computed-tarball > > computed-tarball? > > this-computed-tarball > > (sources computed-tarball-sources) ; list of origins, local > > ; files or other things > > (builder computer-tarball-builder (thunked)) ; gexp > > (name computed-tarball-name) ; perhaps? > > (location computed-tarball-location (innate) > > (default (current-source-location)))) > > > > At the start of BUILDER, SOURCES are already unpacked to the > > current working directory under their stripped file names. After > > builder returns, we either package the contents of the current > > working directory up into a tarball (variant A) or we have builder > > return a list of files to pack up (variant B) which we then post- > > process maybe. > > > > WDYT? > > Overall LGTM! IWBN to see if there are other potential users in the > tree (I can’t think of any), but for IceCat and Linux-libre, it could > already improve the situation. Concrete examples which currently use "unpack more after unpack": - chez-scheme with nanopass and stex - xen's mini-os - lbzip2's gnulib (and probably gnulib in other locations) - similarly libgd in gedit and gnome-recipes (same origin for both) The builder for those would always be a simple (series of) directory rename(s) as well :) This list might not be complete, at least I haven't checked whether it is. Also, packages which have (package-source some-other-package) as input somewhere don't count here, as the missing sources can trivially be found and inserted imo. Regards, Liliana