From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id KFBIEli9ImblRgEAe85BDQ:P1 (envelope-from ) for ; Fri, 19 Apr 2024 20:52:08 +0200 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id KFBIEli9ImblRgEAe85BDQ (envelope-from ) for ; Fri, 19 Apr 2024 20:52:08 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=eYQQYFnB; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1713552728; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=WrQDdjc23J9WeJOnueOUrf+ISTEV8nIVfSSrjl36gS0=; b=UMnuaf2F4XcxFutfEVL26rDgmo5z1Th0AJ467Ury8QxGjEY//W63yfEdgrKUhhYzHACDBN sIVpgR9wxG3uU248Za+DQoNDWLNKW4bFo8VB47l5pAkg1lXcinBSMasgQ+IH2qsUHoqq+r Dh2DOAIgTUfKNpNZp1QRrB3UFbcyoQyjnsjbipjozLOKzJuOU+vDB+g49LXZHHa7eC3jci bRjh3rhbE25Y1ouEG41a+tDtL4P0ZEZ6hHYrkbHzHz3dLy666JD3ViPl8zlxhOGrVlsSs5 oAJYeHi/juDz6KK4BLuLYzM+1iiq8Wsi2h8KqzIPyJVV9fopJK+IuhAVz9UsaA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1713552728; a=rsa-sha256; cv=none; b=nWIEFpw/Iw5IsehaOZCW/guvjv8ev6YTFEpD/n/xGzE5On+ss49EhcbpnAxJo+wT1ZQUIm r8Oo8lsOhMyCZkEbD7WgrebOT2t11boY2FYkutn7dUdcxNFv9NOluVg2yfwefQ2pGhCh9l giyB8GXWrQahgMdZtuZIvTY2dc5RrOXZfGyXFuO8T+nSaQXwdr+8RCnm82AIOZ6JYvCAAk OOehqmxfnf25lBdo0icmw51TA7SZyUDyA2R7OTOC03nohqsdahdbZUaGNq45inT/8xlZQW 2DFHqobRVeoXjnwj3jBmYpvE27dH655ZZba+Gqn/n0VCx6qXxMZOd3+j20/6WA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=eYQQYFnB; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1ACC31C787 for ; Fri, 19 Apr 2024 20:52:08 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rxtKz-0003Ad-Tz; Fri, 19 Apr 2024 14:51:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rxtKx-0003AD-1X for guix-patches@gnu.org; Fri, 19 Apr 2024 14:51:51 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rxtKw-0001tS-OQ for guix-patches@gnu.org; Fri, 19 Apr 2024 14:51:50 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rxtLA-0005V2-Qf for guix-patches@gnu.org; Fri, 19 Apr 2024 14:52:04 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70282] [PATCH v2] gnu: gnome-shell: Wrap screencast service. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 19 Apr 2024 18:52:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70282 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Dariqq , 70282@debbugs.gnu.org Cc: Vivien Kraus , Maxim Cournoyer Received: via spool by 70282-submit@debbugs.gnu.org id=B70282.171355272121096 (code B ref 70282); Fri, 19 Apr 2024 18:52:04 +0000 Received: (at 70282) by debbugs.gnu.org; 19 Apr 2024 18:52:01 +0000 Received: from localhost ([127.0.0.1]:59762 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rxtL6-0005UC-JJ for submit@debbugs.gnu.org; Fri, 19 Apr 2024 14:52:00 -0400 Received: from mail-ej1-x644.google.com ([2a00:1450:4864:20::644]:51693) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rxtL4-0005TK-9K for 70282@debbugs.gnu.org; Fri, 19 Apr 2024 14:51:59 -0400 Received: by mail-ej1-x644.google.com with SMTP id a640c23a62f3a-a44ad785a44so239976466b.3 for <70282@debbugs.gnu.org>; Fri, 19 Apr 2024 11:51:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713552698; x=1714157498; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=WrQDdjc23J9WeJOnueOUrf+ISTEV8nIVfSSrjl36gS0=; b=eYQQYFnBOWyDv32IT+P+/NZqBLfKI2FkTeZLhMWwy97/tX8J9IwSQ9EzcFrGPLjX1J ffxGSuUGlvjQE0ARpY0l2lixstbgSnUCcD9gTJDPRa9TzaFfZO7BqQBvRnQvymeR6OR6 oS3bBSbui2bz0IqP0Zfd7Jxqz5hw6+RxqNOg2zw7tDXyMFyQaZuaBJRrhkiM7AG0HpD9 1JTNbfO7sUL2P4iqIyzXiBSo+Vc3W5vpA3oHULcJAB5udLkEzyciSrkkCj19hV4ezllc NXaFzhsnjSW49EZS247EcebW8Vd5s+J80TePmzNl29MMKGm0jdjC4cOMxzCpyY1v4BD5 cjgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713552698; x=1714157498; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=WrQDdjc23J9WeJOnueOUrf+ISTEV8nIVfSSrjl36gS0=; b=R94QSDY8H9SVevveId8GzOB+3l4ILOodY+DvDld8PVZ+xTkHEE/+xWWGrWT2pkgT4A 6B0lFgEJY0dbtoZLp1es3V98FJdvkAiozdeVRRS6S2dSQxFZNLhc9goBapcl6JR/200+ fzqdmTFcJkKR/7cFJU9rmnVI32bP3RnmPpfUYp4LcqBvWWOLY4jRsHqCpFniqSfTDcqV Gry/BvCHGZ2n0PTFCJJ9odusRtEtnpGBIHRgLCRKN3pkAX8qjfh3NedJCIf/mKNhh0vn yHlSdKpHP1+QTFRdExBroH3P3ccAAOWQ9vT2wg84U5wEw53KrXU0gKZSkvpnNLJs9FdY pNjA== X-Forwarded-Encrypted: i=1; AJvYcCUBrAcDzFm/qSbes3BQeegvSAbtQdCiqeMMpFVhrrHIlnu7F/1173oVfqXe6BGGtmgdvZScUphdGZY+KlTDJwxpfQwkdFc= X-Gm-Message-State: AOJu0YyuLWkzaBAt4pMy/XaQF1Qm23PawLBH4RmemQKt+gFNqwh5dHsx 9LMgtjawqkjSHqRacMagQPL1/wC+dB/dnzhu8ok6wNPzo8RU66vc X-Google-Smtp-Source: AGHT+IGN3HlNww7DdZlSNuch32/9jOlcaX9fMbai9VN5mpZbWi/eLJGhA0c59gb9z8gRV8YvKskE1g== X-Received: by 2002:a17:906:a1ce:b0:a52:5277:3aa7 with SMTP id bx14-20020a170906a1ce00b00a5252773aa7mr2093765ejb.22.1713552697974; Fri, 19 Apr 2024 11:51:37 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id hz13-20020a1709072ced00b00a5592eeac79sm231543ejc.13.2024.04.19.11.51.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Apr 2024 11:51:37 -0700 (PDT) Message-ID: <0497984af8f383af8e8b981d78dc9baf23869e30.camel@gmail.com> From: Liliana Marie Prikler Date: Fri, 19 Apr 2024 20:51:36 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: 4.15 X-Spam-Score: 4.15 X-Migadu-Queue-Id: 1ACC31C787 X-Migadu-Scanner: mx12.migadu.com X-TUID: ciOqD35xS0fY Am Freitag, dem 12.04.2024 um 17:26 +0000 schrieb Dariqq: > The screencast service can now find typelibs and gstreamer plugins. >=20 > * gnu/packages/linux.scm (gnome-shell) > [inputs]: Add gst-plugins-good and pipewire. > [#:phases]<'wrap-programs>: Create a wrapper for screencast service > and use it. >=20 > Change-Id: I2c31bf1bd92e281b86c57b06988c6a3793a58d40 > --- >=20 > Hi, >=20 > Here is v2 of the patch. The wrapper is now created manually as I was > unable to find a way to manipulate the gstreamer plugin load path > from within javascript. Importantly this leaves the original > javascript file untouched and therefore circumvents the argv[0] > problem in v1. > All the required gstreamer plugins (pipewire and gst-plugins-good) > are now inputs and are in the wrapper via GST_PLUGIN_SYSTEM_PATH. I'm not sure this fix is sounds. It looks like it misses manual invocation from the command line, does it not? (Well, it's gnome- shell, so if you have to invoke it from the command line, things are broken, but still=E2=80=A6) What keeps you from wrapping the environment variable in Javascript? > I've also left a comment for the required home-pipewire-service. > In gnome-shell 45+ the invocation has changed to 'gjs -m service'. > Should this also be a comment somewhere? Gnome-shell 45+ is currently irrelevant, but we might have to adapt things once we get there on gnome-team. We do need a better gjs- patching strategy. Cheers