From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id eKWbI3DCdGJLfAAAbAwnHQ (envelope-from ) for ; Fri, 06 May 2022 08:38:40 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 8OLSInDCdGIopQAAG6o9tA (envelope-from ) for ; Fri, 06 May 2022 08:38:40 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E5E79A6F2 for ; Fri, 6 May 2022 08:38:39 +0200 (CEST) Received: from localhost ([::1]:48114 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nmrbq-0001vq-In for larch@yhetil.org; Fri, 06 May 2022 02:38:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37404) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmrbI-0001u8-NB for guix-patches@gnu.org; Fri, 06 May 2022 02:38:07 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:53016) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nmrbG-0001nO-Cj for guix-patches@gnu.org; Fri, 06 May 2022 02:38:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nmrbG-0008Bl-7s for guix-patches@gnu.org; Fri, 06 May 2022 02:38:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55248] [PATCH 1/7] gnu: racket: Update to 8.5. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 06 May 2022 06:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55248 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Philip McGrath , 55248@debbugs.gnu.org, Maxime Devos Received: via spool by 55248-submit@debbugs.gnu.org id=B55248.165181906431450 (code B ref 55248); Fri, 06 May 2022 06:38:02 +0000 Received: (at 55248) by debbugs.gnu.org; 6 May 2022 06:37:44 +0000 Received: from localhost ([127.0.0.1]:46913 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nmrax-0008BB-H6 for submit@debbugs.gnu.org; Fri, 06 May 2022 02:37:43 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:42433) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nmrau-0008B1-N8 for 55248@debbugs.gnu.org; Fri, 06 May 2022 02:37:41 -0400 Received: from lprikler-laptop.ist.intra (gw.ist.tugraz.at [129.27.202.101]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4Kvgq44lrkz3xNS; Fri, 6 May 2022 08:37:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1651819056; bh=Kx07UnLPpvWbXPC+9O3cf6c/vWexiFJxSacR3ZOD+do=; h=Subject:From:To:Date:In-Reply-To:References; b=fq3TlRow8wIbgBlh8wbB/tOmLBrlCiPLkAyLop9HFAlws/2j6hPeYNMRL8QaGga+y kJ9IINOZsMxo/ZIJeKBmg8jjd43ZBj5JNgcSsaI/esztQiBei3wcKNnkS4olfqz38g UKLUb9YGNkY62ef7lQYB1h0q+sOOLBfj6ywzlqfU= Message-ID: <03612de279ff26c801eb02a2d0aaa03fecfe59f9.camel@ist.tugraz.at> From: Liliana Marie Prikler Date: Fri, 06 May 2022 08:37:37 +0200 In-Reply-To: <9d2423b2-aacb-4869-b3a7-e4ac885cc36c@philipmcgrath.com> References: <2290ebb81a8acaa959eff9f60694330e495e3a19.1651594312.git.philip@philipmcgrath.com> <7b3da393016daa21c35dd27fc086b03339435e9d.camel@ist.tugraz.at> <9d2423b2-aacb-4869-b3a7-e4ac885cc36c@philipmcgrath.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: waObeELIUl4ypBWmcn/8wQ X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1651819120; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Kx07UnLPpvWbXPC+9O3cf6c/vWexiFJxSacR3ZOD+do=; b=DvmjAZAwxTifiiCVgOFGZNbfQ2V8P0jJC4+2dNT/NHXj+McJZJWdacaQLbuPMwjnbeivq+ Zmi9ZRc9FyZW62hyyyGUIScadrr3hCk6edruvU0vTVlKnalmwLuKc8n23d6b2XYo/O5I9v lUOxLPVGi4v9ez7RQDPttTKOP4jldy2R1EQT9Dd6J+HBX/IXPI0c54E4g2eygDO/6l46iV lop8UN6yAwOig3v8MZrAhQyLPmfmvBzOiwJ6iHnG4+x+KZ6J2vxHOpKFPAGcUy2Y4MR12U W/fFHUEByUofAWe0OSnyQOZM5I6myzlhkj5+esBppKBPq2fjDwR2DSsos2hyyg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1651819120; a=rsa-sha256; cv=none; b=jsg9WhZB4/FGJL6D0fMsUbpoRHZnLg6kDt6QR/sbl32MJdvtaBGwtUChw42mESRww5c/nm wI2yT4xRraxBkidVEr75P+BEhrXvODWaIwKUcIOlzYvMVxISvfeTOJsj4jjOQOIVwXdynn DD6epbU16G2it5/gZUwVndJj2M/81VmbItsG0xVOoxczwvyPSVcT11cc6UO40nNATc4kS1 3rpbaTDkQJ6yWI7NFIRVMRq+erD5RDN3f3foIKKvGbUeDQuPkKGrc7h3DS86sN9repoV4A SitzQIYcvouoqcsC6rOCB+aY+coTrfh5U0kKv4i3JmzHZPNZIRO4pOKaaTU68A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=fq3TlRow; dmarc=fail reason="SPF not aligned (relaxed)" header.from=tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 5.80 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=fq3TlRow; dmarc=fail reason="SPF not aligned (relaxed)" header.from=tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: E5E79A6F2 X-Spam-Score: 5.80 X-Migadu-Scanner: scn1.migadu.com X-TUID: 0xz1nZVaYKCo Hi, Am Donnerstag, dem 05.05.2022 um 17:49 -0400 schrieb Philip McGrath: > Hi, > > On 5/4/22 02:53, Liliana Marie Prikler wrote: > > Am Dienstag, dem 03.05.2022 um 14:33 -0400 schrieb Philip McGrath: > > > * gnu/packages/patches/racket-gui-tethered-launcher- > > > backport.patch, > > > gnu/packages/patches/racket-enable-scheme-backport.patch: Delete > > > files. > > > * gnu/local.mk (dist_patch_DATA): Remove them. > > LGTM. > > > * gnu/packages/chez.scm (chez-scheme-for-racket): Update to > > > 9.5.7.6. > > This... > > > * gnu/packages/racket.scm (%racket-version): Update to 8.4.900. > > ... and this might be done in different commits. > > Since 'chez-scheme-for-racket' uses the same origin as the Racket VM > packages, I think the versions have to be updated at the same time, > short of having a commit where one of them is incorrect or doing > something needlessly complicated. Fair enough, go ahead. > > [...] > > > [patches]: Remove obsolete patches. > > LGTM. > > > > > (racket-vm-common-configure-flags): Remove incorrect comment. > > No.  Unless you address the issue at hand (which I don't want to be > > a blocker for this series, mind you), it persists.  If you don't > > like how the comment is written currently, you might suggest an > > alternative formulation, but people deserve to know that the > > origtree layout is a hack. > > I understand that this is your opinion. I disagree. I don't want to > make a big deal out of it, but I'm uncomfortable with the fact that > `git blame` currently attributes to me a statement of opinion which I > did not write and do not believe. Well, I'm uncomfortable with the fact that git assigns blame to people. The wording of the command name is (as many things in git) poorly chosen, but that's somewhat besides the point. I'm leaving open the option of writing a comment that you're more comfortable with, but I'm not leaving the option of silently removing it. > I could write a lot of prose arguing in favor of --enable-origtree as > a matter of opinion, but I'd rather spend my time trying to write a > racket-build-system, which I expect will make its usefulness more > obvious.  You can argue in favour of it, but that doesn't change the fact that this layout breaks assumptions that are held elsewhere. "Dump everything into a single directory" has never been a good deployment strategy, and those who use it tend to regret their decision later. > For now, I'll limit myself to noting that, while Racket > supports --enable-unix-style for those who insist on it (a group > which formerly included me!), if you run the Racket installer script > [1] with default options, it will install the files that 'racket-vm- > cs' and similar place in "/opt/racket-vm/" in "/usr/racket". > Optionally, the installer will then create symlinks is "/usr/bin" > etc. pointing to a subset of the files that Guix's 'racket-minimal' > installs into'#$output'. This paragraph does not make as much sense to another person as you believe it does. If I'm counting correctly, we're talking about three different configurations right now. --enable-origtree, --enable-unix- style, and a default that uses neither of the two. I don't think we can easily draw inferences from either to the others. > To the extent that there is an assertion of fact embedded in: > > > > -      ;; XXX: origtree layout is required by some other packages > > > down the > > > -      ;; bootstrap chain.  Remove these flags as soon as we can > > > do without them. > > it is not true. The packages which operate on a Racket installation > with this layout (e.g. 'distro-build' and 'raco-cross') are not part > of "the bootstrap chain", and the packages which are part of the > bootstrap chain do not require --enable-origtree, except to the > extent that e.g. it is a convenient way of telling apart multiple > executables named "racket". >From my POV "the bootstrap chain" consists of everything from the first VM to the final racket package. In that sense, I am sure you communicated elsewhere that it is very important to get layers going, and I'm also fairly certain that we can't currently build the VM chain without origtree either -- at least it would require nontrivial modification of said packages. Again, if you have a formulation that is more factual, but doesn't span several pages like other comments in racket.scm do, you are free to replace it. However, for the sake of a racket-build-system even, I suggest that it would be better if racket's own layout was meaningful. In other words, why can't racket be more like guile and support RACKET_LOAD_PATH and RACKET_LOAD_COMPILED_PATH? > > Cheers