all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Dariqq <dariqq@posteo.net>
To: 72181@debbugs.gnu.org
Cc: Dariqq <dariqq@posteo.net>
Subject: [bug#72181] [PATCH] gnu: services: power-profiles-daemon: Beautify service.
Date: Thu, 18 Jul 2024 19:28:06 +0000	[thread overview]
Message-ID: <01c0b4ce7e4f714d1a4e79e33e9ee994effe567a.1721330886.git.dariqq@posteo.net> (raw)

* gnu/services/pm.scm (power-profiles-daemon-shepherd-service): Change indentation.
[requirement]: Add user-processes.
[documentation]: Change name to Power Profiles Daemon.

(power-profiles-daemon-service-type)
[description]: Change name to Power Profiles Daemon.

Change-Id: Ibbd06cf1fbadd812ad3f0eac92b9772e3387f875
---

Addressing some of the feedpack I got after the original patch #70460 was already pushed: Changing power-profiles-daemon to Power Profiles Daemon in descriptons and make the service require user-processes. Also let the indentation of the shepherd service match other services.

 gnu/services/pm.scm | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

diff --git a/gnu/services/pm.scm b/gnu/services/pm.scm
index 47f0bf7812..5e8e7efda2 100644
--- a/gnu/services/pm.scm
+++ b/gnu/services/pm.scm
@@ -52,14 +52,15 @@ (define (power-profiles-daemon-shepherd-service config)
   (match-record
       config <power-profiles-daemon-configuration>
       (power-profiles-daemon)
-    (list (shepherd-service
-           (provision '(power-profiles-daemon))
-           (requirement '(dbus-system))
-           (documentation "Run the power-profiles-daemon.")
-           (start #~(make-forkexec-constructor
-                     (list #$(file-append power-profiles-daemon
-                                          "/libexec/power-profiles-daemon"))))
-           (stop #~(make-kill-destructor))))))
+    (list
+     (shepherd-service
+      (provision '(power-profiles-daemon))
+      (requirement '(user-processes dbus-system))
+      (documentation "Run the Power Profiles Daemon.")
+      (start #~(make-forkexec-constructor
+                (list #$(file-append power-profiles-daemon
+                                     "/libexec/power-profiles-daemon"))))
+      (stop #~(make-kill-destructor))))))
 
 (define %power-profiles-daemon-activation
   #~(begin
@@ -83,7 +84,7 @@ (define power-profiles-daemon-service-type
                   (service-extension activation-service-type
                                      (const %power-profiles-daemon-activation))))
      (default-value (power-profiles-daemon-configuration))
-     (description "Run the power-profiles-daemon"))))
+     (description "Run the Power Profiles Daemon"))))
 
 \f
 

base-commit: e3dfed59d39ac60dd2e2b9ef9f4ef63a2a081f41
-- 
2.45.2





             reply	other threads:[~2024-07-18 19:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-18 19:28 Dariqq [this message]
2024-11-20 22:43 ` bug#72181: [PATCH] gnu: services: power-profiles-daemon: Beautify service Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=01c0b4ce7e4f714d1a4e79e33e9ee994effe567a.1721330886.git.dariqq@posteo.net \
    --to=dariqq@posteo.net \
    --cc=72181@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.