From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:33889) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1igzFb-00049T-Jv for guix-patches@gnu.org; Mon, 16 Dec 2019 17:54:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1igzFa-00068d-Hb for guix-patches@gnu.org; Mon, 16 Dec 2019 17:54:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:34519) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1igzFa-00068Q-EG for guix-patches@gnu.org; Mon, 16 Dec 2019 17:54:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1igzFa-00072b-DX for guix-patches@gnu.org; Mon, 16 Dec 2019 17:54:02 -0500 Subject: [bug#38640] [PATCH] Add ripgrep and many rust dependencies Resent-Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Date: Mon, 16 Dec 2019 14:53:38 -0800 From: Martin Becze In-Reply-To: References: Message-ID: <002582d46228db8739fc12c0404ad177@riseup.net> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: John Soo Cc: Guix-patches , 38640@debbugs.gnu.org On 2019-12-16 19:08, John Soo wrote: > Hi Guix, > > I have missed using the rust tools I use outside of Guix. Ripgrep was > the first one I could build thanks to the work on the rust build > system. > > Of course, it required adding over 200 dependencies. > > Some of these have cyclic dependencies, as you all know. What I > understand is that the rust community is OK with including cyclic > dependencies as test dependencies. I am actually seeing how useful > that is. Consider the system tests in the guix repository. Certainly > that would require including guix as a dependency to guix. > > I also left the cargo inputs and dev inputs commented out just in case > someone wants to put them back in the future and to give a sense of > the topological order of the patches. > > Having imported ripgrep some months ago, some of these dependencies > will require updates, but I did not want to break the working version > of ripgrep at the end of the line. Otherwise I have fixed the other > lint errors and I have been using ripgrep for several months. > > - John I'm trying to convince everyone to leave in the crago-inputs dependencies and add a "#:skip-build? #t" to the build arguments for all source pakages. That way we don't have to specify the transient dependencies at the top level package. Either way yay ripgrep! -Martin