From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id iJ12J5wCv16ZXgAA0tVLHw (envelope-from ) for ; Fri, 15 May 2020 20:59:08 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id ACFhI5wCv15XHAAA1q6Kng (envelope-from ) for ; Fri, 15 May 2020 20:59:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4DBDB94017B for ; Fri, 15 May 2020 20:59:07 +0000 (UTC) Received: from localhost ([::1]:46592 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jZhQA-0002QJ-75 for larch@yhetil.org; Fri, 15 May 2020 16:59:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40712) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jZhQ6-0002Ov-0T for guix-patches@gnu.org; Fri, 15 May 2020 16:59:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55624) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jZhQ5-0000Bg-Ni for guix-patches@gnu.org; Fri, 15 May 2020 16:59:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jZhQ5-00010X-NU for guix-patches@gnu.org; Fri, 15 May 2020 16:59:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41181] adds emacs-interleave Resent-From: rdes Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 15 May 2020 20:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41181 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Nicolas Goaziou Cc: 41181@debbugs.gnu.org X-Debbugs-Original-Cc: "41181@debbugs.gnu.org" <41181@debbugs.gnu.org>, rdes via Guix-patches via Received: via spool by submit@debbugs.gnu.org id=B.15895763373862 (code B ref -1); Fri, 15 May 2020 20:59:01 +0000 Received: (at submit) by debbugs.gnu.org; 15 May 2020 20:58:57 +0000 Received: from localhost ([127.0.0.1]:38937 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jZhPx-000105-Iv for submit@debbugs.gnu.org; Fri, 15 May 2020 16:58:57 -0400 Received: from lists.gnu.org ([209.51.188.17]:44660) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jZhNU-0000w6-GY for submit@debbugs.gnu.org; Fri, 15 May 2020 16:56:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40384) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jZhNU-0001Y7-3Y for guix-patches@gnu.org; Fri, 15 May 2020 16:56:20 -0400 Received: from mail-40135.protonmail.ch ([185.70.40.135]:45001) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jZhNS-0007zM-14 for guix-patches@gnu.org; Fri, 15 May 2020 16:56:19 -0400 Date: Fri, 15 May 2020 20:56:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1589576172; bh=A6Cplhm+uq5ztqrI2sO4iQUDQB78I3OnTMIaHYuXmOE=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=EnJvp45Zs/Fptlzevs54AsYwuY4R0GzJP5QbFxdD3qatc8U/3sX4miUp7q+o9P6T7 O8yQkwzxDjpQkKVit/3NolyVWeKktdsYQhLftXv60sm7Cd45lJG2wN6XQ5faJ0YoUK LJbAxFK6uF6h5MNBP9hVG41O4flp8Bym7WG+SDeo= Message-ID: <-nBsa1KQJSwbENQmZILkCluHwqx_QyjF3PQxKtoNHoOeqeFc1FHy95KjjodciPwOSIH5XOxKIhoHv0Hzb87JVOVy3D1fEb1nD9fDidbeMiU=@protonmail.com> In-Reply-To: <875zd3x7z2.fsf@nicolasgoaziou.fr> References: <875zd3x7z2.fsf@nicolasgoaziou.fr> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_1b2291990679f01aceba5bfe4cdac084" Received-SPF: pass client-ip=185.70.40.135; envelope-from=rdes@protonmail.com; helo=mail-40135.protonmail.ch X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/15 16:56:13 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Mailman-Approved-At: Fri, 15 May 2020 16:58:51 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -2.3 (--) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: rdes , rdes via Guix-patches From: rdes via Guix-patches via X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=protonmail.com header.s=protonmail header.b=EnJvp45Z; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 1.09 X-TUID: 1UFXPffx8YZn This is a multi-part message in MIME format. --b1_1b2291990679f01aceba5bfe4cdac084 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hello Nicolas, Thanks for the pointers. Attached is an updated patch. Ryan Sent with ProtonMail Secure Email. =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 Original Me= ssage =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 On Monday, May 11, 2020 3:10 AM, Nicolas Goaziou w= rote: > Hello, > > rdes via Guix-patches via guix-patches@gnu.org writes: > > > The attached patch adds the emacs-interleave package. > > Thank you! Some comments follow. > > > Subject: [PATCH] gnu: Add emacs-interleave > > Your commit message should conform to Guix rules. Here, you need to add > > - gnu/packages/emacs-xyz.scm (emacs-interleave): New variable. > > > +(define-public emacs-interleave > > +(package > > Indentation seems wrong. > > > - (name "emacs-interleave") > > - (version "20191129.958") > > - (source > > - (origin > > - (method url-fetch) > > > > > > - (uri (string-append > > > > > > - "https://melpa.org/packages/interleave-" > > > > > > - version > > > > > > - ".el")) > > > > > > We do not use MELPA sources. Instead, you could use `git-fetch' and > extract the latest stable release from here: > > https://github.com/rudolfochrist/interleave/releases > > > - (sha256 > > > > > > - (base32 > > > > > > - "0y183ggfmkjjywbcqgyinmr21hsg2vaw4d52bg1gsxbp673za2m8")))) > > > > > > Nitpick: could you move the string on the same line as `base32'? > > > - (build-system emacs-build-system) > > - (home-page > > - "https://github.com/rudolfochrist/interleave") > > Ditto. Could you move the string on the line above? > > > - (synopsis "Interleaving text books since 2015") > > I think this synopsis needs to be reworded. As it is, it may not be > useful. > > > - (description > > - "Interleave presents your PDF side by side to an [[http://orgmode.o= rg][Org Mode]] > > Description uses Texinfo syntax, not Org syntax. In this case, however, > I think "side by side to an Org buffer" is sufficient. > > > +buffer with your notes, narrowing down to just those passages that are= relevant to > > +the particular page in the document viewer. > > +") > > You don't need to end the description with a final newline. It would be > nice to expound it a bit. For example, it could be interesting to know > this is a minor mode. > > Don't forget to add a copyright line with your name at the top of the fil= e. > > Could you send an updated patch? > > Regards, > > -------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ----------------------------------------------------------------- > > Nicolas Goaziou --b1_1b2291990679f01aceba5bfe4cdac084 Content-Type: text/x-patch; name="0001-gnu-packages-emacs-xyz.scm-emacs-interleave-New-vari.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-gnu-packages-emacs-xyz.scm-emacs-interleave-New-vari.patch RnJvbSAyOGQ4N2VkNWYzZDczNzJhNzU5NDc1YjI4YmM5OTkzNTYwOTUzZDJkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSeWFuIERlc2Zvc3NlcyA8cnlhbkBkZXNmby5vcmc+CkRhdGU6 IEZyaSwgMTUgTWF5IDIwMjAgMTY6NTM6MDIgLTA0MDAKU3ViamVjdDogW1BBVENIXSAqIGdudS9w YWNrYWdlcy9lbWFjcy14eXouc2NtIChlbWFjcy1pbnRlcmxlYXZlKTogTmV3CiB2YXJpYWJsZS4K Ci0tLQogZ251L3BhY2thZ2VzL2VtYWNzLXh5ei5zY20gfCAyNSArKysrKysrKysrKysrKysrKysr KysrKysrCiAxIGZpbGUgY2hhbmdlZCwgMjUgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL2du dS9wYWNrYWdlcy9lbWFjcy14eXouc2NtIGIvZ251L3BhY2thZ2VzL2VtYWNzLXh5ei5zY20KaW5k ZXggNDVjY2NlZDk5ZS4uYjcwYjlmZmZiOCAxMDA2NDQKLS0tIGEvZ251L3BhY2thZ2VzL2VtYWNz LXh5ei5zY20KKysrIGIvZ251L3BhY2thZ2VzL2VtYWNzLXh5ei5zY20KQEAgLTYwNTIsNiArNjA1 MiwzMSBAQCB0aGUgSHlkcmEgdmVyeSBzZWFtbGVzczsgaXQncyBsaWtlIGEgbWlub3IgbW9kZSB0 aGF0IGRpc2FibGVzIGl0c2VsZgogYXV0b21hdGljYWxseS4iKQogICAgIChsaWNlbnNlIGxpY2Vu c2U6Z3BsMyspKSkKIAorKGRlZmluZS1wdWJsaWMgZW1hY3MtaW50ZXJsZWF2ZQorICAocGFja2Fn ZQorICAgIChuYW1lICJlbWFjcy1pbnRlcmxlYXZlIikKKyAgICAodmVyc2lvbiAiMS40LjAiKQor ICAgIChzb3VyY2UKKyAgICAgKG9yaWdpbgorICAgICAgIChtZXRob2QgZ2l0LWZldGNoKQorICAg ICAgICh1cmkKKyAgICAgICAgKGdpdC1yZWZlcmVuY2UKKyAgICAgICAgICh1cmwgImh0dHBzOi8v Z2l0aHViLmNvbS9ydWRvbGZvY2hyaXN0L2ludGVybGVhdmUiKQorICAgICAgICAgKGNvbW1pdCAo c3RyaW5nLWFwcGVuZCAiaW50ZXJsZWF2ZS0iIHZlcnNpb24pKSkpCisgICAgICAgKGZpbGUtbmFt ZSAoZ2l0LWZpbGUtbmFtZSBuYW1lIHZlcnNpb24pKQorICAgICAgIChzaGEyNTYKKyAgICAgICAg KGJhc2UzMgorICAgICAgICAgIjBsNWI2ODFtcnBrMTJseDVjMTZtN2tjMTNwMjl6Nnppc213ZzFs bHNqZzdjZG1ybXNyY2IiKSkpKQorICAgIChidWlsZC1zeXN0ZW0gZW1hY3MtYnVpbGQtc3lzdGVt KQorICAgIChob21lLXBhZ2UKKyAgICAgImh0dHBzOi8vZ2l0aHViLmNvbS9ydWRvbGZvY2hyaXN0 L2ludGVybGVhdmUiKQorICAgIChzeW5vcHNpcworICAgICAiQSBtaW5vciBtb2RlIHRoYXQgcHJl c2VudHMgYSBkb2N1bWVudCBidWZmZXIgbmV4dCB0byBhbiBvcmdtb2RlIGJ1ZmZlciIpCisgICAg KGRlc2NyaXB0aW9uCisgICAgICJJbnRlcmxlYXZlIGlzIGEgbWlub3IgbW9kZSB0aGF0IHByZXNl bnRzIGEgZG9jdW1lbnQgdmlld2VyIHNpZGUKK2J5IHNpZGUgdG8gYW4gb3JnbW9kZSBidWZmZXIg d2l0aCB5b3VyIG5vdGVzIHJlbGV2YW50IHRvIHRoZSBjdXJyZW50IHBhZ2UuIikKKyAgICAobGlj ZW5zZSBsaWNlbnNlOmdwbDMrKSkpCisKIChkZWZpbmUtcHVibGljIGVtYWNzLWl2eQogICAocGFj a2FnZQogICAgIChuYW1lICJlbWFjcy1pdnkiKQotLSAKMi4yNi4yCgo= --b1_1b2291990679f01aceba5bfe4cdac084--