From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id QJo0KJNVmWDnEAEAgWs5BA (envelope-from ) for ; Mon, 10 May 2021 17:47:31 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id eBLyI5NVmWAtegAA1q6Kng (envelope-from ) for ; Mon, 10 May 2021 15:47:31 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E4BB4243C8 for ; Mon, 10 May 2021 17:47:30 +0200 (CEST) Received: from localhost ([::1]:40626 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lg882-0000BP-2U for larch@yhetil.org; Mon, 10 May 2021 11:47:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54908) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lg87A-0008FE-7N for help-guix@gnu.org; Mon, 10 May 2021 11:46:36 -0400 Received: from mout02.posteo.de ([185.67.36.66]:54801) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lg875-0007ut-Mg for help-guix@gnu.org; Mon, 10 May 2021 11:46:35 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 48D5D2400FC for ; Mon, 10 May 2021 17:46:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1620661589; bh=0/ig0jYYTz8zJDR9V2LSfQmYiSgeJotVjOppDPPA3Cw=; h=Subject:To:Cc:From:Date:From; b=lKi1Fg/VFKpOTRP3Yq4XRcKPyLf1gbP/bKY0p6k/AetjIZokvkgx1Z7SScB3hRDaH WG21DRhQDB3hxcTe4AC7UDoKAzkrRK9BRAafJC2EI7LcD+dR8P7XIp/lhoggsgBGdy +uZOwteg+z5tCgqX0On9e+3QlZSVX9smehVJYZuD3VA5nigYOrLtX9waIc+YA3ziSw F5jvsEIaS+LrWTqyYN2Gd697K+SkCI7tPEet//0SD6Xy1fZEuQbM1kGDStY0h3VqoI BpqDOu+5w6CwYMmHI4IJXrMn5MP+TPdUEDEUuYBx2UQ1EjpNT6SlRvHrNTPZXROxmz wVLosjxIqQdpw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Ff5502KGgz9rxp; Mon, 10 May 2021 17:46:28 +0200 (CEST) Subject: Re: Process of adding a package To: Ricardo Wurmus References: <87fsyuq4tz.fsf@elephly.net> From: Zelphir Kaltstahl Message-ID: Date: Mon, 10 May 2021 15:46:27 +0000 MIME-Version: 1.0 In-Reply-To: <87fsyuq4tz.fsf@elephly.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US Received-SPF: pass client-ip=185.67.36.66; envelope-from=zelphirkaltstahl@posteo.de; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: help-guix@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: help-guix@gnu.org Errors-To: help-guix-bounces+larch=yhetil.org@gnu.org Sender: "Help-Guix" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1620661651; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=rur364GJ6NTxSmTDUgee7K+hPUNcHdWvMpS11z4qvBs=; b=kjfUpGScx0H5UmPZen+Kt33gJgEqWtVeCTOOqxZXiYiP1aF3YRD76FT5lgUpGZpRHCVH0g h8pkmr9eauJkGts4UkDew/oXnQesJufhYuNfOP8kcXDOjTx4HH7erd+FjHGTd9Hdzg0ZxY NDYCvrY9fPgOSqJpY/NfTueNmyE1Apz4VEEVtOySKtU62NJc2e78qFNy1dZ2U1wndX66hF mFjNOHj+Vs+Lkt2dFbfhAWpLRBxdROUzudfMq2pPsZdTPtVlIqVJvizTJURaQ6rv4fyU3Q Uc3BzOHdYiD8gx+razPmvHZBHnlfhiP2KE1ENE+Z2m66QcysfRrnbREf6Btrpw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1620661651; a=rsa-sha256; cv=none; b=SkpH4OkjWOMVcP6bwgBdaHcetqeGXgEDA78c/a2TsnAZwHzw0mbrG8HLjOY+QwsI974Tg+ Tq/Q/ODJs6VDPr+fRLzUH+RptLeAnzuxKz8VA/pVyW1SgxUaP/ZSfR9IE2y3mq9L49kdAZ BjaaDaB2Jg/673pbTa2auojXXKLyPn7iuld1DOCPYzghIZ2BFf1D/yT5GDwscRMrsXJrGL G0YMIg028Btjdjcudmdpetay8GD6MZRPzHd8PJIwY3r8IZzdTHU196FVsikq36O7TsIM1n LczhBaFpZA54xEb02MHQJbgtKSRS26t276/oMmgvmN03xl4acNP8Y96IbDeXSQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.de header.s=2017 header.b="lKi1Fg/V"; spf=pass (aspmx1.migadu.com: domain of help-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=help-guix-bounces@gnu.org X-Migadu-Spam-Score: -3.15 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.de header.s=2017 header.b="lKi1Fg/V"; dmarc=pass (policy=none) header.from=posteo.de; spf=pass (aspmx1.migadu.com: domain of help-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=help-guix-bounces@gnu.org X-Migadu-Queue-Id: E4BB4243C8 X-Spam-Score: -3.15 X-Migadu-Scanner: scn0.migadu.com X-TUID: h1aKware+xLG Hi Ricardo! Thank you for your quick reply! I submitted the patch via e-mail attachment. It was recently said on the mailing list, that it should not matter, or even be more reliable, when submitting it as an attachment. However, as I see mostly patches being submitted in the e-mail body, perhaps something automated does not work correctly with patches submitted as attachment? Wildly guessing around here : ) Anyway, thank you for looking at the patch. I thought I had written the patch commit message answering all questions on https://www.gnu.org/prep/standards/html_node/Change-Logs.html#Change-Logs . However, perhaps I should have checked the linked pages there, especially https://www.gnu.org/prep/standards/html_node/Style-of-Change-Logs.html#Style-of-Change-Logs ? Or is it something else, that can be done in a better way about the commit message? Best regards, Zelphir On 5/10/21 12:08 PM, Ricardo Wurmus wrote: > > Hi, > >> What is the usual process, after one has sent in a patch adding a new package to >> GNU Guix? > > Someone would review it, apply the patch, and then push. > >> The background of the question is, that approximately 2 months ago, I sent in a >> patch adding `guile-fslib` > > 2 months is too long.  If you don’t hear from us after a week your patch > likely fell through the cracks and nobody realized it.  You can ping us. > > I wasn’t aware of your patch, but I found it here: > >    https://issues.guix.gnu.org/47697 > > The commit message isn’t according to our standards, but that’s easy to fix.  > The patch itself looks fine, so I’m going to apply it in a moment.  Sorry > about taking so long! > -- repositories: https://notabug.org/ZelphirKaltstahl