unofficial mirror of help-guix@gnu.org 
 help / color / mirror / Atom feed
From: "Ian Eure" <ian@retrospec.tv>
To: help-guix@gnu.org
Subject: Re: Packaging Proton Bridge: Progress Report #1
Date: Mon, 09 Dec 2024 16:38:20 +0000	[thread overview]
Message-ID: <e7efa2b5-9334-4151-b98a-7eadb90c813f@app.fastmail.com> (raw)
In-Reply-To: <13655160.uLZWGnKmhe@aisaka>

Hi Marek,

On Mon, Dec 9, 2024, at 4:24 PM, Marek Paśnikowski wrote:
> I managed to break through version incompatibilites thanks to discovery of the 
> guix:build-system:go:go-version->git-ref function, which allowed me to use the 
> specifications in go.mod files directly.
>
> I am currently blocked on what seems to be an actual upstream coding bug, for 
> which I filed a report:
> https://github.com/ProtonMail/proton-bridge/issues/511
>
> It boils down to an undefined variable reference, which used to be defined two 
> years ago.
>
> Build error:
> src/github.com/ProtonMail/proton-bridge/v3/internal/frontend/cli/system.go:
> 48:43: undefined: bridge.Credits
>
> Commit reference:
> https://github.com/ProtonMail/proton-bridge/commit/
> 77cd2955f1413c96a1d987d0d7f9d8ecf6a8ad49
>
> The removed code snippet in file internal/bridge/credits.go :
> package bridge
> const Credits = "string of go module paths"
>

This isn't an upstream bug, it's an error in your package.  As the "(generated)" comment in .gitignore in your liked commit implies, this file is now codegenned as part of the build: https://github.com/ProtonMail/proton-bridge/blob/4f4a2c3fd8f7304a9b3ff81d3f42828b95296b7f/Makefile#L351-L353

Since you're not running the command that creates the file, the build fails.

  -- Ian


  reply	other threads:[~2024-12-09 16:39 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-30 16:26 Packaging Proton Bridge: cryptic compilation failure Marek Paśnikowski
2024-11-30 17:29 ` Ian Eure
2024-11-30 18:08 ` Cayetano Santos
2024-11-30 18:56   ` Marek Paśnikowski
2024-11-30 19:22     ` Ian Eure
2024-12-05 16:37       ` sebastien
2024-12-06 13:34         ` woshilapin
2024-12-06 18:01         ` Marek Paśnikowski
2024-12-09 16:24 ` Packaging Proton Bridge: Progress Report #1 Marek Paśnikowski
2024-12-09 16:38   ` Ian Eure [this message]
2024-12-09 16:47     ` Marek Paśnikowski
2024-12-09 16:52       ` Ian Eure
2024-12-09 19:15         ` Marek Paśnikowski
2024-12-09 19:33           ` Ian Eure
2024-12-10 10:28 ` Packaging Proton Bridge: Progress Report #2 Marek Paśnikowski
2024-12-10 14:08   ` Suhail Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e7efa2b5-9334-4151-b98a-7eadb90c813f@app.fastmail.com \
    --to=ian@retrospec.tv \
    --cc=help-guix@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).