From: Tobias Geerinckx-Rice <me@tobias.gr>
To: brice@waegenei.re
Cc: Simon Josefsson <simon@josefsson.org>, help-guix@gnu.org
Subject: Re: 'guix reconfigure' fail to build 'rsnapshot'
Date: Sat, 17 Jul 2021 20:00:04 +0200 [thread overview]
Message-ID: <e2794d1c382a85ba92abc86aa6d22b24@tobias.gr> (raw)
In-Reply-To: <3987-60f31800-ed-3bd98f40@168269356>
On 2021-07-17 19:49, brice@waegenei.re wrote:
> Maybe removing our substitution will fix our build issue:
> --8<---------------cut here---------------start------------->8---
> @@ -526,15 +526,6 @@ rdiff-backup is easy to use and settings have
> sensible defaults.")
> (modify-phases %standard-phases
> (replace 'check
> (lambda _
> - (substitute*
> '("t/cmd-post_pre-exec/conf/pre-true-post-true.conf"
> - "t/backup_exec/conf/backup_exec_fail.conf"
> - "t/backup_exec/conf/backup_exec.conf")
> - (("/bin/true") (which "true"))
> - (("/bin/false") (which "false")))
> -
> - ;; Disable a test that tries to connect to localhost on
> port 22.
> - (delete-file "t/ssh_args/ssh_args.t.in")
> -
> (invoke "make" "test"))))))
> (inputs
> `(("perl" ,perl)
> --8<---------------cut here---------------end--------------->8---
This is probably cleaner if you've verified that the tests are still
run. LGTM!
Kind regards,
T G-R
Sent from a Web browser. Excuse or enjoy my brevity.
next prev parent reply other threads:[~2021-07-17 18:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-17 16:07 'guix reconfigure' fail to build 'rsnapshot' Simon Josefsson via
2021-07-17 17:49 ` brice
2021-07-17 18:00 ` Tobias Geerinckx-Rice [this message]
2021-07-17 19:04 ` Simon Josefsson via
2021-07-17 17:55 ` Tobias Geerinckx-Rice
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2794d1c382a85ba92abc86aa6d22b24@tobias.gr \
--to=me@tobias.gr \
--cc=brice@waegenei.re \
--cc=help-guix@gnu.org \
--cc=simon@josefsson.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).