From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id EEp+LCZGEWHYJwEAgWs5BA (envelope-from ) for ; Mon, 09 Aug 2021 17:13:42 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id KCtcKCZGEWEuCwAAB5/wlQ (envelope-from ) for ; Mon, 09 Aug 2021 15:13:42 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 88685288B2 for ; Mon, 9 Aug 2021 17:13:41 +0200 (CEST) Received: from localhost ([::1]:40748 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mD6yC-0004yI-K9 for larch@yhetil.org; Mon, 09 Aug 2021 11:13:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36320) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mD6y2-0004xw-7I for help-guix@gnu.org; Mon, 09 Aug 2021 11:13:30 -0400 Received: from mail-40134.protonmail.ch ([185.70.40.134]:46842) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mD6xy-00068k-MX for help-guix@gnu.org; Mon, 09 Aug 2021 11:13:29 -0400 Date: Mon, 09 Aug 2021 15:13:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1628522001; bh=LwqO2sZDZlFtyhTF9QsLtAtAOhBexLmg4Hyltt5mPwA=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=CsRpzoJGSooPuNSzv3siaq62LAkGesEHd6aHlvWdxujSvREUvQwOiSgWg4Bqw0l43 6jopSi7k3YmLwsHLGVL2xzGFi6eMQtbcC43xalz749lis6CQLWGq3G7cAR39gCvD3o +ikKY2jtKebY/euFk8JjmgVagE1j6XOm7caPD8bc= To: Efraim Flashner From: phodina Cc: Julien Lepiller , phodina via Subject: Re: Non deterministic package Message-ID: In-Reply-To: References: <25E731BD-DF0D-4A60-9440-E53DE1FC6FE0@lepiller.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.70.40.134; envelope-from=phodina@protonmail.com; helo=mail-40134.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: help-guix@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: phodina Errors-To: help-guix-bounces+larch=yhetil.org@gnu.org Sender: "Help-Guix" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1628522021; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=LwqO2sZDZlFtyhTF9QsLtAtAOhBexLmg4Hyltt5mPwA=; b=h4lTse9VXuV/j3Mg80YeAwQ1EdYg6cZBbxobEd4XqfDfiTyUnx0YdIlqrZQLoxOfU28WtV y+uGLwADxgTksv/ZFBZ3/QTs9G4Bq+MB1CUIcGWVrHRjSv3WshdJYwVGlweZmu4ninW4oR EOx+DfOJImTRFfm42GfBPaHIrlXAVgJV9uRYZWG/+Xqxko8k1+L/Evajz57BFlqJdYoMxw neSj+4UDpEQ9ZnOwSTyuOLKaG3B27B3pDjI7tfHiuGAJUr4U/auGW7ssS90hye25aGZk0A zY7o4yk6n4XU7EEZVkp73yI7TiMkwujINCZahe0a+nwfCt7Z0tcLe+1QIklfow== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1628522021; a=rsa-sha256; cv=none; b=aYH7fJp8tylfj+DTetj8G24zo6zKv5zEKkPq2dip3Mlkxs5js6xJ7ADHCTS3ZAgXq5SXKw Ry16md4PMOoo/lhGMuedifZjDDyfZcWWFTMmBZ4Na5GVUmBSyVKwb9SCmpYBsvx7DSLZhS VXZsomSncI4/9WHlDD8WeT1hFR2xoa/+f6KATx/A6yzjCmr16xQL3RCZCmXV8AaiprUoBn MO+WM9ZhLi6fAdctoyuYVBpx0sPGtKxjR0FL9U0UiqrlyhnREIobg4/aLeaVJFTspQcFUi l/vHVBOei9Y/NzaP3bfPnyLPv3iwFqG6eZNoYyA7WyZYRQf4RKVfXBFLyuMxDg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=protonmail.com header.s=protonmail header.b=CsRpzoJG; spf=pass (aspmx1.migadu.com: domain of help-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=help-guix-bounces@gnu.org X-Migadu-Spam-Score: -3.11 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=protonmail.com header.s=protonmail header.b=CsRpzoJG; dmarc=pass (policy=quarantine) header.from=protonmail.com; spf=pass (aspmx1.migadu.com: domain of help-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=help-guix-bounces@gnu.org X-Migadu-Queue-Id: 88685288B2 X-Spam-Score: -3.11 X-Migadu-Scanner: scn0.migadu.com X-TUID: HydlBE9XMXml > I've become involved in the rust packaging effort so I'll jump in with > > some specifics. > > On Wed, Aug 04, 2021 at 03:50:00PM -0400, Julien Lepiller wrote: > > > Le 4 ao=C3=BBt 2021 15:14:16 GMT-04:00, phodina via help-guix@gnu.org a= =C3=A9crit=C2=A0: > > > > > Hi, > > > > > > I came across a package in the Guix repository which fails to build. = The package in question here is rust-brotli-sys-0.3. So the obvious questio= n comes up. How does this happen? > > > > > > I just ran =3Dguix build rust-brotli-sys=3D with the following output= : > > > > > > ... > > > > > > phase `reset-gzip-timestamps' succeeded after 0.0 seconds starting ph= ase` compress-documentation' > > > > > > phase `compress-documentation' succeeded after 0.0 seconds guix build= : error: derivation` /gnu/store/kf8kwl7yn8jqpwc9p97bw8vs5g5bvas4-rust-brotl= i-sys-0.3.2.drv' may not be deterministic: output `/gnu/store/yrrdr6rrc1s4b= 9lf7wz40c2gnv5kvxff-rust-brotli-sys-0.3.2' differs > > > > > > Also this is my guix channel: > > > > > > guix: > > > > > > repository URL: https://git.savannah.gnu.org/git/guix.git > > > > > > branch: master > > > > > > commit: b95fb85f593d377864fc1bfb3c118e54d03783be > > > > > > I tried to run the build with the flag --check and multiple rounds, b= ut got the same result. > > > > > > So could it be caused by not running =3D./pre-inst-env guix build --r= ounds=3D2 =3D when submitting the patch? > > > > You need to use. /pre-inst-env to test your patches, otherwise you'll o= nly run your current guix. For an added package, it will be missing, for an= updated package it will not build the newer version, etc. > > > > > Or when somebody updates some pkg that this pkg depends on and does n= ot run =3D./pre-inst-env guix --refresh --list-dependent=3D and then check = the dependent pkgs? > > > > It can also happen when only the current day is recorded in the output:= if you use =E2=80=94rounds=3D2, it is likely run on the same day, so the o= utput will be the same (don't bother though, last time I found such an issu= e it was in january because only the year was recorded ^^") > > > > You should now use -K to keep the different version and run diffoscope = to analyze the differences. Then we should be able to fix the non determini= sm. > > > > > Could also sombody please share what kind of CI pipeline is there imp= lemented on applying the patch on the mainter's side? > > > > The maentainer is responsible for testing the patch (at a minimum that = it builds), and sometimes we forget to check it's reproducible. The only au= tomated thing is to check the patch is signed. > > > > > Thanks > > > > > > Petr > > > > > > PS: Yes, I do have more questions regading how Guix works lately. I t= ried to search the mailing list but haven't found answers to them > > I'm not always great with diffoscope, but it turns out this one isn't > > too bad to read. > > (ins)efraim@3900XT ~ [env]$ diffoscope /gnu/store/yrrdr6rrc1s4b9lf7wz40c2= gnv5kvxff-rust-brotli-sys-0.3.2 /gnu/store/yrrdr6rrc1s4b9lf7wz40c2gnv5kvxff= -rust-brotli-sys-0.3.2-check > > --- /gnu/store/yrrdr6rrc1s4b9lf7wz40c2gnv5kvxff-rust-brotli-sys-0.3.2 > > +++ /gnu/store/yrrdr6rrc1s4b9lf7wz40c2gnv5kvxff-rust-brotli-sys-0.3.2-che= ck > > =E2=94=82 --- /gnu/store/yrrdr6rrc1s4b9lf7wz40c2gnv5kvxff-rust-brotli-sys= -0.3.2/share > > =E2=94=9C=E2=94=80=E2=94=80 +++ /gnu/store/yrrdr6rrc1s4b9lf7wz40c2gnv5kvx= ff-rust-brotli-sys-0.3.2-check/share > > =E2=94=82 =E2=94=82 --- /gnu/store/yrrdr6rrc1s4b9lf7wz40c2gnv5kvxff-rust-= brotli-sys-0.3.2/share/cargo > > =E2=94=82 =E2=94=9C=E2=94=80=E2=94=80 +++ /gnu/store/yrrdr6rrc1s4b9lf7wz4= 0c2gnv5kvxff-rust-brotli-sys-0.3.2-check/share/cargo > > =E2=94=82 =E2=94=82 =E2=94=82 --- /gnu/store/yrrdr6rrc1s4b9lf7wz40c2gnv5k= vxff-rust-brotli-sys-0.3.2/share/cargo/registry > > =E2=94=82 =E2=94=82 =E2=94=9C=E2=94=80=E2=94=80 +++ /gnu/store/yrrdr6rrc1= s4b9lf7wz40c2gnv5kvxff-rust-brotli-sys-0.3.2-check/share/cargo/registry > > =E2=94=82 =E2=94=82 =E2=94=82 =E2=94=82 --- /gnu/store/yrrdr6rrc1s4b9lf7w= z40c2gnv5kvxff-rust-brotli-sys-0.3.2/share/cargo/registry/brotli-sys-0.3.2.= crate > > =E2=94=82 =E2=94=82 =E2=94=82 =E2=94=9C=E2=94=80=E2=94=80 +++ /gnu/store/= yrrdr6rrc1s4b9lf7wz40c2gnv5kvxff-rust-brotli-sys-0.3.2-check/share/cargo/re= gistry/brotli-sys-0.3.2.crate > > =E2=94=82 =E2=94=82 =E2=94=82 =E2=94=82 =E2=94=9C=E2=94=80=E2=94=80 brotl= i-sys-0.3.2.crate-content > > =E2=94=82 =E2=94=82 =E2=94=82 =E2=94=82 =E2=94=82 =E2=94=9C=E2=94=80= =E2=94=80 file list > > =E2=94=82 =E2=94=82 =E2=94=82 =E2=94=82 =E2=94=82 =E2=94=82 @@ -1,8 +1,8 = @@ > > =E2=94=82 =E2=94=82 =E2=94=82 =E2=94=82 =E2=94=82 =E2=94=82 --rw-r--r-- 0= 0 0 1123 2021-08-05 07:38:54.000000 brotli-sys-0.3.2/Cargo.toml > > =E2=94=82 =E2=94=82 =E2=94=82 =E2=94=82 =E2=94=82 =E2=94=82 +-rw-r--r-- 0= 0 0 1123 2021-08-05 07:38:41.000000 brotli-sys-0.3.2/Cargo.toml > > =E2=94=82 =E2=94=82 =E2=94=82 =E2=94=82 =E2=94=82 =E2=94=82 -rw-r--r-- 0 = 999 30000 1122 1970-01-01 00:00:00.000000 brotli-sys-0.3.2/Cargo.toml.orig > > =E2=94=82 =E2=94=82 =E2=94=82 =E2=94=82 =E2=94=82 =E2=94=82 -rw-r--r-- 0 = 999 30000 2168 2017-06-30 05:59:10.000000 brotli-sys-0.3.2/brotli/common/co= nstants.h > > =E2=94=82 =E2=94=82 =E2=94=82 =E2=94=82 =E2=94=82 =E2=94=82 -rw-r--r-- 0 = 999 30000 471278 2017-09-19 18:16:36.000000 brotli-sys-0.3.2/brotli/common/= dictionary.c > > =E2=94=82 =E2=94=82 =E2=94=82 =E2=94=82 =E2=94=82 =E2=94=82 -rw-r--r-- 0 = 999 30000 1499 2017-09-19 18:16:36.000000 brotli-sys-0.3.2/brotli/common/di= ctionary.h > > =E2=94=82 =E2=94=82 =E2=94=82 =E2=94=82 =E2=94=82 =E2=94=82 -rwxr-xr-x 0 = 999 30000 595 2017-09-19 18:16:36.000000 brotli-sys-0.3.2/brotli/common/ver= sion.h > > =E2=94=82 =E2=94=82 =E2=94=82 =E2=94=82 =E2=94=82 =E2=94=82 -rw-r--r-- 0 = 999 30000 1259 2017-06-30 05:59:10.000000 brotli-sys-0.3.2/brotli/dec/bit_r= eader.c > > =E2=94=82 =E2=94=82 =E2=94=82 =E2=94=82 =E2=94=82 =E2=94=82 -rw-r--r-- 0 = 999 30000 12006 2017-06-30 05:59:10.000000 brotli-sys-0.3.2/brotli/dec/bit_= reader.h > > =E2=94=82 =E2=94=82 =E2=94=82 =E2=94=82 =E2=94=9C=E2=94=80=E2=94=80 stat = {} > > =E2=94=82 =E2=94=82 =E2=94=82 =E2=94=82 =E2=94=82 @@ -1,8 +1,8 @@ > > =E2=94=82 =E2=94=82 =E2=94=82 =E2=94=82 =E2=94=82 > > =E2=94=82 =E2=94=82 =E2=94=82 =E2=94=82 =E2=94=82 - Size: 406369 Blocks: = 800 IO Block: 4096 regular file > > =E2=94=82 =E2=94=82 =E2=94=82 =E2=94=82 =E2=94=82 + Size: 406370 Blocks: = 800 IO Block: 4096 regular file > > =E2=94=82 =E2=94=82 =E2=94=82 =E2=94=82 =E2=94=82 Links: 1 > > =E2=94=82 =E2=94=82 =E2=94=82 =E2=94=82 =E2=94=82 Access: (0444/-r--r--r-= -) Uid: ( 0/ root) Gid: ( 0/ root) > > =E2=94=82 =E2=94=82 =E2=94=82 =E2=94=82 =E2=94=82 > > =E2=94=82 =E2=94=82 =E2=94=82 =E2=94=82 =E2=94=82 Modify: 1970-01-01 00:0= 0:01.000000000 +0000 > > Here the difference is the timestamp on Cargo.toml. Cargo.toml gets > > regenerated during the build process (likely when we run `cargo build`) > > and then during the install phase we create a tarball of the source and > > put that and an unpacked version in %out/share/cargo as a step toward > > switching from #:cargo-inputs to just 'inputs'. > > Ideally we'd modify the install phase or add a new phase to reset some > > of the timestamps. Unfortunately, modifying the cargo-build-system would > > result in the rebuild of ~2500 packages, or ~150, depending on how you > > count. > > I can see about queueing up something for core-updates-frozen, which > > will make its way back to the master branch soonish=E2=84=A2. > > -------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= - > > Efraim Flashner efraim@flashner.co.il =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 > > GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 > > Confidentiality cannot be guaranteed on emails sent or received unencrypt= ed Thanks Julien and Efraim. I didn't know about diffoscope, I see it's descri= bed in the manual[1]. I agree that the package build might build if the second build runs the sam= e day. I'll add this tool to my list of checks for submitting new patches. I use ./pre-inst-env to build and lint the package in question. Not the gui= x binary in my system itself. So I was little bit surprised that this packa= ge didn't build as it was already part of the Guix monorepo.Also this was t= he first time I encountered such an issue. [1]: https://guix.gnu.org/manual/en/html_node/Invoking-guix-challenge.html