From: divoplade <d@divoplade.fr>
To: John Soo <jsoo1@asu.edu>, Julien Lepiller <julien@lepiller.eu>
Cc: help-guix@gnu.org
Subject: Re: Newbie tries to add a snippet to an origin
Date: Sat, 01 Aug 2020 18:23:23 +0200 [thread overview]
Message-ID: <b45066b78dfc8a9dee6d6f57db735471649c547e.camel@divoplade.fr> (raw)
In-Reply-To: <938CF7BF-54A6-4816-A1DE-05D64E599174@asu.edu>
Thank you so much for your help, now I can build both packages without
hassle. The filled-in module template is dynamically computed [1], so I
do not need to care about passing the version number around.
https://framagit.org/divoplade/pomdappi/-/jobs/1068726/artifacts/raw/public/divoplade/packages/pomdappi.scm
Le samedi 01 août 2020 à 09:00 -0700, John Soo a écrit :
> Since you are using the gnu build system, I suggest making your
> version number a variable in the makefile. The good part of using a
> make variable is that you can use $(shell git describe ...) normally
> and override it when building with guix. You can use the make or
> configure flags arguments to override the version number with the
> guix package version number.
I don't think it is wise to let the user update the version number with
a simple configure switch or make variable; it could make things very
confusing for debugging. Updating the version number is more of a
maintainer task, so it makes sense to write it in stone during the
maintainer phase (bootstrap / autoreconf).
divoplade
next prev parent reply other threads:[~2020-08-01 16:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-01 15:17 Newbie tries to add a snippet to an origin divoplade
2020-08-01 15:26 ` John Soo
2020-08-01 15:44 ` divoplade
2020-08-01 15:50 ` Julien Lepiller
2020-08-01 16:00 ` John Soo
2020-08-01 16:23 ` divoplade [this message]
2020-08-01 16:27 ` John Soo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b45066b78dfc8a9dee6d6f57db735471649c547e.camel@divoplade.fr \
--to=d@divoplade.fr \
--cc=help-guix@gnu.org \
--cc=jsoo1@asu.edu \
--cc=julien@lepiller.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).