Re: Is a graft warranted here?

[Tomas Volf <~@wolfsden.cz>]

[-- Attachment #1: Type: text/plain, Size: 3038 bytes --]

Hello Felix,

On 2024-06-14 16:27:35 -0700, Felix Lechner via wrote:
> Hi,
>
> Why does the package definition below provide a grafted version 1.08.1
> instead of the source I requested, please?
>
> Kind regards
> Felix
>
> * * *
>
> (define-public nyacc/juix
>   (let* ((commit "41691b062b598a92549821879766e0ee48b635da")
>          (revision "0"))
>     (package
>       (inherit nyacc)
>       (name "nyacc")
>       (version "1.10-dev")
>       (source (origin
>                 (method git-fetch)
>                 (uri (git-reference
>                       (url "https://git.savannah.nongnu.org/git/nyacc.git")
>                       (commit commit)))
>                 (file-name (git-file-name name version))
>                 (sha256
>                  (base32
>                   "1fa88fix6avyazyiy4k70v9fzdkz1i0p99xnmxmq94j3wpc76y3j"))
>                 (modules '((guix build utils)))
>                 (snippet
>                  '(substitute* "configure"
>                     (("GUILE_GLOBAL_SITE=\\$prefix.*")
>                      "GUILE_GLOBAL_SITE=\
> $prefix/share/guile/site/$GUILE_EFFECTIVE_VERSION\n"))))))))
>

Maybe I misunderstood something, but for me it seems to provide what I assume
would be 1.10-dev:

    $ cat $(guix build -e '(begin (use-modules (guix git-download) (gnu packages mes) (guix) (gnu) (gnu packages)) (let* ((commit "41691b062b598a92549821879766e0ee48b635da")
             (revision "0"))
        (package
          (inherit nyacc)
          (name "nyacc")
          (version "1.10-dev")
          (source (origin
                    (method git-fetch)
                    (uri (git-reference
                          (url "https://git.savannah.nongnu.org/git/nyacc.git")
                          (commit commit)))
                    (file-name (git-file-name name version))
                    (sha256
                     (base32
                      "1fa88fix6avyazyiy4k70v9fzdkz1i0p99xnmxmq94j3wpc76y3j"))
                    (modules (quote ((guix build utils))))
                    (snippet
                     (quote (substitute* "configure"
                        (("GUILE_GLOBAL_SITE=\\$prefix.*")
                         "GUILE_GLOBAL_SITE=\
    $prefix/share/guile/site/$GUILE_EFFECTIVE_VERSION\n")))))))))')/share/guile/site/3.0/nyacc/version.scm | tail -n7 | head -n5
    (define-module (nyacc version)
      #:export (*nyacc-version*)
      #:version (1 09 4))

    (define *nyacc-version* "1.09.4")

When I do the same for nyacc I get different output:

    $ cat $(guix build nyacc)/share/guile/site/3.0/nyacc/version.scm | tail -n7 | head -n5
    (define-module (nyacc version)
      #:export (*nyacc-version*)
      #:version (1 08 1))

    (define *nyacc-version* "1.08.1")

This is on up-to-date Guix.  I am probably not seeing the problem (it is bit
late).  Could you write bit more about how to reproduce it and what to look for?

Thanks,
Tomas

--
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]