From: "Marc Coquand" <marc@mccd.space>
To: "Felix Lechner" <felix.lechner@lease-up.com>, <help-guix@gnu.org>
Subject: Re: Changing the prefix for this libpg_query package
Date: Sun, 25 Feb 2024 14:03:38 -0600 [thread overview]
Message-ID: <CZEFG7TR7CXT.2KJD3JDALCL5U@mccd.space> (raw)
In-Reply-To: <87bk84zb2k.fsf@lease-up.com>
Hey everyone!
Thanks for your support. This was my first post to support, so it was stuck
in review for a while. I was able to resolve it using the same substitute
function Felix shared.
So now my patch is up for review:
https://issues.guix.gnu.org/69309
Thanks everyone for your help.
Sincerely,
Marc
On Sun Feb 25, 2024 at 11:51 AM CST, Felix Lechner wrote:
> Hi Marc,
>
> On Tue, Feb 20 2024, Marc Coquand wrote:
>
> > I need to change the prefix to be the guix out directory
>
> To override the variable assigned in the Makefile [1] you are right to
> offer it as an argument to 'make'. [2] I'm not sure why that's not
> working. I would just replace it in situ:
>
> #:phases (modify-phases %standard-phases
> (add-after 'unpack 'fix-prefix
> (lambda _
> (substitute* "Makefile"
> (("/usr/local") $output)))))
>
> Kind regards
> Felix
>
> [1] https://github.com/pganalyze/libpg_query/blob/1ec38940e5c6f09a4c1d17a46d839a881c4f2db7/Makefile#L311
> [2] https://www.gnu.org/software/make/manual/make.html#Overriding
prev parent reply other threads:[~2024-02-25 20:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-20 19:46 Changing the prefix for this libpg_query package Marc Coquand
2024-02-25 14:04 ` Tomas Volf
2024-02-25 17:51 ` Felix Lechner via
2024-02-25 20:03 ` Marc Coquand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CZEFG7TR7CXT.2KJD3JDALCL5U@mccd.space \
--to=marc@mccd.space \
--cc=felix.lechner@lease-up.com \
--cc=help-guix@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).