From: Greg Hogan <code@greghogan.com>
To: Suhail <suhail@bayesians.ca>
Cc: Simon Tournier <zimon.toutoune@gmail.com>,
Felix Lechner via <help-guix@gnu.org>,
Julien Lepiller <julien@lepiller.eu>,
Felix Lechner <felix.lechner@lease-up.com>
Subject: Re: Turning off tests leads to a different store item
Date: Thu, 2 Nov 2023 12:03:54 -0400 [thread overview]
Message-ID: <CA+3U0ZnWs_yJT9+pkR2V2Gr3TCPc64T6tm1-M8m5_cm6L6sLHw@mail.gmail.com> (raw)
In-Reply-To: <6543bf92.d40a0220.bbcd0.1118SMTPIN_ADDED_BROKEN@mx.google.com>
On Thu, Nov 2, 2023 at 11:26 AM Suhail <suhail@bayesians.ca> wrote:
> Perhaps not all. The thing that sets the "check" phase (#:tests?) apart
> from the rest is that it's an identity transform with a
> side-effect. i.e., it simply reports on the state of its input (i.e.,
> the build artifact) leaving the build artifact unchanged. The only other
> phase in the gnu-build-system that is similar to the "check phase" is
> the "validate-runpath phase".
Suhail,
Should this say "without side-effects"? How does one guarantee that
the test phase is free of side-effects?
Perhaps it might be possible to add a new, throwaway layer to the
OverlayFS so that the tests could still write but would not modify the
filesystem.
Alternatively, could we make it easier to record a timestamp in the
manifest for Guix to use as the build clock time? Several packages
already make use of libfaketime, but this could be integrated into the
build process. Not sure of any issues regarding faketime, performance
or otherwise.
Greg
next parent reply other threads:[~2023-11-02 16:04 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <6543bf92.d40a0220.bbcd0.1118SMTPIN_ADDED_BROKEN@mx.google.com>
2023-11-02 16:03 ` Greg Hogan [this message]
[not found] <65429087.0c0a0220.5908c.4d60SMTPIN_ADDED_BROKEN@mx.google.com>
2023-11-07 18:58 ` Turning off tests leads to a different store item Maxim Cournoyer
2023-11-07 21:58 ` Csepp
2023-11-08 2:53 ` Felix Lechner via
2023-11-08 14:45 ` Maxim Cournoyer
2023-11-08 17:07 ` Felix Lechner via
2023-11-08 18:18 ` Vagrant Cascadian
2023-11-08 19:20 ` Saku Laesvuori
2023-11-08 22:21 ` Simon Tournier
2023-11-09 3:17 ` Maxim Cournoyer
2023-11-09 7:37 ` Simon Tournier
2023-11-09 15:04 ` Maxim Cournoyer
2023-11-16 9:31 ` Simon Tournier
2023-11-18 4:38 ` Maxim Cournoyer
2023-11-03 14:13 Suhail
2023-11-05 12:07 ` Simon Tournier
-- strict thread matches above, loose matches on Subject: below --
2023-11-02 18:54 Suhail
2023-11-03 9:33 ` Simon Tournier
2023-11-02 17:25 Suhail
2023-11-02 15:25 Suhail
2023-11-02 17:02 ` Simon Tournier
2023-11-02 17:46 ` Simon Tournier
2023-11-03 13:08 ` Tomas Volf
2023-11-03 20:44 ` Suhail
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+3U0ZnWs_yJT9+pkR2V2Gr3TCPc64T6tm1-M8m5_cm6L6sLHw@mail.gmail.com \
--to=code@greghogan.com \
--cc=felix.lechner@lease-up.com \
--cc=help-guix@gnu.org \
--cc=julien@lepiller.eu \
--cc=suhail@bayesians.ca \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).