unofficial mirror of help-guix@gnu.org 
 help / color / mirror / Atom feed
From: phodina <phodina@protonmail.com>
To: Tobias Geerinckx-Rice <me@tobias.gr>
Cc: help-guix <help-guix@gnu.org>
Subject: Re: Custom libre kernel configuration
Date: Sat, 13 Nov 2021 08:08:42 +0000	[thread overview]
Message-ID: <A3fSvCPQDcNJoI5KbYELg2UyralQ8hA-tKq7_Dz28e6op2B5lTvxRHqqqRGg5FE0RJ3ms3BVFjJ5zIJRKkle8wOs7Y8zm5KtivM7Nh1wcNA=@protonmail.com> (raw)
In-Reply-To: <877dddhrcp.fsf@nckx>

Thanks Tobia,

> You're not matching numbers here: ‘number’ is your chosen variable name, not magic. It could be ‘foo’. It could be anything, without changing the effect of this code.
>
> >                       ((option . string)
> >                        (string-append option "=\\"" string >                        "\\"")))
> >
>
> This will never be reached.
>
> I'm almost certain that this is, at least in part, why your BINDER configuration isn't taking effect.
>
> Here's mine:
>
> (define option->string
>
> (match-lambda ((option . #f)
>
> (format #f "# ~a is not set" option))
>
> ((option . #t)
>
> (format #f "~a=y" option))
>
> ((option . 'm)
>
> (format #f "~a=m" option))
>
> ((option . (? number? value))
>
> (format #f "~a=~a" option value))
>
> ((option . (? string? value))
>
> (format #f "~a=\"~a\"" option value))))
>
> Kind regards,
>
> T G-R

I took your changes and applied them to the code:

(define (config->string options)
  (string-join (map (match-lambda
                      ((option . #f)
                       (format #f "# ~a is not set" option))
                      ((option . #t)
                       (format #f "~a=y" option))
                      ((option . 'm)
                       (format #f "~a=m" option))
                      ((option . (? number? value))
                       (format #f "~a=~a" option value))
                      ((option . (? string? value))
                       (format #f "~a=\"~a\"" option value)))
                    options)
               "\n"))

However, the CONFIG_ANDROID_BINDER_IPC is still not part of the config :-/

$ grep BINDER .config
# CONFIG_ANDROID_BINDER_IPC is not set

The Guix part of generating the code is fine though. Thanks.

So I digged little deeper and it seems that they have to be compiled into the kernel.

$ tar xf $(guix build linux-libre --source)
$ cd linux-5.14.17
$ guix environment linux --ad-hoc ncurses pkg-config -- make MENUCONFIG_COLOR=mono menuconfig
$ grep ANDROID .config
CONFIG_ANDROID=y
CONFIG_ANDROID_BINDER_IPC=y
CONFIG_ANDROID_BINDERFS=y
CONFIG_ANDROID_BINDER_DEVICES="binder,hwbinder,vndbinder"
# CONFIG_ANDROID_BINDER_IPC_SELFTEST is not set

Though the issue seems to come from the Archlinux Wiki[1] where they supply wrong CONFIG options.

Kind regards
Petr

[1] https://wiki.archlinux.org/title/Waydroid


  reply	other threads:[~2021-11-13  8:09 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-11 12:31 Custom libre kernel configuration phodina
2021-11-11 12:49 ` André A. Gomes
2021-11-11 13:08   ` phodina
2021-11-11 13:23 ` Tobias Geerinckx-Rice
2021-11-11 14:13   ` phodina
2021-11-11 15:01     ` Tobias Geerinckx-Rice
2021-11-11 15:19       ` phodina
2021-11-12 23:38         ` Tobias Geerinckx-Rice
2021-11-13  8:08           ` phodina [this message]
2021-11-13 12:23             ` Custom libre kernel configuration devolving into Anbox review I guess Tobias Geerinckx-Rice
2021-11-13 13:44               ` Tobias Geerinckx-Rice
2021-11-14  7:13               ` phodina
  -- strict thread matches above, loose matches on Subject: below --
2021-11-13 12:35 Custom libre kernel configuration Stefan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='A3fSvCPQDcNJoI5KbYELg2UyralQ8hA-tKq7_Dz28e6op2B5lTvxRHqqqRGg5FE0RJ3ms3BVFjJ5zIJRKkle8wOs7Y8zm5KtivM7Nh1wcNA=@protonmail.com' \
    --to=phodina@protonmail.com \
    --cc=help-guix@gnu.org \
    --cc=me@tobias.gr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).