From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gregor Giesen Subject: Re: Extra files in build container Date: Mon, 19 Jun 2017 13:44:40 +0200 Message-ID: <8c45d3ef-26d9-5818-69e9-c342c243c9e6@zaehlwerk.net> References: <20170615072917.4ogzt24ginrkgqx3@zaehlwerk.net> <87y3ssicsg.fsf@gnu.org> <20170617065848.cfevrq6bpgsa2vlt@zaehlwerk.net> <87r2ygz09e.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:54953) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dMv6u-0001SX-8B for help-guix@gnu.org; Mon, 19 Jun 2017 07:44:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dMv6p-0001lO-Du for help-guix@gnu.org; Mon, 19 Jun 2017 07:44:48 -0400 Received: from mx03.zaehlwerk.net ([136.243.37.109]:42629) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dMv6p-0001lI-5q for help-guix@gnu.org; Mon, 19 Jun 2017 07:44:43 -0400 Received: from localhost (localhost [127.0.0.1]) by mx03.zaehlwerk.net (Postfix) with ESMTP id 2203B2BF6B for ; Mon, 19 Jun 2017 13:44:42 +0200 (CEST) Received: from mail.zaehlwerk.net ([IPv6:::1]) by localhost (ps04.zaehlwerk.net [IPv6:::1]) (amavisd-new, port 10587) with ESMTP id vfuFdwXFdDPa for ; Mon, 19 Jun 2017 13:44:42 +0200 (CEST) Received: from [127.0.0.1] (svc06.zaehlwerk.net [IPv6:2a01:4f8:212:54b::4:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.zaehlwerk.net (Postfix) with ESMTPSA for ; Mon, 19 Jun 2017 13:44:41 +0200 (CEST) In-Reply-To: <87r2ygz09e.fsf@gnu.org> Content-Language: de-DE List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-guix-bounces+gcggh-help-guix=m.gmane.org@gnu.org Sender: "Help-Guix" To: help-guix@gnu.org Dear Ludo=E2=80=99, On Mon, Jun 19, 2017 at 13:26AM +0200 Ludovic Court=C3=A8s wrote: >> On Fri, Jun 16, 2017 at 09:58:55AM +0200, Ludovic Court=C3=A8s wrote: >>> In cases like the one you describe, we usually end up modifying tests= to >>> use the numerical values for services and protocols rather than their >>> names. >> Unfortunately, this turns out to be quite cumbersome since in my case >> (unittests for unbound) there is a lot of test data to be modified and >> in many cases not only plain text but also encrypted records (DNSSEC >> tests). On the other hand the values to be looked up are mostly =E2=80= =9Cudp=E2=80=9D >> and =E2=80=9Ctcp=E2=80=9D in /etc/protocols and =E2=80=9Cdomain=E2=80=9D= in /etc/services, so I decided >> that using a preload library for these few glibc calls just in case of >> the unittest should do the trick rather than no checks at all. >=20 > I think it would be easier to just use =E2=80=98substitute*=E2=80=99 to= replace all the > occurrences of =E2=80=9Ctcp=E2=80=9D, etc., wouldn=E2=80=99t it? alas many occurences of "tcp", "udp", etc. are hidden in=20 encrypted/hashed records, so simple plain text substitutions would break=20 the signatures. >> However, it is an ugly hack and bloats the package definition. > I agree, but it=E2=80=99s hard to improve on it without compromising > reproducibility. It's a good thing that the hack only affects the tests rather than any=20 installation files. I have submitted the package in a patch yesterday (27419). I wonder=20 whether one might want to put the source code of the preload library in=20 an extra file rather than the package definition? Cheers, Gregor